From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB6F7C87FCA for ; Fri, 1 Aug 2025 20:06:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A7847605C3; Fri, 1 Aug 2025 20:06:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id VdhnjrBGFGCP; Fri, 1 Aug 2025 20:06:54 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1E385605D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1754078814; bh=jTLUXu9xxyUUEuBluM7H9l3cUy0DV8HNdkr81r4AC3Q=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=M3N7L4OEF2sr9/Zg0FO9uKWbWiz2Dl8M5VYhejik/Yj9fQCPS9N/ixY+6vJXt+m5I G4M8ju6GBzBsmwB6gLzg1qvOu3CzyyReQN+xqn6/OpQlbg5BuAHXvg5ehs43Pl8qpC OnTyuKHa/Qlk77CmyZmqjzTAsRP4We1+i3eH3amhGPbzYT1QNKT7Zkv8uqjSy9eKDY QD4OlLxdYqklKm3Jq2Tn76AuloyIz2GFXMihWWTE3CahGDroXYrXaVuFLMFN20yvDV tnIRtfswXRLEugLxCjd0Y58ChBrSCZaNPFIV+ETSPAhjZtMQZ+VQYvbXdMFRDxkSqj 5t85nj6ooSiGA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 1E385605D9; Fri, 1 Aug 2025 20:06:54 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 4B63413D for ; Fri, 1 Aug 2025 20:06:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 3D424605B7 for ; Fri, 1 Aug 2025 20:06:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id tkmW7sBfpbLk for ; Fri, 1 Aug 2025 20:06:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1AC80605C3 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1AC80605C3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1AC80605C3 for ; Fri, 1 Aug 2025 20:06:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A7856A5591D; Fri, 1 Aug 2025 20:06:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2108C4CEE7; Fri, 1 Aug 2025 20:06:48 +0000 (UTC) Date: Fri, 1 Aug 2025 13:06:48 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Andrew Lunn , Michael Chan , Pavan Chebbi , Tariq Toukan , Gal Pressman , , Donald Hunter , Carolina Jubran , Paolo Abeni , Simon Horman , , Vadim Fedorenko Message-ID: <20250801130648.341995ba@kernel.org> In-Reply-To: <20250731231019.1809172-1-vadfed@meta.com> References: <20250731231019.1809172-1-vadfed@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754078809; bh=T7/74GDSNVPhlAsnSqKd+bYVq/4pK/GDutVg+bbGPyc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sAnBlyG8blUfyGmDkkkwg6RrtOjkJ+MD0g/Rfz6HsmeAglcOkldBzgC6RiS/ybKkl qMphAhXuXCaiJtIKB600PIHTugUeAZ4bRARSQzanOtERuNEeI29idNcWrcs/4/N2P2 UmhFVw7yq656lo7FRV2gIvAkXZTuN29WvRLIDEnEOAndOWu7DGGeVErR9Vovju7u0G KESESRcrHeeUhXSaSgkFB2TrjuaKBxurDLwqO8OkOkepui6hvCNyk7cf9u420ynijl Uigg33eMBnyhz34T7CNJXOFypx9wmY1m0MZLG+gjQ55ClXAjuClQdG6laQvQGpFWcj rFqignGYiKelw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=sAnBlyG8 Subject: Re: [Intel-wired-lan] [RFC PATCH v2] ethtool: add FEC bins histogramm report X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 31 Jul 2025 16:10:19 -0700 Vadim Fedorenko wrote: > - remove sentinel (-1, -1) and use (0, 0) as common array break. > bin (0, 0) is still possible but only as a first element of > ranges array I don't see this change in the diff? It's still -1,-1 Also, not seeing per-lane support here. > diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml > index 1063d5d32fea2..69779b51f1dfd 100644 > --- a/Documentation/netlink/specs/ethtool.yaml > +++ b/Documentation/netlink/specs/ethtool.yaml > @@ -1239,6 +1239,30 @@ attribute-sets: > name: corr-bits > type: binary > sub-type: u64 > + - > + name: hist > + type: nest > + multi-attr: True > + nested-attributes: fec-hist > + - > + name: fec-hist-bin-low > + type: uint > + - > + name: fec-hist-bin-high > + type: uint The bounds can be u32, TBH. The value really is a u16 but we don't want to waste space on padding in Netlink. Still, no need to go all the way to uint. > + name: fec-hist-bin-val > + type: uint From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAFFFDF71 for ; Fri, 1 Aug 2025 20:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754078809; cv=none; b=aeoSXgZcreAz21ZMY1UymzUEvWRU8G2vkdtq0vNHrsKMrPw7BEpBDoLpSw6qhB/XqtuvfqtxflpO/C9lbXY39oBzVHOEbOIZWh4TrAfJwDBBPxzlO6avS/pSG3/UjTmVZQsOxaeYSf1C/1jWP26iMITgH1M4h4aWRBeOdiUWLIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754078809; c=relaxed/simple; bh=T7/74GDSNVPhlAsnSqKd+bYVq/4pK/GDutVg+bbGPyc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=T1KTwqouVJp0xw412KMCmRuzpA4Z2EgnlNgReYUMXl0e9v81HaydVemxDXF1eV11+dDtqMfF327E5THVd305jtLGjUWB6ClMdEJGLCqOjtVAHFijQ7JSOKCA8xGZ90vpdKuZrb2aEVOC/XqnL1hf8EhxLY0sBbJ9GXhh9i0S3k8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sAnBlyG8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sAnBlyG8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2108C4CEE7; Fri, 1 Aug 2025 20:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754078809; bh=T7/74GDSNVPhlAsnSqKd+bYVq/4pK/GDutVg+bbGPyc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sAnBlyG8blUfyGmDkkkwg6RrtOjkJ+MD0g/Rfz6HsmeAglcOkldBzgC6RiS/ybKkl qMphAhXuXCaiJtIKB600PIHTugUeAZ4bRARSQzanOtERuNEeI29idNcWrcs/4/N2P2 UmhFVw7yq656lo7FRV2gIvAkXZTuN29WvRLIDEnEOAndOWu7DGGeVErR9Vovju7u0G KESESRcrHeeUhXSaSgkFB2TrjuaKBxurDLwqO8OkOkepui6hvCNyk7cf9u420ynijl Uigg33eMBnyhz34T7CNJXOFypx9wmY1m0MZLG+gjQ55ClXAjuClQdG6laQvQGpFWcj rFqignGYiKelw== Date: Fri, 1 Aug 2025 13:06:48 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Andrew Lunn , Michael Chan , Pavan Chebbi , Tariq Toukan , Gal Pressman , , Donald Hunter , Carolina Jubran , Paolo Abeni , Simon Horman , , Vadim Fedorenko Subject: Re: [RFC PATCH v2] ethtool: add FEC bins histogramm report Message-ID: <20250801130648.341995ba@kernel.org> In-Reply-To: <20250731231019.1809172-1-vadfed@meta.com> References: <20250731231019.1809172-1-vadfed@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 31 Jul 2025 16:10:19 -0700 Vadim Fedorenko wrote: > - remove sentinel (-1, -1) and use (0, 0) as common array break. > bin (0, 0) is still possible but only as a first element of > ranges array I don't see this change in the diff? It's still -1,-1 Also, not seeing per-lane support here. > diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml > index 1063d5d32fea2..69779b51f1dfd 100644 > --- a/Documentation/netlink/specs/ethtool.yaml > +++ b/Documentation/netlink/specs/ethtool.yaml > @@ -1239,6 +1239,30 @@ attribute-sets: > name: corr-bits > type: binary > sub-type: u64 > + - > + name: hist > + type: nest > + multi-attr: True > + nested-attributes: fec-hist > + - > + name: fec-hist-bin-low > + type: uint > + - > + name: fec-hist-bin-high > + type: uint The bounds can be u32, TBH. The value really is a u16 but we don't want to waste space on padding in Netlink. Still, no need to go all the way to uint. > + name: fec-hist-bin-val > + type: uint