From: kernel test robot <lkp@intel.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [mripard:drm/state-readout 39/51] drivers/gpu/drm/tidss/tidss_dispc.c:2992:1: warning: label 'err_clk_disable' defined but not used
Date: Sat, 2 Aug 2025 03:38:00 +0200 [thread overview]
Message-ID: <202508020338.YXfUAVLi-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git drm/state-readout
head: f8f58ab7e9eac7e5daa40ab3f03b67f54ee9e9a4
commit: a002bb9e724a3a99d4e0d030a90d053a61980592 [39/51] [HACK] drm/tidss: dispc: Skip reset
config: parisc-randconfig-2001-20250801 (https://download.01.org/0day-ci/archive/20250802/202508020338.YXfUAVLi-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250802/202508020338.YXfUAVLi-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508020338.YXfUAVLi-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/bug.h:5,
from include/linux/cpumask.h:15,
from include/linux/smp.h:13,
from include/linux/lockdep.h:14,
from include/linux/mutex.h:17,
from include/linux/notifier.h:14,
from include/linux/clk.h:14,
from drivers/gpu/drm/tidss/tidss_dispc.c:7:
drivers/gpu/drm/tidss/tidss_dispc.c: In function 'CH':
drivers/gpu/drm/tidss/tidss_dispc.c:483:35: error: 'struct dev_pm_info' has no member named 'runtime_status'
483 | WARN_ON((dispc->dev->power.runtime_status != RPM_ACTIVE) &&
| ^
arch/parisc/include/asm/bug.h:86:32: note: in definition of macro 'WARN_ON'
86 | int __ret_warn_on = !!(x); \
| ^
drivers/gpu/drm/tidss/tidss_dispc.c:484:35: error: 'struct dev_pm_info' has no member named 'runtime_status'
484 | (dispc->dev->power.runtime_status != RPM_RESUMING) &&
| ^
arch/parisc/include/asm/bug.h:86:32: note: in definition of macro 'WARN_ON'
86 | int __ret_warn_on = !!(x); \
| ^
drivers/gpu/drm/tidss/tidss_dispc.c:485:35: error: 'struct dev_pm_info' has no member named 'runtime_status'
485 | (dispc->dev->power.runtime_status != RPM_SUSPENDING));
| ^
arch/parisc/include/asm/bug.h:86:32: note: in definition of macro 'WARN_ON'
86 | int __ret_warn_on = !!(x); \
| ^
drivers/gpu/drm/tidss/tidss_dispc.c: In function 'FLD_MOD':
drivers/gpu/drm/tidss/tidss_dispc.c:581:33: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
581 | return (orig & ~mask) | FIELD_PREP(mask, val);
| ^~~~~~~~~~
drivers/gpu/drm/tidss/tidss_dispc.c: In function 'REG_GET':
drivers/gpu/drm/tidss/tidss_dispc.c:586:16: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
586 | return FIELD_GET(mask, dispc_read(dispc, idx));
| ^~~~~~~~~
drivers/gpu/drm/tidss/tidss_dispc.c: In function 'dispc_init_hw':
>> drivers/gpu/drm/tidss/tidss_dispc.c:2992:1: warning: label 'err_clk_disable' defined but not used [-Wunused-label]
2992 | err_clk_disable:
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/tidss/tidss_dispc.c: At top level:
>> drivers/gpu/drm/tidss/tidss_dispc.c:2939:12: warning: 'dispc_softreset' defined but not used [-Wunused-function]
2939 | static int dispc_softreset(struct dispc_device *dispc)
| ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/err_clk_disable +2992 drivers/gpu/drm/tidss/tidss_dispc.c
576d96c5c89622 Tomi Valkeinen 2023-11-09 2938
aceafbb5035c4b Tomi Valkeinen 2023-11-09 @2939 static int dispc_softreset(struct dispc_device *dispc)
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2940 {
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2941 u32 val;
c2746e4d278be8 Tomi Valkeinen 2023-11-09 2942 int ret;
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2943
576d96c5c89622 Tomi Valkeinen 2023-11-09 2944 if (dispc->feat->subrev == DISPC_K2G) {
576d96c5c89622 Tomi Valkeinen 2023-11-09 2945 dispc_softreset_k2g(dispc);
151825150cf9c2 Tomi Valkeinen 2023-11-09 2946 return 0;
576d96c5c89622 Tomi Valkeinen 2023-11-09 2947 }
151825150cf9c2 Tomi Valkeinen 2023-11-09 2948
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2949 /* Soft reset */
8e7aa9647fd416 Maxime Ripard 2025-07-18 2950 REG_FLD_MOD(dispc, DSS_SYSCONFIG, 1, DSS_SYSCONFIG_SOFTRESET_MASK);
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2951 /* Wait for reset to complete */
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2952 ret = readl_poll_timeout(dispc->base_common + DSS_SYSSTATUS,
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2953 val, val & 1, 100, 5000);
aceafbb5035c4b Tomi Valkeinen 2023-11-09 2954 if (ret) {
aceafbb5035c4b Tomi Valkeinen 2023-11-09 2955 dev_err(dispc->dev, "failed to reset dispc\n");
aceafbb5035c4b Tomi Valkeinen 2023-11-09 2956 return ret;
aceafbb5035c4b Tomi Valkeinen 2023-11-09 2957 }
aceafbb5035c4b Tomi Valkeinen 2023-11-09 2958
aceafbb5035c4b Tomi Valkeinen 2023-11-09 2959 return 0;
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2960 }
c9b2d923befd8c Devarsh Thakkar 2022-03-14 2961
bc288a927815ef Tomi Valkeinen 2023-11-09 2962 static int dispc_init_hw(struct dispc_device *dispc)
bc288a927815ef Tomi Valkeinen 2023-11-09 2963 {
bc288a927815ef Tomi Valkeinen 2023-11-09 2964 struct device *dev = dispc->dev;
bc288a927815ef Tomi Valkeinen 2023-11-09 2965 int ret;
bc288a927815ef Tomi Valkeinen 2023-11-09 2966
bc288a927815ef Tomi Valkeinen 2023-11-09 2967 ret = pm_runtime_set_active(dev);
bc288a927815ef Tomi Valkeinen 2023-11-09 2968 if (ret) {
bc288a927815ef Tomi Valkeinen 2023-11-09 2969 dev_err(dev, "Failed to set DSS PM to active\n");
bc288a927815ef Tomi Valkeinen 2023-11-09 2970 return ret;
bc288a927815ef Tomi Valkeinen 2023-11-09 2971 }
bc288a927815ef Tomi Valkeinen 2023-11-09 2972
bc288a927815ef Tomi Valkeinen 2023-11-09 2973 ret = clk_prepare_enable(dispc->fclk);
bc288a927815ef Tomi Valkeinen 2023-11-09 2974 if (ret) {
bc288a927815ef Tomi Valkeinen 2023-11-09 2975 dev_err(dev, "Failed to enable DSS fclk\n");
bc288a927815ef Tomi Valkeinen 2023-11-09 2976 goto err_runtime_suspend;
bc288a927815ef Tomi Valkeinen 2023-11-09 2977 }
bc288a927815ef Tomi Valkeinen 2023-11-09 2978
a002bb9e724a3a Maxime Ripard 2025-07-25 2979 /* ret = dispc_softreset(dispc); */
a002bb9e724a3a Maxime Ripard 2025-07-25 2980 /* if (ret) */
a002bb9e724a3a Maxime Ripard 2025-07-25 2981 /* goto err_clk_disable; */
bc288a927815ef Tomi Valkeinen 2023-11-09 2982
bc288a927815ef Tomi Valkeinen 2023-11-09 2983 clk_disable_unprepare(dispc->fclk);
bc288a927815ef Tomi Valkeinen 2023-11-09 2984 ret = pm_runtime_set_suspended(dev);
bc288a927815ef Tomi Valkeinen 2023-11-09 2985 if (ret) {
bc288a927815ef Tomi Valkeinen 2023-11-09 2986 dev_err(dev, "Failed to set DSS PM to suspended\n");
bc288a927815ef Tomi Valkeinen 2023-11-09 2987 return ret;
bc288a927815ef Tomi Valkeinen 2023-11-09 2988 }
bc288a927815ef Tomi Valkeinen 2023-11-09 2989
bc288a927815ef Tomi Valkeinen 2023-11-09 2990 return 0;
bc288a927815ef Tomi Valkeinen 2023-11-09 2991
bc288a927815ef Tomi Valkeinen 2023-11-09 @2992 err_clk_disable:
bc288a927815ef Tomi Valkeinen 2023-11-09 2993 clk_disable_unprepare(dispc->fclk);
bc288a927815ef Tomi Valkeinen 2023-11-09 2994
bc288a927815ef Tomi Valkeinen 2023-11-09 2995 err_runtime_suspend:
bc288a927815ef Tomi Valkeinen 2023-11-09 2996 ret = pm_runtime_set_suspended(dev);
bc288a927815ef Tomi Valkeinen 2023-11-09 2997 if (ret) {
bc288a927815ef Tomi Valkeinen 2023-11-09 2998 dev_err(dev, "Failed to set DSS PM to suspended\n");
bc288a927815ef Tomi Valkeinen 2023-11-09 2999 return ret;
bc288a927815ef Tomi Valkeinen 2023-11-09 3000 }
bc288a927815ef Tomi Valkeinen 2023-11-09 3001
bc288a927815ef Tomi Valkeinen 2023-11-09 3002 return ret;
bc288a927815ef Tomi Valkeinen 2023-11-09 3003 }
bc288a927815ef Tomi Valkeinen 2023-11-09 3004
:::::: The code at line 2992 was first introduced by commit
:::::: bc288a927815efcf9d7f4a54d4d89c5df478c635 drm/tidss: Fix dss reset
:::::: TO: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
:::::: CC: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-08-02 1:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-02 1:38 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-08-02 2:05 [mripard:drm/state-readout 39/51] drivers/gpu/drm/tidss/tidss_dispc.c:2992:1: warning: label 'err_clk_disable' defined but not used kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508020338.YXfUAVLi-lkp@intel.com \
--to=lkp@intel.com \
--cc=mripard@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.