From: Kees Cook <kees@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
linux-kbuild@vger.kernel.org,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] kbuild: Re-enable -Wunterminated-string-initialization
Date: Sat, 2 Aug 2025 10:08:04 -0700 [thread overview]
Message-ID: <202508021005.B4BACEB735@keescook> (raw)
In-Reply-To: <20250802011344.GA1736762@ax162>
On Fri, Aug 01, 2025 at 06:13:44PM -0700, Nathan Chancellor wrote:
> On Fri, Aug 01, 2025 at 05:55:27PM -0700, Kees Cook wrote:
> > On Fri, Aug 01, 2025 at 05:43:16PM -0700, Nathan Chancellor wrote:
> > > On Fri, Aug 01, 2025 at 05:27:40PM -0700, Kees Cook wrote:
> > > > With the few remaining fixes now landed, we can re-enable the option
> > > > -Wunterminated-string-initialization for GCC. (Clang does not yet fully
> > > > understand the "nonstring" attribute.)
> > > >
> > > > Signed-off-by: Kees Cook <kees@kernel.org>
> > >
> > > What else does Clang need? Are bugs filed? I had requested support for
> > > multidimensional arrays, which Aaron implemented pretty quickly (and the
> > > tests seem pretty expansive):
> > >
> > > https://github.com/llvm/llvm-project/commit/e8ae77947154e10dbc05cbb95ec9e10d3b0be13e
> >
> > Oh! I missed that commit. Did that end up in Clang 21? Let me try some
> > test builds with a more recent Clang...
>
> Whoops, linked the wrong change (although that one is still good):
>
> https://github.com/llvm/llvm-project/commit/3d4f979e271d2a1fe0906f4d1b16db108838f98f
>
> But yes, both those changes are in 21.1.0-rc1. I uploaded -rc2 to
> kernel.org a couple of days ago: https://kernel.org/pub/tools/llvm/
Ah yeah! Let me get this retested with the 21.1 release. I think we
don't need any special handling.
--
Kees Cook
prev parent reply other threads:[~2025-08-02 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-02 0:27 [PATCH] kbuild: Re-enable -Wunterminated-string-initialization Kees Cook
2025-08-02 0:43 ` Nathan Chancellor
2025-08-02 0:55 ` Kees Cook
2025-08-02 1:13 ` Nathan Chancellor
2025-08-02 17:08 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508021005.B4BACEB735@keescook \
--to=kees@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.