Re: [PATCH v4 0/2] mm/damon/vaddr: support stat-purpose DAMOS filters

[SeongJae Park <sj@kernel.org>]

On Sat,  2 Aug 2025 11:52:44 +0000 Yueyang Pan <pyyjason@gmail.com> wrote:

> Extend DAMOS_STAT handling of the DAMON operations sets for virtual
> address spaces for ops-level DAMOS filters.
> 
> Functionality Test
> ==================
> I wrote a small test program which allocates 10GB of DRAM, use 
> madvise(MADV_HUGEPAGE) to convert the base pages to 2MB huge pages
> Then my program does the following things in order:
> 1. Write sequentially to the whole 10GB region
> 2. Read the first 5GB region sequentially for 10 times
> 3. Sleep 5s
> 4. Read the second 5GB region sequentially for 10 times
> 
> With a proper damon setting, we are expected to see df-passed to be 10GB
> and hot region move around with the read
> 
> $ # Start DAMON
> $ sudo ./damo/damo start "./my_test/test" --monitoring_intervals 100ms\
> 1s 2s

On v2, I also suggested adding indentation here, same to the outputs of the
commands.  But, this is too trivial, so I wouldn't request a new version.

[...]
> Revision History
> ================
> Changes from v3 [3]:
> - Fix some naming issues and improper text in cover letter raise by SJ.

All looks good to me, I gave my Reviewed-by: tags to all patches.  Thank you
for doing this great work, Pan!


Thanks,
SJ

[...]