From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39B9CE571 for ; Sat, 2 Aug 2025 09:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754126213; cv=none; b=ONxuuWyGRjGdGlaX67vJ9cbXQnpHmBnMwBw8G7xAwTK4fzOAW4euURd311Rfar3WI7wjy0zfAKUM0c/Ia5VyDBilt1IrynRAQUMOc6GMwRAzsU6kOYlZWIXSF9D2An/tbS4jZgT/FTYnNdmSAy855yeOZJblquJ2L3IOUhE3iNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754126213; c=relaxed/simple; bh=YtROcjI1AaiqlbKnVPx3FtSG29QLgyMn5k2xD1MySnQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=H6sKptlshp+dhWxrbndHc9FmO6e7kz4TpFWxXjao56QlRcyt38063lvAR/HSknuULSj4c4L9G4mfNm5CqR92C6wjVCHQnV4EXXmFZg5cumVgn22ipRKR1vxqWGDGBLC/HK/UvTfO8LUj0j8owgG9rtXmWyvxiC56VwGw49AxQuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=K7AXj7zd; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="K7AXj7zd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754126211; x=1785662211; h=date:from:to:cc:subject:message-id:mime-version; bh=YtROcjI1AaiqlbKnVPx3FtSG29QLgyMn5k2xD1MySnQ=; b=K7AXj7zdoZncWm57bYn0Wxuia24/pHR7+QTa7rZpSKMeDpESc+6R2Wka pKRXW+15d2FoI38u/INxvAWARwnY9WjH8kzPpFmGokm7J5ZnQ8D4SQoZs Opxj9zmtFZJDq0y8IGK4WzAAkkwZuPYgy3lY54Tor1+gUee+hPVpgEAST mMHp4815MaAIfJYd06gfF0elQ6eYPD5dhaJLfdN/605/I2DKL1raNH5k7 N2bmr7Op5QRoWe80cWVoOfGA3SATwMq/3GL3gHJ/9SN3Y7mvPByEIXNn2 9yVCV8g5lIoeSFZPX8ygcSn4l1LT0/WPsrtrZBuWRdjFYqO41ruR8Z7f/ A==; X-CSE-ConnectionGUID: 7V88sjIvSIm/VuQAA9evCA== X-CSE-MsgGUID: ptveEJ4RQyqop76EjBVZ4A== X-IronPort-AV: E=McAfee;i="6800,10657,11508"; a="79012411" X-IronPort-AV: E=Sophos;i="6.17,258,1747724400"; d="scan'208";a="79012411" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2025 02:16:50 -0700 X-CSE-ConnectionGUID: DpboV0RTT82DTa+bPKwaFA== X-CSE-MsgGUID: XZt/l9hwT8Wo/GG5C+C5pA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,258,1747724400"; d="scan'208";a="167944093" Received: from lkp-server01.sh.intel.com (HELO 160750d4a34c) ([10.239.97.150]) by fmviesa003.fm.intel.com with ESMTP; 02 Aug 2025 02:16:49 -0700 Received: from kbuild by 160750d4a34c with local (Exim 4.96) (envelope-from ) id 1ui8MB-0005HU-08; Sat, 02 Aug 2025 09:16:47 +0000 Date: Sat, 2 Aug 2025 17:15:57 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c:126 isp_genpd_add_device() warn: can 'pdev' even be NULL? Message-ID: <202508021712.RXyDnVIn-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Pratap Nirujogi CC: Alex Deucher CC: Bin Du CC: Mario Limonciello tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a6923c06a3b2e2c534ae28c53a7531e76cc95cfa commit: fd14786071021bb63b0ab32b95257a594e46f8d4 drm/amd/amdgpu: Add ISP Generic PM Domain (genpd) support date: 6 weeks ago :::::: branch date: 9 hours ago :::::: commit date: 6 weeks ago config: x86_64-randconfig-161-20250802 (https://download.01.org/0day-ci/archive/20250802/202508021712.RXyDnVIn-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508021712.RXyDnVIn-lkp@intel.com/ smatch warnings: drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c:126 isp_genpd_add_device() warn: can 'pdev' even be NULL? drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c:159 isp_genpd_remove_device() warn: can 'pdev' even be NULL? vim +/pdev +126 drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c fd14786071021b Pratap Nirujogi 2025-05-29 117 fd14786071021b Pratap Nirujogi 2025-05-29 118 static int isp_genpd_add_device(struct device *dev, void *data) fd14786071021b Pratap Nirujogi 2025-05-29 119 { fd14786071021b Pratap Nirujogi 2025-05-29 120 struct generic_pm_domain *gpd = data; fd14786071021b Pratap Nirujogi 2025-05-29 121 struct platform_device *pdev = container_of(dev, struct platform_device, dev); fd14786071021b Pratap Nirujogi 2025-05-29 122 struct amdgpu_isp *isp = container_of(gpd, struct amdgpu_isp, ispgpd); fd14786071021b Pratap Nirujogi 2025-05-29 123 struct amdgpu_device *adev = isp->adev; fd14786071021b Pratap Nirujogi 2025-05-29 124 int ret; fd14786071021b Pratap Nirujogi 2025-05-29 125 fd14786071021b Pratap Nirujogi 2025-05-29 @126 if (!pdev) fd14786071021b Pratap Nirujogi 2025-05-29 127 return -EINVAL; fd14786071021b Pratap Nirujogi 2025-05-29 128 fd14786071021b Pratap Nirujogi 2025-05-29 129 if (!dev->type->name) { fd14786071021b Pratap Nirujogi 2025-05-29 130 drm_dbg(&adev->ddev, "Invalid device type to add\n"); fd14786071021b Pratap Nirujogi 2025-05-29 131 goto exit; fd14786071021b Pratap Nirujogi 2025-05-29 132 } fd14786071021b Pratap Nirujogi 2025-05-29 133 fd14786071021b Pratap Nirujogi 2025-05-29 134 if (strcmp(dev->type->name, "mfd_device")) { fd14786071021b Pratap Nirujogi 2025-05-29 135 drm_dbg(&adev->ddev, "Invalid isp mfd device %s to add\n", pdev->mfd_cell->name); fd14786071021b Pratap Nirujogi 2025-05-29 136 goto exit; fd14786071021b Pratap Nirujogi 2025-05-29 137 } fd14786071021b Pratap Nirujogi 2025-05-29 138 fd14786071021b Pratap Nirujogi 2025-05-29 139 ret = pm_genpd_add_device(gpd, dev); fd14786071021b Pratap Nirujogi 2025-05-29 140 if (ret) { fd14786071021b Pratap Nirujogi 2025-05-29 141 drm_err(&adev->ddev, "Failed to add dev %s to genpd %d\n", fd14786071021b Pratap Nirujogi 2025-05-29 142 pdev->mfd_cell->name, ret); fd14786071021b Pratap Nirujogi 2025-05-29 143 return -ENODEV; fd14786071021b Pratap Nirujogi 2025-05-29 144 } fd14786071021b Pratap Nirujogi 2025-05-29 145 fd14786071021b Pratap Nirujogi 2025-05-29 146 exit: fd14786071021b Pratap Nirujogi 2025-05-29 147 /* Continue to add */ fd14786071021b Pratap Nirujogi 2025-05-29 148 return 0; fd14786071021b Pratap Nirujogi 2025-05-29 149 } fd14786071021b Pratap Nirujogi 2025-05-29 150 fd14786071021b Pratap Nirujogi 2025-05-29 151 static int isp_genpd_remove_device(struct device *dev, void *data) fd14786071021b Pratap Nirujogi 2025-05-29 152 { fd14786071021b Pratap Nirujogi 2025-05-29 153 struct generic_pm_domain *gpd = data; fd14786071021b Pratap Nirujogi 2025-05-29 154 struct platform_device *pdev = container_of(dev, struct platform_device, dev); fd14786071021b Pratap Nirujogi 2025-05-29 155 struct amdgpu_isp *isp = container_of(gpd, struct amdgpu_isp, ispgpd); fd14786071021b Pratap Nirujogi 2025-05-29 156 struct amdgpu_device *adev = isp->adev; fd14786071021b Pratap Nirujogi 2025-05-29 157 int ret; fd14786071021b Pratap Nirujogi 2025-05-29 158 fd14786071021b Pratap Nirujogi 2025-05-29 @159 if (!pdev) fd14786071021b Pratap Nirujogi 2025-05-29 160 return -EINVAL; fd14786071021b Pratap Nirujogi 2025-05-29 161 fd14786071021b Pratap Nirujogi 2025-05-29 162 if (!dev->type->name) { fd14786071021b Pratap Nirujogi 2025-05-29 163 drm_dbg(&adev->ddev, "Invalid device type to remove\n"); fd14786071021b Pratap Nirujogi 2025-05-29 164 goto exit; fd14786071021b Pratap Nirujogi 2025-05-29 165 } fd14786071021b Pratap Nirujogi 2025-05-29 166 fd14786071021b Pratap Nirujogi 2025-05-29 167 if (strcmp(dev->type->name, "mfd_device")) { fd14786071021b Pratap Nirujogi 2025-05-29 168 drm_dbg(&adev->ddev, "Invalid isp mfd device %s to remove\n", fd14786071021b Pratap Nirujogi 2025-05-29 169 pdev->mfd_cell->name); fd14786071021b Pratap Nirujogi 2025-05-29 170 goto exit; fd14786071021b Pratap Nirujogi 2025-05-29 171 } fd14786071021b Pratap Nirujogi 2025-05-29 172 fd14786071021b Pratap Nirujogi 2025-05-29 173 ret = pm_genpd_remove_device(dev); fd14786071021b Pratap Nirujogi 2025-05-29 174 if (ret) { fd14786071021b Pratap Nirujogi 2025-05-29 175 drm_err(&adev->ddev, "Failed to remove dev from genpd %d\n", ret); fd14786071021b Pratap Nirujogi 2025-05-29 176 return -ENODEV; fd14786071021b Pratap Nirujogi 2025-05-29 177 } fd14786071021b Pratap Nirujogi 2025-05-29 178 fd14786071021b Pratap Nirujogi 2025-05-29 179 exit: fd14786071021b Pratap Nirujogi 2025-05-29 180 /* Continue to remove */ fd14786071021b Pratap Nirujogi 2025-05-29 181 return 0; fd14786071021b Pratap Nirujogi 2025-05-29 182 } fd14786071021b Pratap Nirujogi 2025-05-29 183 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki