All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
	damon@lists.linux.dev, Bijan Tabatabai <bijantabatab@micron.com>
Subject: Re: [PATCH] mm/damon/vaddr: avoid unnecessary migration between target nodes
Date: Sun,  3 Aug 2025 11:01:07 -0700	[thread overview]
Message-ID: <20250803180107.56197-1-sj@kernel.org> (raw)
In-Reply-To: <20250803130028.162537-1-akinobu.mita@gmail.com>

Hello Akinobu,

On Sun,  3 Aug 2025 22:00:28 +0900 Akinobu Mita <akinobu.mita@gmail.com> wrote:

> This change avoids unnecessary migration by checking if the folio to which
> the migration is applied is already located in one of the target nodes.

Each folio will get a single target node among the target nodes, based on the
weights of targets and the virtual address of the folio.  So skipping the
migration because the folio is on one of target nodes can result in wrong
behavior (not doing required migrations)?

Also, a similar purpose optimization was already made by Bijan.  I guess you
aware of that and therefore Cc-ed Bijan.  Could you further share differences
between this and Bijan's one, and measured additional performance gain from
this patch, if you have?

[1] https://lkml.kernel.org/r/20250725163300.4602-1-bijan311@gmail.com


Thanks,
SJ

[...]

  reply	other threads:[~2025-08-03 18:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-03 13:00 [PATCH] mm/damon/vaddr: avoid unnecessary migration between target nodes Akinobu Mita
2025-08-03 18:01 ` SeongJae Park [this message]
2025-08-04 12:46   ` Akinobu Mita
2025-08-04 15:19     ` Bijan Tabatabai
2025-08-04 16:43       ` SeongJae Park
2025-08-05 16:04         ` Akinobu Mita
2025-08-05 17:51           ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250803180107.56197-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akinobu.mita@gmail.com \
    --cc=bijantabatab@micron.com \
    --cc=damon@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.