From: kernel test robot <lkp@intel.com>
To: Asahi Lina <lina@asahilina.net>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Janne Grunau <j@jannau.net>
Subject: [asahilinux:bits/240-isp 25/53] drivers/media/platform/apple/isp/isp-ipc.c:226:10: warning: variable 'dwork' is uninitialized when used here
Date: Mon, 4 Aug 2025 18:41:45 +0800 [thread overview]
Message-ID: <202508041818.AkRny7yB-lkp@intel.com> (raw)
tree: https://github.com/AsahiLinux/linux bits/240-isp
head: a6b9c182c34b8219390dc76a566a1f275e7245c3
commit: 6dc724a0e741df8d453d27c8f78c5d4871eb7d9c [25/53] media: apple: isp: Remove ioread/iowrite and stop doing raw address translation
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250804/202508041818.AkRny7yB-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 8f09b03aebb71c154f3bbe725c29e3f47d37c26e)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250804/202508041818.AkRny7yB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508041818.AkRny7yB-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/media/platform/apple/isp/isp-ipc.c:238:5: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
237 | isp_err(isp, "failed to vmap iova=0x%llx size=0x%llx\n",
| ~~~~
| %x
238 | surf->iova, surf->size);
| ^~~~~~~~~~
drivers/media/platform/apple/isp/isp-drv.h:267:47: note: expanded from macro 'isp_err'
267 | dev_err((isp)->dev, "[%s] " fmt, __func__, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ~~~ ^~~~~~~~~~~
>> drivers/media/platform/apple/isp/isp-ipc.c:226:10: warning: variable 'dwork' is uninitialized when used here [-Wuninitialized]
226 | kfree(dwork);
| ^~~~~
drivers/media/platform/apple/isp/isp-ipc.c:219:37: note: initialize the variable 'dwork' to silence this warning
219 | struct isp_sm_deferred_work *dwork;
| ^
| = NULL
2 warnings generated.
vim +/dwork +226 drivers/media/platform/apple/isp/isp-ipc.c
a1dceff4188d136 Eileen Yoon 2023-08-31 212
a1dceff4188d136 Eileen Yoon 2023-08-31 213 int ipc_sm_handle(struct apple_isp *isp, struct isp_channel *chan)
a1dceff4188d136 Eileen Yoon 2023-08-31 214 {
a1dceff4188d136 Eileen Yoon 2023-08-31 215 struct isp_message *req = &chan->req, *rsp = &chan->rsp;
6dc724a0e741df8 Asahi Lina 2023-09-29 216 int err;
a1dceff4188d136 Eileen Yoon 2023-08-31 217
a1dceff4188d136 Eileen Yoon 2023-08-31 218 if (req->arg0 == 0x0) {
a1dceff4188d136 Eileen Yoon 2023-08-31 219 struct isp_sm_deferred_work *dwork;
a1dceff4188d136 Eileen Yoon 2023-08-31 220 struct isp_surf *surf;
a1dceff4188d136 Eileen Yoon 2023-08-31 221
a1dceff4188d136 Eileen Yoon 2023-08-31 222 surf = isp_alloc_surface_gc(isp, req->arg1);
a1dceff4188d136 Eileen Yoon 2023-08-31 223 if (!surf) {
a1dceff4188d136 Eileen Yoon 2023-08-31 224 isp_err(isp, "failed to alloc requested size 0x%llx\n",
a1dceff4188d136 Eileen Yoon 2023-08-31 225 req->arg1);
a1dceff4188d136 Eileen Yoon 2023-08-31 @226 kfree(dwork);
a1dceff4188d136 Eileen Yoon 2023-08-31 227 return -ENOMEM;
a1dceff4188d136 Eileen Yoon 2023-08-31 228 }
6dc724a0e741df8 Asahi Lina 2023-09-29 229 surf->type = req->arg2;
a1dceff4188d136 Eileen Yoon 2023-08-31 230
a1dceff4188d136 Eileen Yoon 2023-08-31 231 rsp->arg0 = surf->iova | ISP_IPC_FLAG_ACK;
a1dceff4188d136 Eileen Yoon 2023-08-31 232 rsp->arg1 = 0x0;
a1dceff4188d136 Eileen Yoon 2023-08-31 233 rsp->arg2 = 0x0; /* macOS uses this to index surfaces */
a1dceff4188d136 Eileen Yoon 2023-08-31 234
6dc724a0e741df8 Asahi Lina 2023-09-29 235 err = isp_surf_vmap(isp, surf);
6dc724a0e741df8 Asahi Lina 2023-09-29 236 if (err < 0) {
6dc724a0e741df8 Asahi Lina 2023-09-29 237 isp_err(isp, "failed to vmap iova=0x%llx size=0x%llx\n",
6dc724a0e741df8 Asahi Lina 2023-09-29 238 surf->iova, surf->size);
6dc724a0e741df8 Asahi Lina 2023-09-29 239 } else {
6dc724a0e741df8 Asahi Lina 2023-09-29 240 switch (surf->type) {
6dc724a0e741df8 Asahi Lina 2023-09-29 241 case 0x4c4f47: /* "LOG" */
6dc724a0e741df8 Asahi Lina 2023-09-29 242 isp->log_surf = surf;
6dc724a0e741df8 Asahi Lina 2023-09-29 243 break;
6dc724a0e741df8 Asahi Lina 2023-09-29 244 case 0x4d495343: /* "MISC" */
6dc724a0e741df8 Asahi Lina 2023-09-29 245 /* Hacky... maybe there's a better way to identify this surface? */
6dc724a0e741df8 Asahi Lina 2023-09-29 246 if (surf->size == 0xc000)
6dc724a0e741df8 Asahi Lina 2023-09-29 247 isp->bt_surf = surf;
6dc724a0e741df8 Asahi Lina 2023-09-29 248 break;
6dc724a0e741df8 Asahi Lina 2023-09-29 249 }
a1dceff4188d136 Eileen Yoon 2023-08-31 250 }
6dc724a0e741df8 Asahi Lina 2023-09-29 251
:::::: The code at line 226 was first introduced by commit
:::::: a1dceff4188d13636358dd59856716a88c1349e7 media: apple: Add Apple ISP driver
:::::: TO: Eileen Yoon <eyn@gmx.com>
:::::: CC: Janne Grunau <j@jannau.net>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-08-04 10:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508041818.AkRny7yB-lkp@intel.com \
--to=lkp@intel.com \
--cc=j@jannau.net \
--cc=lina@asahilina.net \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.