Re: [GIT PULL] LEDs for v6.17

[Lee Jones <lee@kernel.org>]

On Thu, 31 Jul 2025, Linus Torvalds wrote:

> Just a small and unimportant nit:
> 
> On Wed, 30 Jul 2025 at 08:10, Lee Jones <lee@kernel.org> wrote:
> >
> >  * A potential buffer overflow warning in PCA955x was reported by older GCC
> >   versions has been fixed by using a more precise format specifier when
> >   creating the default LED label.
> 
> I'm trying to encourage people to use more straightforward language in
> commit messages, and I ended up rewriting some of yours.
> 
> In particular, try to avoid passive voice.
> 
> So instead of "A fix has been implemented to Xyz" just say that it
> contains "A fix for Xyz" (or even just "Fix Xyz").
> 
> Straight and to the point.
> 
> As an example, I edited that "was reported by gcc" and "has been
> fixed", so that bullet point became
> 
>        - Fix a potential buffer overflow warning in PCA955x reported by
>          older GCC versions by using a more precise format specifier when
>          creating the default LED label.
> 
> in my tree.
> 
> This is not a huge deal, I just wanted to point out that "simple and
> to the point" is a good thing, and talking about fixes in some kind of
> passive voice is just strange.

Thanks for fixing.

I'll try to bear it in mind in the future.

-- 
Lee Jones [李琼斯]