From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5C802E36F0; Tue, 5 Aug 2025 22:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754433966; cv=none; b=clZ0n77B5gmiWRNUYYo4UcB0y8yA0XG0MsSCebSOK1RHCLCPqKoVnfLJXtxSs4KIvF77bvUDNFZXlNPZTK7t+jIf5VXbpnjFT86vI27q6MemDdzXUWF3q0g6T+pw425fZ2q02K4AOsncWoG/AyQ8/niT0s/TuPDLfD7ExLYyHNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754433966; c=relaxed/simple; bh=NqAn7xkr0Rfx37RWYqFvxyrYUe9MsAbnMN8SOZ0XZ8A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gvtko5+WrWzti0BGVQu3wa4iAiacnckZKay7wtbjVzm9pk/mfvGH54egdtoweGAuXqfJ6Oatczm210JKd9V8Upum527H+LTCsY62UGU3BS16p8RPVABWbxfr0yDxG3bcxb13zpFM0MXGJaS65OkvP0G7POU/6uWMBm/imJW5oLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f3ciXNWT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f3ciXNWT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4400C4CEF0; Tue, 5 Aug 2025 22:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754433966; bh=NqAn7xkr0Rfx37RWYqFvxyrYUe9MsAbnMN8SOZ0XZ8A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f3ciXNWTApQibSjgZTVBIQ1cfxquSZMI/00XCX77N9oGij/RpxiPKAUV4q3Brivk3 VahaglYpe02/YuF/x1S9+U9CKzsJKDnd0e099GnXRys/MKRtq5QwNcGJrQ+OGkqS3Q nwSxEwzT4mkMC9oahFyy8cmWtOY+QeZQtuaOohxHzwLjMFMHMbMR4fNKthJ+UAyC8F 70uPWfb/uaah7OOzIMUSOP8Fgyzzb0QM06zlJppwgB7IZco4rh5pX/lsJxWCVO32F0 5TvqJ+3oajZpY1dPkAJNfduWnl4Z/Qp0S9S2WYuZPzoQE5IcujFxxhf1FBoGN+syrX 4N/DDJOwAvRbQ== Date: Tue, 5 Aug 2025 15:46:04 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: , Michal Kubiak , Maciej Fijalkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Paolo Abeni" , Alexei Starovoitov , "Daniel Borkmann" , Simon Horman , , , , Subject: Re: [PATCH iwl-next v3 16/18] idpf: add support for XDP on Rx Message-ID: <20250805154604.680bde07@kernel.org> In-Reply-To: References: <20250730160717.28976-1-aleksander.lobakin@intel.com> <20250730160717.28976-17-aleksander.lobakin@intel.com> <20250801153343.74e0884b@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 5 Aug 2025 18:09:40 +0200 Alexander Lobakin wrote: > From: Jakub Kicinski > Date: Fri, 1 Aug 2025 15:33:43 -0700 > > > On Wed, 30 Jul 2025 18:07:15 +0200 Alexander Lobakin wrote: > >> Use __LIBETH_WORD_ACCESS to parse descriptors more efficiently when > >> applicable. It really gives some good boosts and code size reduction > >> on x86_64. > > > > Could you perhaps quantify the goodness of the boost with a number? :) > > Sure, only a matter of switching this definition and running the tests > (and bloat-o-meter). > Intel doesn't allow us to publish raw numbers (Gbps/Mpps), I hope the > diff in percents (+ bloat-o-meter output) would be enough? Yes, delta is perfect. Absolute numbers aren't very meaningful if you don't specify all HW components and FW versions, and direction of wind on the day, anyway :$ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0079C87FCB for ; Tue, 5 Aug 2025 22:46:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 664E961B33; Tue, 5 Aug 2025 22:46:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OT8-8-abyw7n; Tue, 5 Aug 2025 22:46:13 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D6ADD61B3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1754433972; bh=qhmMrEv9f0NogqRKfRBgOkWV/8gqDCrqStAzYt/W6wg=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=t+8nYAS6rieDvPJ/0tYuGPfZ27mJmEn1uS4axSFk+TLARaz0Lxq4EvrcMcoz7/Xv9 SfNnUSWBcs2hycPCcNGhglITgezfOGV4C0QAxlTT5aaDd4IWhBqG4a0Zj6vsB+LOU9 MUB146lHUzrmhQnhxcrIYvp/0stl8hZLCw0QeU5zFfn672/lakl64uoRZSPSUIkPvC Sni+5D+k6F8ePVQQJG2GAfR+ogjE49NZmuid+DTBUChDjk/A1pbTcwNXZaS4Jtctca z+Srm5XGZhDe6aUkjy5VlIoSuGCHNuO+3bjX1+o0cebcZLciksvdWVZNc9SNcFvftx c4CLGR9WiKhug== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id D6ADD61B3A; Tue, 5 Aug 2025 22:46:12 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id F0928D79 for ; Tue, 5 Aug 2025 22:46:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E203E61B21 for ; Tue, 5 Aug 2025 22:46:10 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id LtoBoXTuhm6u for ; Tue, 5 Aug 2025 22:46:08 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 139EB61B2E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 139EB61B2E Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp3.osuosl.org (Postfix) with ESMTPS id 139EB61B2E for ; Tue, 5 Aug 2025 22:46:07 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8F490601D1; Tue, 5 Aug 2025 22:46:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4400C4CEF0; Tue, 5 Aug 2025 22:46:05 +0000 (UTC) Date: Tue, 5 Aug 2025 15:46:04 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: , Michal Kubiak , Maciej Fijalkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Paolo Abeni" , Alexei Starovoitov , "Daniel Borkmann" , Simon Horman , , , , Message-ID: <20250805154604.680bde07@kernel.org> In-Reply-To: References: <20250730160717.28976-1-aleksander.lobakin@intel.com> <20250730160717.28976-17-aleksander.lobakin@intel.com> <20250801153343.74e0884b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754433966; bh=NqAn7xkr0Rfx37RWYqFvxyrYUe9MsAbnMN8SOZ0XZ8A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f3ciXNWTApQibSjgZTVBIQ1cfxquSZMI/00XCX77N9oGij/RpxiPKAUV4q3Brivk3 VahaglYpe02/YuF/x1S9+U9CKzsJKDnd0e099GnXRys/MKRtq5QwNcGJrQ+OGkqS3Q nwSxEwzT4mkMC9oahFyy8cmWtOY+QeZQtuaOohxHzwLjMFMHMbMR4fNKthJ+UAyC8F 70uPWfb/uaah7OOzIMUSOP8Fgyzzb0QM06zlJppwgB7IZco4rh5pX/lsJxWCVO32F0 5TvqJ+3oajZpY1dPkAJNfduWnl4Z/Qp0S9S2WYuZPzoQE5IcujFxxhf1FBoGN+syrX 4N/DDJOwAvRbQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=f3ciXNWT Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 16/18] idpf: add support for XDP on Rx X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 5 Aug 2025 18:09:40 +0200 Alexander Lobakin wrote: > From: Jakub Kicinski > Date: Fri, 1 Aug 2025 15:33:43 -0700 > > > On Wed, 30 Jul 2025 18:07:15 +0200 Alexander Lobakin wrote: > >> Use __LIBETH_WORD_ACCESS to parse descriptors more efficiently when > >> applicable. It really gives some good boosts and code size reduction > >> on x86_64. > > > > Could you perhaps quantify the goodness of the boost with a number? :) > > Sure, only a matter of switching this definition and running the tests > (and bloat-o-meter). > Intel doesn't allow us to publish raw numbers (Gbps/Mpps), I hope the > diff in percents (+ bloat-o-meter output) would be enough? Yes, delta is perfect. Absolute numbers aren't very meaningful if you don't specify all HW components and FW versions, and direction of wind on the day, anyway :$