From: Al Viro <viro@zeniv.linux.org.uk>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
David Howells <dhowells@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] fscontext: do not consume log entries when returning -EMSGSIZE
Date: Thu, 7 Aug 2025 04:08:17 +0100 [thread overview]
Message-ID: <20250807030817.GH222315@ZenIV> (raw)
In-Reply-To: <2025-08-07.1754534735-core-snowplow-plaid-exiles-anemic-gulls-v9Da77@cyphar.com>
On Thu, Aug 07, 2025 at 12:46:17PM +1000, Aleksa Sarai wrote:
> It felt odd to use "return ret;" at the start and switch to "return n;"
> at the end, but feel free to change it when applying.
s/ret/err/ would take care of that, as well as clarifying the intent -
not that "mutex_lock_interruptible() returns 0 or error" hadn't been
the basic common knowledge...
Anyway, that's really nitpicking at this point.
next prev parent reply other threads:[~2025-08-07 3:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 17:55 [PATCH v3 0/2] fscontext: do not consume log entries when returning -EMSGSIZE Aleksa Sarai
2025-08-06 17:55 ` [PATCH v3 1/2] " Aleksa Sarai
2025-08-06 19:07 ` Al Viro
2025-08-07 2:46 ` Aleksa Sarai
2025-08-07 3:08 ` Al Viro [this message]
2025-08-08 13:52 ` Christian Brauner
2025-08-06 17:55 ` [PATCH v3 2/2] selftests/filesystems: add basic fscontext log tests Aleksa Sarai
2025-08-08 14:06 ` [PATCH v3 0/2] fscontext: do not consume log entries when returning -EMSGSIZE Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807030817.GH222315@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.