From: Nam Cao <namcao@linutronix.de>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Lukas Wunner <lukas@wunner.de>,
Bjorn Helgaas <helgaas@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux PCI Mailing List <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Krzysztof Wilczynski <kwilczynski@kernel.org>,
Armando Budianto <sprite@gnuweeb.org>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
gwml@vger.gnuweeb.org
Subject: Re: [GIT PULL v2] PCI changes for v6.17
Date: Thu, 7 Aug 2025 07:03:50 +0200 [thread overview]
Message-ID: <20250807050350.FyWHwsig@linutronix.de> (raw)
In-Reply-To: <aJQxdBxcx6pdz8VO@linux.gnuweeb.org>
On Thu, Aug 07, 2025 at 11:54:12AM +0700, Ammar Faizi wrote:
> On Thu, Aug 07, 2025 at 05:51:57AM +0200, Lukas Wunner wrote:
> > Kenneth reports early-stage reboots caused by d7d8ab87e3e
> > ("PCI: vmd: Switch to msi_create_parent_irq_domain()"):
> >
> > https://lore.kernel.org/all/dfa40e48-8840-4e61-9fda-25cdb3ad81c1@panix.com/
> >
> > Perhaps you're witnessing the same issue?
>
> Confirmed, reverting that commit works on my machine. I'll try to
> further diagnose it and report more details.
Does the diff below help?
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 9bbb0ff4cc15..b679c7f28f51 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -280,10 +280,12 @@ static int vmd_msi_alloc(struct irq_domain *domain, unsigned int virq,
static void vmd_msi_free(struct irq_domain *domain, unsigned int virq,
unsigned int nr_irqs)
{
+ struct irq_data *irq_data;
struct vmd_irq *vmdirq;
for (int i = 0; i < nr_irqs; ++i) {
- vmdirq = irq_get_chip_data(virq + i);
+ irq_data = irq_domain_get_irq_data(domain, virq + i);
+ vmdirq = irq_data->chip_data;
synchronize_srcu(&vmdirq->irq->srcu);
next prev parent reply other threads:[~2025-08-07 5:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 14:22 [GIT PULL v2] PCI changes for v6.17 Bjorn Helgaas
2025-08-01 21:37 ` pr-tracker-bot
2025-08-07 3:34 ` Ammar Faizi
2025-08-07 3:51 ` Lukas Wunner
2025-08-07 4:44 ` Nam Cao
2025-08-07 4:54 ` Ammar Faizi
2025-08-07 5:03 ` Nam Cao [this message]
2025-08-07 5:13 ` Ammar Faizi
2025-08-08 10:59 ` Ammar Faizi
2025-08-08 11:19 ` Ammar Faizi
2025-08-08 13:34 ` Ammar Faizi
2025-08-08 18:07 ` Nam Cao
2025-08-08 22:52 ` Ammar Faizi
2025-08-09 4:34 ` Nam Cao
2025-08-09 13:28 ` Ammar Faizi
2025-08-09 14:49 ` Nam Cao
2025-08-09 15:15 ` Ammar Faizi
2025-08-09 15:32 ` Nam Cao
2025-08-09 16:03 ` Ammar Faizi
2025-08-09 16:28 ` Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807050350.FyWHwsig@linutronix.de \
--to=namcao@linutronix.de \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=helgaas@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lukas@wunner.de \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=sprite@gnuweeb.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.