From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FABEC87FCA for ; Thu, 7 Aug 2025 19:36:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B03A810E48D; Thu, 7 Aug 2025 19:36:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GbsuPzCt"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1732A10E48D for ; Thu, 7 Aug 2025 19:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754595413; x=1786131413; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zIIXh8AbyB9t1Rd83j3plz8IQ21mVIBl56uP1ZZXGMc=; b=GbsuPzCte6BueIGiHc5d5vI6hf6mxt1m10wErD3/6bdQiZglKzqj4sCZ /UQqlpGE384VBDR6QI1gvsO1HDkAel7my1ut/yiRnqTdTMSVrlbIqcP3x YDAijQg/Fb53ehMTfkgLPL44Igbs4agWQOvR1lLpPlyW1YMzJhgKJr6IM hEA8T0giIuhvuafCSblxWsHxycKr48nvJSLKUu6MGj581SbjRIo4wtWyj GoyPAjYqiu1tTdrmvvR/0Xae09kkvewVDIMPHwEkXCV3HHCkh0p0oKRdm T5YB4Gax1noblMqaxm62jSfpd6aorn/z+5iwjTLX+H5fsr+iN5nVYjsfQ g==; X-CSE-ConnectionGUID: 8cXTX6mhTxGDWhjS0PaT8Q== X-CSE-MsgGUID: WeThlSpeQUeSMvXYVjZaQQ== X-IronPort-AV: E=McAfee;i="6800,10657,11514"; a="56842543" X-IronPort-AV: E=Sophos;i="6.17,274,1747724400"; d="scan'208";a="56842543" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2025 12:36:52 -0700 X-CSE-ConnectionGUID: t2P/pYQgSSeZGsCT9roElQ== X-CSE-MsgGUID: +2FsiWVORfSHARxmGnpP8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,274,1747724400"; d="scan'208";a="202308339" Received: from dut136arlu.fm.intel.com ([10.105.23.75]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2025 12:36:51 -0700 From: stuartsummers To: Cc: matthew.brost@intel.com, farah.kassabri@intel.com, intel-xe@lists.freedesktop.org, Stuart Summers Subject: [PATCH 4/8] drm/xe: Add xe_gt_tlb_invalidation_done_handler Date: Thu, 7 Aug 2025 19:36:45 +0000 Message-Id: <20250807193649.55399-5-stuart.summers@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250807193649.55399-1-stuart.summers@intel.com> References: <20250807193649.55399-1-stuart.summers@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" From: Matthew Brost Decouple GT TLB seqno handling from G2H handler. v2: - Add kernel doc Signed-off-by: Matthew Brost Reviewed-by: Stuart Summers --- drivers/gpu/drm/xe/xe_gt_tlb_inval.c | 47 ++++++++++++++++++---------- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_inval.c b/drivers/gpu/drm/xe/xe_gt_tlb_inval.c index 5eae60823fb6..ecbfcc3bf1df 100644 --- a/drivers/gpu/drm/xe/xe_gt_tlb_inval.c +++ b/drivers/gpu/drm/xe/xe_gt_tlb_inval.c @@ -494,27 +494,18 @@ void xe_gt_tlb_inval_vm(struct xe_gt *gt, struct xe_vm *vm) } /** - * xe_guc_tlb_inval_done_handler - TLB invalidation done handler - * @guc: guc - * @msg: message indicating TLB invalidation done - * @len: length of message - * - * Parse seqno of TLB invalidation, wake any waiters for seqno, and signal any - * invalidation fences for seqno. Algorithm for this depends on seqno being - * received in-order and asserts this assumption. + * xe_gt_tlb_inval_done_handler - GT TLB invalidation done handler + * @gt: gt + * @seqno: seqno of invalidation that is done * - * Return: 0 on success, -EPROTO for malformed messages. + * Update recv seqno, signal any GT TLB invalidation fences, and restart TDR */ -int xe_guc_tlb_inval_done_handler(struct xe_guc *guc, u32 *msg, u32 len) +static void xe_gt_tlb_inval_done_handler(struct xe_gt *gt, int seqno) { - struct xe_gt *gt = guc_to_gt(guc); struct xe_device *xe = gt_to_xe(gt); struct xe_gt_tlb_inval_fence *fence, *next; unsigned long flags; - if (unlikely(len != 1)) - return -EPROTO; - /* * This can also be run both directly from the IRQ handler and also in * process_g2h_msg(). Only one may process any individual CT message, @@ -531,12 +522,12 @@ int xe_guc_tlb_inval_done_handler(struct xe_guc *guc, u32 *msg, u32 len) * process_g2h_msg(). */ spin_lock_irqsave(>->tlb_inval.pending_lock, flags); - if (tlb_inval_seqno_past(gt, msg[0])) { + if (tlb_inval_seqno_past(gt, seqno)) { spin_unlock_irqrestore(>->tlb_inval.pending_lock, flags); - return 0; + return; } - WRITE_ONCE(gt->tlb_inval.seqno_recv, msg[0]); + WRITE_ONCE(gt->tlb_inval.seqno_recv, seqno); list_for_each_entry_safe(fence, next, >->tlb_inval.pending_fences, link) { @@ -556,6 +547,28 @@ int xe_guc_tlb_inval_done_handler(struct xe_guc *guc, u32 *msg, u32 len) cancel_delayed_work(>->tlb_inval.fence_tdr); spin_unlock_irqrestore(>->tlb_inval.pending_lock, flags); +} + +/** + * xe_guc_tlb_inval_done_handler - TLB invalidation done handler + * @guc: guc + * @msg: message indicating TLB invalidation done + * @len: length of message + * + * Parse seqno of TLB invalidation, wake any waiters for seqno, and signal any + * invalidation fences for seqno. Algorithm for this depends on seqno being + * received in-order and asserts this assumption. + * + * Return: 0 on success, -EPROTO for malformed messages. + */ +int xe_guc_tlb_inval_done_handler(struct xe_guc *guc, u32 *msg, u32 len) +{ + struct xe_gt *gt = guc_to_gt(guc); + + if (unlikely(len != 1)) + return -EPROTO; + + xe_gt_tlb_inval_done_handler(gt, msg[0]); return 0; } -- 2.34.1