From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F222327CCC7 for ; Thu, 7 Aug 2025 20:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754597829; cv=none; b=KWj/mKGRdWtio5bR+dcnxhEzB28mS4HkgjMfbM/Rjr53O3iSRTfXcnGJBjwqA0wS42f3TSBLZhwxjqBtIXMczQlHzfi8DJN3RyEUOj1K2JnedUnM6XSENui4ouzlVlcxB7RH7+jbDjx6iQi5cFMrAUAeXJ2xmakezw0HqjIR1xs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754597829; c=relaxed/simple; bh=NkZ9cw2OQkpKTyBr6XnTKZKOxHkmBwe+wNgxb8ukCTo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HFZyUCiSV4qcOlFvIsEgJulfZLH0SYQ3latDAeD0CLc14Pm6mEOFjYLYsgH28xNWXZ3ihkGoX1WW4dmn46+FjBNs80J6Z874YPgcS3/SyABeQH4+Wumi8ltn/V8RDsF/KpF0EopJGXp/GRJDXi4bzIB2xZ4RzcKu0Q5d/V0tRQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--sagis.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CIsxf155; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--sagis.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CIsxf155" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3217aae3f90so959530a91.0 for ; Thu, 07 Aug 2025 13:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1754597826; x=1755202626; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=lGXEvvh28CILFU8veFYJPuuhWeDvdlK202GCjoHljc0=; b=CIsxf155Nn4ORlGN3obiaE94G2wj22Vnm3QOGfkzU+dflRorlXhpJj3o4NwdZnUoAI nE0jXotWm++qCYJk1ZzCFZ8hD7zWY4ugI5YNrC1nJgts5hkNij6JGj6U3DUzKpcEs6OW uEtnAW0fsLncJBl61evYtczbH+LIHqWKMhGQFBNg/Tohuo9mek5Lv+xml8bsSGZSZ+bp bbBeIjwZdNeoai28uLAY290UKIdFyaBIkNHwBemAT2bxpUHkqpRPGyJ4K+qMq5djtF50 0dgXkMYpoGJLN6tDAb4dh7NfZARWP8o0hmdrobGuRmO+ieHRaxLjR/EcoVomAsUviWnX Zlnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754597826; x=1755202626; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lGXEvvh28CILFU8veFYJPuuhWeDvdlK202GCjoHljc0=; b=jxxoV9ArH2miUa5FL8KD6tQQR7JdI6tVSNRD1fXvQ+j5NWm6G+Bgu0mYl3viJvxEG6 6fvqDelSV7oXz9U0eSqWN7wbILdMUun0+yrGYzddGDbv6q5BOLFK5vojqwCPd7PpQdC7 TBo59N2PiLjuHqWLHvrsU77HOp8J8w/SNBlaJNrpj5bQOwgPSbpWrXvvWJ0vupqNTbj/ rT69ax3L5hBA1wMJGwt00qiVv8O08LCOs9uPa7loUu2QPIuyeO2Q+aHfW9XD/0t+E9Fv Fs7TqYzV4f6Y6FZgd5VZ91nfz9jNkOxcjmHqkldAnfHLznpvWpUJtdOHmb2xCox92tPF lv2w== X-Forwarded-Encrypted: i=1; AJvYcCXU5jIHyJGZr9oo5dpKt4Vu/76ysja7mdqiEddpErRVSDCITIB8jwi+3cwGKGKh6gmt0kY=@vger.kernel.org X-Gm-Message-State: AOJu0YygcwpgdeE3ANzJwYd0WWxavub65g+LE+JOKuKjbFV9SEOIeMA9 9NqiQnpUe+y8D4+lZ5EXEaadWx71nK+pwYImbPscCnYoSO1rhJy8LG3Y9T1t/E02HaHNxErWHkY SWw== X-Google-Smtp-Source: AGHT+IEt1bokf2gwgVn7hdK2GrWh3MEGT0E9AT9JiLMbohoSe5t35nvuUxv5BuJLVfGUiWauYYMf6L5SXw== X-Received: from pjph9.prod.google.com ([2002:a17:90a:9c09:b0:320:e3e2:6877]) (user=sagis job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5249:b0:320:ff84:ceb5 with SMTP id 98e67ed59e1d1-32183b3f039mr501997a91.16.1754597826341; Thu, 07 Aug 2025 13:17:06 -0700 (PDT) Date: Thu, 7 Aug 2025 13:16:15 -0700 In-Reply-To: <20250807201628.1185915-1-sagis@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250807201628.1185915-1-sagis@google.com> X-Mailer: git-send-email 2.51.0.rc0.155.g4a0f42376b-goog Message-ID: <20250807201628.1185915-20-sagis@google.com> Subject: [PATCH v8 19/30] KVM: selftests: TDX: Add TDX MMIO writes test From: Sagi Shahar To: linux-kselftest@vger.kernel.org, Paolo Bonzini , Shuah Khan , Sean Christopherson , Ackerley Tng , Ryan Afranji , Andrew Jones , Isaku Yamahata , Erdem Aktas , Rick Edgecombe , Sagi Shahar , Roger Wang , Binbin Wu , Oliver Upton , "Pratik R. Sampat" , Reinette Chatre , Ira Weiny Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" The test verifies MMIO writes of various sizes from the guest to the host. Co-developed-by: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 2 + tools/testing/selftests/kvm/lib/x86/tdx/tdx.c | 14 +++ tools/testing/selftests/kvm/x86/tdx_vm_test.c | 85 ++++++++++++++++++- 3 files changed, 100 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h index fa0b24873a8f..2fd67c3e5128 100644 --- a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h @@ -25,5 +25,7 @@ uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index, uint64_t value); uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag); uint64_t tdg_vp_vmcall_ve_request_mmio_read(uint64_t address, uint64_t size, uint64_t *data_out); +uint64_t tdg_vp_vmcall_ve_request_mmio_write(uint64_t address, uint64_t size, + uint64_t data_in); #endif // SELFTEST_TDX_TDX_H diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c b/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c index 8bf41e667fc1..d61940fe7df4 100644 --- a/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c +++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c @@ -123,3 +123,17 @@ uint64_t tdg_vp_vmcall_ve_request_mmio_read(uint64_t address, uint64_t size, return ret; } + +uint64_t tdg_vp_vmcall_ve_request_mmio_write(uint64_t address, uint64_t size, + uint64_t data_in) +{ + struct tdx_hypercall_args args = { + .r11 = TDG_VP_VMCALL_VE_REQUEST_MMIO, + .r12 = size, + .r13 = MMIO_WRITE, + .r14 = address, + .r15 = data_in, + }; + + return __tdx_hypercall(&args, 0); +} diff --git a/tools/testing/selftests/kvm/x86/tdx_vm_test.c b/tools/testing/selftests/kvm/x86/tdx_vm_test.c index 563f1025c8a3..6ad675a93eeb 100644 --- a/tools/testing/selftests/kvm/x86/tdx_vm_test.c +++ b/tools/testing/selftests/kvm/x86/tdx_vm_test.c @@ -804,6 +804,87 @@ void verify_mmio_reads(void) printf("\t ... PASSED\n"); } +void guest_mmio_writes(void) +{ + uint64_t mmio_test_addr = TDX_MMIO_TEST_ADDR | tdx_s_bit; + uint64_t ret; + + ret = tdg_vp_vmcall_ve_request_mmio_write(mmio_test_addr, 1, 0x12); + tdx_assert_error(ret); + + ret = tdg_vp_vmcall_ve_request_mmio_write(mmio_test_addr, 2, 0x1234); + tdx_assert_error(ret); + + ret = tdg_vp_vmcall_ve_request_mmio_write(mmio_test_addr, 4, 0x12345678); + tdx_assert_error(ret); + + ret = tdg_vp_vmcall_ve_request_mmio_write(mmio_test_addr, 8, 0x1234567890ABCDEF); + tdx_assert_error(ret); + + /* Make sure host and guest are synced to the same point of execution */ + tdx_test_report_to_user_space(MMIO_SYNC_VALUE); + + /* Write across page boundary. */ + ret = tdg_vp_vmcall_ve_request_mmio_write(PAGE_SIZE - 1, 8, 0); + tdx_assert_error(ret); + + tdx_test_success(); +} + +/* + * Verifies guest MMIO writes. + */ +void verify_mmio_writes(void) +{ + struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + uint64_t byte_8; + uint32_t byte_4; + uint16_t byte_2; + uint8_t byte_1; + + vm = td_create(); + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); + vcpu = td_vcpu_add(vm, 0, guest_mmio_writes); + td_finalize(vm); + + printf("Verifying TD MMIO writes:\n"); + + tdx_run(vcpu); + tdx_test_assert_mmio(vcpu, TDX_MMIO_TEST_ADDR, 1, MMIO_WRITE); + byte_1 = *(uint8_t *)(vcpu->run->mmio.data); + + tdx_run(vcpu); + tdx_test_assert_mmio(vcpu, TDX_MMIO_TEST_ADDR, 2, MMIO_WRITE); + byte_2 = *(uint16_t *)(vcpu->run->mmio.data); + + tdx_run(vcpu); + tdx_test_assert_mmio(vcpu, TDX_MMIO_TEST_ADDR, 4, MMIO_WRITE); + byte_4 = *(uint32_t *)(vcpu->run->mmio.data); + + tdx_run(vcpu); + tdx_test_assert_mmio(vcpu, TDX_MMIO_TEST_ADDR, 8, MMIO_WRITE); + byte_8 = *(uint64_t *)(vcpu->run->mmio.data); + + TEST_ASSERT_EQ(byte_1, 0x12); + TEST_ASSERT_EQ(byte_2, 0x1234); + TEST_ASSERT_EQ(byte_4, 0x12345678); + TEST_ASSERT_EQ(byte_8, 0x1234567890ABCDEF); + + tdx_run(vcpu); + TEST_ASSERT_EQ(tdx_test_read_report_from_guest(vcpu), MMIO_SYNC_VALUE); + + td_vcpu_run(vcpu); + TEST_ASSERT_EQ(vcpu->run->exit_reason, KVM_EXIT_SYSTEM_EVENT); + TEST_ASSERT_EQ(vcpu->run->system_event.data[12], TDG_VP_VMCALL_INVALID_OPERAND); + + tdx_run(vcpu); + tdx_test_assert_success(vcpu); + + kvm_vm_free(vm); + printf("\t ... PASSED\n"); +} + int main(int argc, char **argv) { ksft_print_header(); @@ -811,7 +892,7 @@ int main(int argc, char **argv) if (!is_tdx_enabled()) ksft_exit_skip("TDX is not supported by the KVM. Exiting.\n"); - ksft_set_plan(11); + ksft_set_plan(12); ksft_test_result(!run_in_new_process(&verify_td_lifecycle), "verify_td_lifecycle\n"); ksft_test_result(!run_in_new_process(&verify_report_fatal_error), @@ -834,6 +915,8 @@ int main(int argc, char **argv) "verify_guest_hlt\n"); ksft_test_result(!run_in_new_process(&verify_mmio_reads), "verify_mmio_reads\n"); + ksft_test_result(!run_in_new_process(&verify_mmio_writes), + "verify_mmio_writes\n"); ksft_finished(); return 0; -- 2.51.0.rc0.155.g4a0f42376b-goog