Re: [PATCH v4 2/2] net/zxdh: add support flow director ops

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri,  8 Aug 2025 15:10:37 +0800
Junlong Wang <wang.junlong1@zte.com.cn> wrote:

> From: Bingbin Chen <chen.bingbin@zte.com.cn>
> 
> Provide support for ETH, VLAN, IPv4/IPv6, TCP/UDP, VXLAN,
> and mask matching, supporting multiple actions
> include drop/count/mark/queue/rss,and vxlan decap/encap.
> 
> Signed-off-by: Bingbin Chen <chen.bingbin@zte.com.cn>
> ---
>  doc/guides/nics/features/zxdh.ini  |   16 +
>  doc/guides/nics/zxdh.rst           |    1 +
>  drivers/net/zxdh/meson.build       |    1 +
>  drivers/net/zxdh/zxdh_common.h     |    1 +
>  drivers/net/zxdh/zxdh_ethdev.c     |   26 +
>  drivers/net/zxdh/zxdh_ethdev.h     |   12 +-
>  drivers/net/zxdh/zxdh_ethdev_ops.c |    2 +-
>  drivers/net/zxdh/zxdh_ethdev_ops.h |    1 +
>  drivers/net/zxdh/zxdh_flow.c       | 2000 ++++++++++++++++++++++++++++
>  drivers/net/zxdh/zxdh_flow.h       |  237 ++++
>  drivers/net/zxdh/zxdh_msg.c        |  264 +++-
>  drivers/net/zxdh/zxdh_msg.h        |   31 +-
>  drivers/net/zxdh/zxdh_tables.h     |   10 +-
>  13 files changed, 2529 insertions(+), 73 deletions(-)
>  create mode 100644 drivers/net/zxdh/zxdh_flow.c
>  create mode 100644 drivers/net/zxdh/zxdh_flow.h

Missing include of stdlib.h

==== 20 line log output for CentOS Stream 10 (dpdk_meson_compile): ====
../drivers/net/zxdh/zxdh_flow.c:664:25: error: implicit declaration of function 'free' [-Wimplicit-function-declaration]
664 |                         free(result);
|                         ^~~~
../drivers/net/zxdh/zxdh_flow.c:664:25: note: include '<stdlib.h>' or provide a declaration of 'free'
../drivers/net/zxdh/zxdh_flow.c:664:25: error: incompatible implicit declaration of built-in function 'free' [-Werror=builtin-declaration-mismatch]
../drivers/net/zxdh/zxdh_flow.c:664:25: note: include '<stdlib.h>' or provide a declaration of 'free'
../drivers/net/zxdh/zxdh_flow.c:669:33: error: incompatible implicit declaration of built-in function 'calloc' [-Werror=builtin-declaration-mismatch]
669 |                         entry = calloc(1, sizeof(struct rte_flow));
|                                 ^~~~~~
../drivers/net/zxdh/zxdh_flow.c:669:33: note: include '<stdlib.h>' or provide a declaration of 'calloc'
../drivers/net/zxdh/zxdh_flow.c:677:25: error: incompatible implicit declaration of built-in function 'free' [-Werror=builtin-declaration-mismatch]
677 |                         free(entry_flow);
|                         ^~~~
../drivers/net/zxdh/zxdh_flow.c:677:25: note: include '<stdlib.h>' or provide a declaration of 'free'
../drivers/net/zxdh/zxdh_flow.c:685:9: error: incompatible implicit declaration of built-in function 'free' [-Werror=builtin-declaration-mismatch]
685 |         free(result);
|         ^~~~
../drivers/net/zxdh/zxdh_flow.c:685:9: note: include '<stdlib.h>' or provide a declaration of 'free'
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.