From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14258C87FD3 for ; Fri, 8 Aug 2025 15:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ynD6F7zbd7E5ySJ7ew2D57ai1bmp3VGGjgVc6fbGcm8=; b=apqtCgAQoS6u2NPlWHcZ6gjjrp BkTdQq8klfkJFYn0Y4KISM5dhqDgj8xFBbvWRpa1H4hWi7Wjpx/qQgOx5/0abxA6Af+P/pgjpgzsH j6Nc9FvvWQvKxzwcKOcMhLNbZTYN0SSFhceJgal3EJeVhIudJOoRrxEdhVo2erbZLOxDwUViYa+W1 yRfN4x6Cx4Xzm3u2NugbvkjfAHtr90kmJt2JSaje8Xs0fn/N/SRPzRV6swKFcT83b3wRWBfUNqwEX GPFaaI8fUAOC0gaoKWGt19XSSei8gEFXP/H5Yn9/nCVg3cKlPcpdrfsKocvTW3dT1GhH6opaoyrMe OICsYKlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ukP3F-00000003BE9-1lxa; Fri, 08 Aug 2025 15:30:37 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ukOyI-00000003A9j-2W1a for linux-arm-kernel@lists.infradead.org; Fri, 08 Aug 2025 15:25:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D8234601F5; Fri, 8 Aug 2025 15:25:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5C25C4CEED; Fri, 8 Aug 2025 15:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754666729; bh=ql43Pm5ZVVpFZkt/lmAyISGZXPuox8rw7R6mqwFTem0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d1o2Rd1nJHSRYFCzylvP+3x9U8gc1HC0fXIU0YsQVx7xGvfqmXhr0IuqJsRnpv0Tk nRHkvuOOLCFr8tAX2twv/foDjaDtd5bB3P62pK8RanglCpRoAF3UhTbPGsDquJjVsM YnhVgSXaPTaY7/NrDnIo9XaYFyC3+e+N+gElNMZin1iMb3Baoweh+Ekj1fYoF7TZwr M6qYj8IFllGuc/2eFH3faF/K84LpxFhw4YCNb7Us3cKHIOgqBJ7urKJdf1CJulU6aO YNKq6Fvb4njTbSm7YegOPQmoYDAtj1OpwXd4NDQL0TQf2UrAcffq2kN8kCH1HWJYiV 8szml0eaARUgw== From: Arnd Bergmann To: Bartosz Golaszewski , Linus Walleij , linux-gpio@vger.kernel.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Arnd Bergmann , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 20/21] ASoC: pxa: add GPIOLIB_LEGACY dependency Date: Fri, 8 Aug 2025 17:18:05 +0200 Message-Id: <20250808151822.536879-21-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250808151822.536879-1-arnd@kernel.org> References: <20250808151822.536879-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann The pxa27x platform uses the legacy gpiolib interfaces, including in its sound drivers: sound/arm/pxa2xx-ac97-lib.c: In function 'pxa2xx_ac97_hw_probe': sound/arm/pxa2xx-ac97-lib.c:374:23: error: implicit declaration of function 'gpio_request_one' [-Wimplicit-function-declaration] 374 | ret = gpio_request_one(reset_gpio, GPIOF_OUT_INIT_HIGH, Make sure we don't select those drivers for compile-testing unless we are building for a pxa27x system, or CONFIG_GPIOLIB_LEGACY is already enabled. The SND_PXA_SOC_SSP driver accidentally used a dependency on PLAT_PXA, which includes both ARCH_PXA and ARCH_MMP, but it is only used on the former. Signed-off-by: Arnd Bergmann --- sound/soc/pxa/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig index e026f9912a6d..e54abcd39f79 100644 --- a/sound/soc/pxa/Kconfig +++ b/sound/soc/pxa/Kconfig @@ -3,7 +3,7 @@ menu "PXA" config SND_PXA2XX_SOC tristate "SoC Audio for the Intel PXA2xx chip" - depends on ARCH_PXA || COMPILE_TEST + depends on ARCH_PXA || (COMPILE_TEST && GPIOLIB_LEGACY) select SND_PXA2XX_LIB help Say Y or M if you want to add support for codecs attached to @@ -26,7 +26,7 @@ config SND_PXA2XX_SOC_I2S config SND_PXA_SOC_SSP tristate "Soc Audio via PXA2xx/PXA3xx SSP ports" - depends on PLAT_PXA + depends on ARCH_PXA select PXA_SSP select SND_PXA2XX_LIB -- 2.39.5