From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <alison.schofield@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH 2/3] cxl/acpi: Make the XOR calculations available for testing
Date: Fri, 8 Aug 2025 17:19:21 +0100 [thread overview]
Message-ID: <20250808171921.00000cb9@huawei.com> (raw)
In-Reply-To: <e2ffaa6a29117fd9832542e4ac314b46ab2d1fd8.1754291501.git.alison.schofield@intel.com>
On Mon, 4 Aug 2025 01:52:40 -0700
alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> In preparation for adding a test module that can exercise the address
> translation functions performed on XOR configured regions, the XOR
> function needs to be refactored and the ability to create a CXIMS
> provided.
>
> Refactor the XOR function by extracting the core calculation into a
> standalone function. Enhance the parameter validation since this new
> function will be called from the test module where the parameters
> may not be guaranteed valid.
>
> To allow the test module to create a CXIMS without exposing the full
> cxl_cxims_data structure, add new functions that can create and free
> a CXIMS.
>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Hi Alison,
I'm not particularly keen on code that is just there to create opaque
stuff for tests that may or may not be built but I guess it's not huge
so fair enough.
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2025-08-08 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 8:52 [PATCH 0/3] CXL: Add a loadable module for address translation alison.schofield
2025-08-04 8:52 ` [PATCH 1/3] cxl/region: Refactor address translation funcs for testing alison.schofield
2025-08-08 16:12 ` Jonathan Cameron
2025-08-29 6:21 ` Alison Schofield
2025-08-11 16:00 ` Dave Jiang
2025-08-29 6:34 ` Alison Schofield
2025-08-04 8:52 ` [PATCH 2/3] cxl/acpi: Make the XOR calculations available " alison.schofield
2025-08-08 16:19 ` Jonathan Cameron [this message]
2025-08-29 6:23 ` Alison Schofield
2025-08-13 2:54 ` dan.j.williams
2025-08-29 6:39 ` Alison Schofield
2025-08-04 8:52 ` [PATCH 3/3] cxl/test: Add cxl_translate module for address translation testing alison.schofield
2025-08-08 16:24 ` Jonathan Cameron
2025-08-29 6:26 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808171921.00000cb9@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.