From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 2/2] rtc: pcf85363: add support for additional features
Date: Sun, 10 Aug 2025 12:31:09 +0800 [thread overview]
Message-ID: <202508101234.9f8Bejne-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250808112246.4169280-2-lakshay.piplani@nxp.com>
References: <20250808112246.4169280-2-lakshay.piplani@nxp.com>
TO: Lakshay Piplani <lakshay.piplani@nxp.com>
TO: alexandre.belloni@bootlin.com
TO: linux-rtc@vger.kernel.org
TO: linux-kernel@vger.kernel.org
TO: robh@kernel.org
TO: krzk+dt@kernel.org
TO: conor+dt@kernel.org
TO: devicetree@vger.kernel.org
CC: vikash.bansal@nxp.com
CC: priyanka.jain@nxp.com
CC: shashank.rebbapragada@nxp.com
CC: Lakshay Piplani <lakshay.piplani@nxp.com>
Hi Lakshay,
kernel test robot noticed the following build warnings:
[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on linus/master v6.16 next-20250808]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lakshay-Piplani/rtc-pcf85363-add-support-for-additional-features/20250808-192449
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link: https://lore.kernel.org/r/20250808112246.4169280-2-lakshay.piplani%40nxp.com
patch subject: [PATCH 2/2] rtc: pcf85363: add support for additional features
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: openrisc-randconfig-r071-20250810 (https://download.01.org/0day-ci/archive/20250810/202508101234.9f8Bejne-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202508101234.9f8Bejne-lkp@intel.com/
smatch warnings:
drivers/rtc/rtc-pcf85363.c:634 pcf85363_watchdog_init() error: uninitialized symbol 'ret'.
vim +/ret +634 drivers/rtc/rtc-pcf85363.c
9ca6579ec239f99 Lakshay Piplani 2025-08-08 605
9ca6579ec239f99 Lakshay Piplani 2025-08-08 606 /*
9ca6579ec239f99 Lakshay Piplani 2025-08-08 607 * Parses watchdog configuration from device tree and registers the
9ca6579ec239f99 Lakshay Piplani 2025-08-08 608 * watchdog with the Linux watchdog subsystem.
9ca6579ec239f99 Lakshay Piplani 2025-08-08 609 */
9ca6579ec239f99 Lakshay Piplani 2025-08-08 610 static int pcf85363_watchdog_init(struct device *dev, struct regmap *regmap)
9ca6579ec239f99 Lakshay Piplani 2025-08-08 611 {
9ca6579ec239f99 Lakshay Piplani 2025-08-08 612 struct pcf85363_watchdog *wd;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 613 u32 timeout = 10, clock = 0;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 614 int ret;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 615
9ca6579ec239f99 Lakshay Piplani 2025-08-08 616 if (!IS_ENABLED(CONFIG_WATCHDOG) || !device_property_read_bool(dev, "nxp,enable-watchdog"))
9ca6579ec239f99 Lakshay Piplani 2025-08-08 617 return 0;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 618
9ca6579ec239f99 Lakshay Piplani 2025-08-08 619 wd = devm_kzalloc(dev, sizeof(*wd), GFP_KERNEL);
9ca6579ec239f99 Lakshay Piplani 2025-08-08 620 if (!wd)
9ca6579ec239f99 Lakshay Piplani 2025-08-08 621 return -ENOMEM;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 622
9ca6579ec239f99 Lakshay Piplani 2025-08-08 623 wd->regmap = regmap;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 624 wd->dev = dev;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 625
9ca6579ec239f99 Lakshay Piplani 2025-08-08 626 device_property_read_u32(dev, "nxp,watchdog-timeout", &timeout);
9ca6579ec239f99 Lakshay Piplani 2025-08-08 627 wd->timeout_val = clamp(timeout, WD_TIMEOUT_MIN, WD_TIMEOUT_MAX);
9ca6579ec239f99 Lakshay Piplani 2025-08-08 628
9ca6579ec239f99 Lakshay Piplani 2025-08-08 629 device_property_read_u32(dev, "nxp,watchdog-stepsize", &clock);
9ca6579ec239f99 Lakshay Piplani 2025-08-08 630 wd->clock_sel = clock & WD_CLKSEL_MASK;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 631
9ca6579ec239f99 Lakshay Piplani 2025-08-08 632 wd->repeat = device_property_read_bool(dev, "nxp,watchdog-repeat");
9ca6579ec239f99 Lakshay Piplani 2025-08-08 633
9ca6579ec239f99 Lakshay Piplani 2025-08-08 @634 if (ret)
9ca6579ec239f99 Lakshay Piplani 2025-08-08 635 return ret;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 636
9ca6579ec239f99 Lakshay Piplani 2025-08-08 637 /* Clear any stale WDF flag */
9ca6579ec239f99 Lakshay Piplani 2025-08-08 638 regmap_update_bits(regmap, CTRL_FLAGS, FLAGS_WDF, 0);
9ca6579ec239f99 Lakshay Piplani 2025-08-08 639
9ca6579ec239f99 Lakshay Piplani 2025-08-08 640 /* Register the watchdog device */
9ca6579ec239f99 Lakshay Piplani 2025-08-08 641 wd->wdd.info = &pcf85363_wdt_info;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 642 wd->wdd.ops = &pcf85363_wdt_ops;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 643 wd->wdd.min_timeout = WD_TIMEOUT_MIN;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 644 wd->wdd.max_timeout = WD_TIMEOUT_MAX;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 645 wd->wdd.timeout = wd->timeout_val;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 646 wd->wdd.parent = dev;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 647
9ca6579ec239f99 Lakshay Piplani 2025-08-08 648 /*
9ca6579ec239f99 Lakshay Piplani 2025-08-08 649 * For testing purposes, it's recommended to enable CONFIG_WATCHDOG_NOWAYOUT
9ca6579ec239f99 Lakshay Piplani 2025-08-08 650 * in the kernel configuration. If this option is not set, the watchdog may stop
9ca6579ec239f99 Lakshay Piplani 2025-08-08 651 * immediately after being started, especially if the user-space daemon closes
9ca6579ec239f99 Lakshay Piplani 2025-08-08 652 * /dev/watchdog without keeping it alive. Enabling NOWAYOUT ensures the watchdog
9ca6579ec239f99 Lakshay Piplani 2025-08-08 653 * remains active and can properly test system reset behavior.
9ca6579ec239f99 Lakshay Piplani 2025-08-08 654 */
9ca6579ec239f99 Lakshay Piplani 2025-08-08 655 wd->wdd.status = WATCHDOG_NOWAYOUT_INIT_STATUS;
9ca6579ec239f99 Lakshay Piplani 2025-08-08 656
9ca6579ec239f99 Lakshay Piplani 2025-08-08 657 watchdog_set_drvdata(&wd->wdd, wd);
9ca6579ec239f99 Lakshay Piplani 2025-08-08 658
9ca6579ec239f99 Lakshay Piplani 2025-08-08 659 dev_info(dev, "pcf85363: watchdog initialized successfully\n");
9ca6579ec239f99 Lakshay Piplani 2025-08-08 660
9ca6579ec239f99 Lakshay Piplani 2025-08-08 661 return devm_watchdog_register_device(dev, &wd->wdd);
9ca6579ec239f99 Lakshay Piplani 2025-08-08 662 }
9ca6579ec239f99 Lakshay Piplani 2025-08-08 663
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-08-10 4:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 4:31 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-08-08 11:22 [PATCH 1/2] rtc: pcf85363: add support for timestamp and watchdog Lakshay Piplani
2025-08-08 11:22 ` [PATCH 2/2] rtc: pcf85363: add support for additional features Lakshay Piplani
2025-08-09 4:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508101234.9f8Bejne-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.