From: Frieder Schrempf <frieder@fris.de>
To: u-boot@lists.denx.de, Jaehoon Chung <jh80.chung@samsung.com>,
Tom Rini <trini@konsulko.com>
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>,
Joy Zou <joy.zou@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Ye Li <ye.li@nxp.com>
Subject: [PATCH 1/6] Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"
Date: Mon, 11 Aug 2025 15:11:57 +0200 [thread overview]
Message-ID: <20250811131213.211124-2-frieder@fris.de> (raw)
In-Reply-To: <20250811131213.211124-1-frieder@fris.de>
From: Frieder Schrempf <frieder.schrempf@kontron.de>
This reverts commit 2add0511757e2c5897a88b57c5ea8c912140e60f.
It turns out that all boards using the PCA9450 actually have the
SD_VSEL input connected to the VSELECT signal of the SoCs SD/MMC
interface. Therefore we don't need manual control for this signal
via GPIO and there aren't any users.
This is equivalent to the following change in Linux:
c73be62caabb ("Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5"")
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
drivers/power/pmic/pca9450.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c
index 9d875f8bdbe..0e3d14abf15 100644
--- a/drivers/power/pmic/pca9450.c
+++ b/drivers/power/pmic/pca9450.c
@@ -6,12 +6,9 @@
#include <fdtdec.h>
#include <errno.h>
#include <dm.h>
-#include <dm/device_compat.h>
#include <i2c.h>
-#include <linux/err.h>
#include <log.h>
#include <asm/global_data.h>
-#include <asm-generic/gpio.h>
#include <linux/printk.h>
#include <power/pmic.h>
#include <power/regulator.h>
@@ -29,10 +26,6 @@ static const struct pmic_child_info pmic_children_info[] = {
{ },
};
-struct pca9450_priv {
- struct gpio_desc *sd_vsel_gpio;
-};
-
static int pca9450_reg_count(struct udevice *dev)
{
return PCA9450_REG_NUM;
@@ -85,21 +78,7 @@ static int pca9450_bind(struct udevice *dev)
static int pca9450_probe(struct udevice *dev)
{
- struct pca9450_priv *priv = dev_get_priv(dev);
unsigned int reset_ctrl;
- int ret = 0;
-
- if (CONFIG_IS_ENABLED(DM_GPIO) && CONFIG_IS_ENABLED(DM_REGULATOR_PCA9450)) {
- priv->sd_vsel_gpio = devm_gpiod_get_optional(dev, "sd-vsel",
- GPIOD_IS_OUT |
- GPIOD_IS_OUT_ACTIVE);
- if (IS_ERR(priv->sd_vsel_gpio)) {
- ret = PTR_ERR(priv->sd_vsel_gpio);
- dev_err(dev, "Failed to request SD_VSEL GPIO: %d\n", ret);
- if (ret)
- return ret;
- }
- }
if (ofnode_read_bool(dev_ofnode(dev), "nxp,wdog_b-warm-reset"))
reset_ctrl = PCA9450_PMIC_RESET_WDOG_B_CFG_WARM;
@@ -132,5 +111,4 @@ U_BOOT_DRIVER(pmic_pca9450) = {
.bind = pca9450_bind,
.probe = pca9450_probe,
.ops = &pca9450_ops,
- .priv_auto = sizeof(struct pca9450_priv),
};
--
2.50.1
next prev parent reply other threads:[~2025-08-11 13:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 13:11 [PATCH 0/6] Use correct LDO5 control registers for PCA9450 Frieder Schrempf
2025-08-11 13:11 ` Frieder Schrempf [this message]
2025-08-11 13:11 ` [PATCH 2/6] pmic: pca9450: Fix enable register for LDO5 Frieder Schrempf
2025-08-11 13:11 ` [PATCH 3/6] pmic: pca9450: Fix control " Frieder Schrempf
2025-08-11 13:12 ` [PATCH 4/6] pmic: pca9450: Handle hardware with fixed SD_VSEL " Frieder Schrempf
2025-08-11 13:12 ` [PATCH 5/6] arm: dts: imx8mp-data-modul-edm-sbc: Remove deprecated sd-vsel-gpios Frieder Schrempf
2025-08-11 14:22 ` Marek Vasut
2025-08-11 13:12 ` [PATCH 6/6] arm: dts: imx8mp-dhcom-som: " Frieder Schrempf
2025-08-11 14:21 ` Marek Vasut
2025-08-25 8:40 ` [PATCH 0/6] Use correct LDO5 control registers for PCA9450 Frieder Schrempf
2025-08-27 5:46 ` Peng Fan
2025-08-27 7:37 ` Frieder Schrempf
2025-08-27 14:32 ` Tom Rini
2025-09-01 7:44 ` Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811131213.211124-2-frieder@fris.de \
--to=frieder@fris.de \
--cc=frieder.schrempf@kontron.de \
--cc=jh80.chung@samsung.com \
--cc=joy.zou@nxp.com \
--cc=peng.fan@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.