From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Jay Vosburgh <jv@jvosburgh.net>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
David Wilder <wilder@us.ibm.com>
Subject: Re: [PATCH net] bonding: don't set oif to bond dev when getting NS target destination
Date: Mon, 11 Aug 2025 20:15:08 -0700 [thread overview]
Message-ID: <20250811201508.508a7e3d@kernel.org> (raw)
In-Reply-To: <aJqhRXIb3zZutO6H@fedora>
On Tue, 12 Aug 2025 02:04:53 +0000 Hangbin Liu wrote:
> On Mon, Aug 11, 2025 at 09:33:28AM -0700, Jakub Kicinski wrote:
> > On Mon, 11 Aug 2025 07:27:19 -0700 Jay Vosburgh wrote:
> > > Generically, I'm wondering if test updates should be separate
> > > patches from the functional changes as a general policy.
> >
> > Yes, not sure if we made it a hard requirement, but I think it's our
> > preference. It is the reason why we don't require cover letters for
> > submissions with 2 patches.
> >
> > Hangbin, please update config for bonding tests, looks like vlans
> > are not enabled there today.
>
> BTW, I'd like to change the bond config to modules. Because we can't unload
> the modules with current config. It that OK for you?
Yes. I'm not sure if any of the bonding tests need to load the modules
explicitly but we'll find out :) In general modules are fine for the CI.
prev parent reply other threads:[~2025-08-12 3:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 14:03 [PATCH net] bonding: don't set oif to bond dev when getting NS target destination Hangbin Liu
2025-08-11 14:27 ` Jay Vosburgh
2025-08-11 16:33 ` Jakub Kicinski
2025-08-12 1:53 ` Hangbin Liu
2025-08-12 2:04 ` Hangbin Liu
2025-08-12 3:15 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811201508.508a7e3d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=wilder@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.