From: kernel test robot <lkp@intel.com>
To: Bhupesh <bhupesh@igalia.com>, akpm@linux-foundation.org
Cc: oe-kbuild-all@lists.linux.dev, bhupesh@igalia.com,
kernel-dev@igalia.com, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com,
pmladek@suse.com, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com,
alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com,
mirq-linux@rere.qmqm.pl, peterz@infradead.org,
willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk,
keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org,
jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com,
bsegall@google.com, mgorman@suse.de
Subject: Re: [PATCH v7 4/4] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation
Date: Tue, 12 Aug 2025 00:37:42 +0800 [thread overview]
Message-ID: <202508120011.j4Pmr6Rf-lkp@intel.com> (raw)
In-Reply-To: <20250811064609.918593-5-bhupesh@igalia.com>
Hi Bhupesh,
kernel test robot noticed the following build errors:
[auto build test ERROR on next-20250808]
[cannot apply to trace/for-next tip/sched/core brauner-vfs/vfs.all linus/master v6.17-rc1 v6.16 v6.16-rc7 v6.17-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bhupesh/exec-Remove-obsolete-comments/20250811-144920
base: next-20250808
patch link: https://lore.kernel.org/r/20250811064609.918593-5-bhupesh%40igalia.com
patch subject: [PATCH v7 4/4] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation
config: x86_64-buildonly-randconfig-001-20250811 (https://download.01.org/0day-ci/archive/20250812/202508120011.j4Pmr6Rf-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250812/202508120011.j4Pmr6Rf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508120011.j4Pmr6Rf-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/trace/define_trace.h:132,
from include/trace/events/sched.h:901,
from kernel/sched/core.c:85:
include/trace/events/sched.h: In function 'do_trace_event_raw_event_sched_skip_cpuset_numa':
>> include/trace/events/sched.h:796:39: error: passing argument 1 of '__cstr_array_copy' from incompatible pointer type [-Werror=incompatible-pointer-types]
796 | get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
include/trace/trace_events.h:427:11: note: in definition of macro '__DECLARE_EVENT_CLASS'
427 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:435:23: note: in expansion of macro 'PARAMS'
435 | PARAMS(assign), PARAMS(print)) \
| ^~~~~~
include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
40 | DECLARE_EVENT_CLASS(name, \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/events/sched.h:775:1: note: in expansion of macro 'TRACE_EVENT'
775 | TRACE_EVENT(sched_skip_cpuset_numa,
| ^~~~~~~~~~~
include/trace/events/sched.h:789:9: note: in expansion of macro 'TP_fast_assign'
789 | TP_fast_assign(
| ^~~~~~~~~~~~~~
include/trace/events/sched.h:796:17: note: in expansion of macro 'get_task_array'
796 | get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
| ^~~~~~~~~~~~~~
In file included from include/linux/percpu.h:12,
from arch/x86/include/asm/msr.h:16,
from arch/x86/include/asm/tsc.h:11,
from arch/x86/include/asm/timex.h:6,
from include/linux/timex.h:67,
from include/linux/time32.h:13,
from include/linux/time.h:60,
from include/linux/stat.h:19,
from include/linux/fs.h:11,
from include/linux/highmem.h:5,
from kernel/sched/core.c:10:
include/linux/sched.h:1991:33: note: expected 'char *' but argument is of type 'long unsigned int *'
1991 | __cstr_array_copy(char *dst, const char *src,
| ~~~~~~^~~
include/trace/events/sched.h:796:69: error: passing argument 2 of '__cstr_array_copy' from incompatible pointer type [-Werror=incompatible-pointer-types]
796 | get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
| ~~~~~~~~~~~~~~~^~~~~~
| |
| long unsigned int *
include/trace/trace_events.h:427:11: note: in definition of macro '__DECLARE_EVENT_CLASS'
427 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:435:23: note: in expansion of macro 'PARAMS'
435 | PARAMS(assign), PARAMS(print)) \
| ^~~~~~
include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
40 | DECLARE_EVENT_CLASS(name, \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/events/sched.h:775:1: note: in expansion of macro 'TRACE_EVENT'
775 | TRACE_EVENT(sched_skip_cpuset_numa,
| ^~~~~~~~~~~
include/trace/events/sched.h:789:9: note: in expansion of macro 'TP_fast_assign'
789 | TP_fast_assign(
| ^~~~~~~~~~~~~~
include/trace/events/sched.h:796:17: note: in expansion of macro 'get_task_array'
796 | get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
| ^~~~~~~~~~~~~~
include/linux/sched.h:1991:50: note: expected 'const char *' but argument is of type 'long unsigned int *'
1991 | __cstr_array_copy(char *dst, const char *src,
| ~~~~~~~~~~~~^~~
In file included from include/trace/define_trace.h:133:
include/trace/events/sched.h: In function 'do_perf_trace_sched_skip_cpuset_numa':
>> include/trace/events/sched.h:796:39: error: passing argument 1 of '__cstr_array_copy' from incompatible pointer type [-Werror=incompatible-pointer-types]
796 | get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
include/trace/perf.h:51:11: note: in definition of macro '__DECLARE_EVENT_CLASS'
51 | { assign; } \
| ^~~~~~
include/trace/perf.h:67:23: note: in expansion of macro 'PARAMS'
67 | PARAMS(assign), PARAMS(print)) \
| ^~~~~~
include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
40 | DECLARE_EVENT_CLASS(name, \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/events/sched.h:775:1: note: in expansion of macro 'TRACE_EVENT'
775 | TRACE_EVENT(sched_skip_cpuset_numa,
| ^~~~~~~~~~~
include/trace/events/sched.h:789:9: note: in expansion of macro 'TP_fast_assign'
789 | TP_fast_assign(
| ^~~~~~~~~~~~~~
include/trace/events/sched.h:796:17: note: in expansion of macro 'get_task_array'
796 | get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
| ^~~~~~~~~~~~~~
include/linux/sched.h:1991:33: note: expected 'char *' but argument is of type 'long unsigned int *'
1991 | __cstr_array_copy(char *dst, const char *src,
| ~~~~~~^~~
include/trace/events/sched.h:796:69: error: passing argument 2 of '__cstr_array_copy' from incompatible pointer type [-Werror=incompatible-pointer-types]
796 | get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
| ~~~~~~~~~~~~~~~^~~~~~
| |
| long unsigned int *
include/trace/perf.h:51:11: note: in definition of macro '__DECLARE_EVENT_CLASS'
51 | { assign; } \
| ^~~~~~
include/trace/perf.h:67:23: note: in expansion of macro 'PARAMS'
67 | PARAMS(assign), PARAMS(print)) \
| ^~~~~~
include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
40 | DECLARE_EVENT_CLASS(name, \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/events/sched.h:775:1: note: in expansion of macro 'TRACE_EVENT'
775 | TRACE_EVENT(sched_skip_cpuset_numa,
| ^~~~~~~~~~~
include/trace/events/sched.h:789:9: note: in expansion of macro 'TP_fast_assign'
789 | TP_fast_assign(
| ^~~~~~~~~~~~~~
include/trace/events/sched.h:796:17: note: in expansion of macro 'get_task_array'
796 | get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
| ^~~~~~~~~~~~~~
include/linux/sched.h:1991:50: note: expected 'const char *' but argument is of type 'long unsigned int *'
1991 | __cstr_array_copy(char *dst, const char *src,
| ~~~~~~~~~~~~^~~
cc1: some warnings being treated as errors
vim +/__cstr_array_copy +796 include/trace/events/sched.h
776
777 TP_PROTO(struct task_struct *tsk, nodemask_t *mem_allowed_ptr),
778
779 TP_ARGS(tsk, mem_allowed_ptr),
780
781 TP_STRUCT__entry(
782 __array( char, comm, TASK_COMM_LEN )
783 __field( pid_t, pid )
784 __field( pid_t, tgid )
785 __field( pid_t, ngid )
786 __array( unsigned long, mem_allowed, BITS_TO_LONGS(MAX_NUMNODES))
787 ),
788
789 TP_fast_assign(
790 get_task_array(__entry->comm, tsk->comm);
791 __entry->pid = task_pid_nr(tsk);
792 __entry->tgid = task_tgid_nr(tsk);
793 __entry->ngid = task_numa_group_id(tsk);
794 BUILD_BUG_ON(sizeof(nodemask_t) != \
795 BITS_TO_LONGS(MAX_NUMNODES) * sizeof(long));
> 796 get_task_array(__entry->mem_allowed, mem_allowed_ptr->bits);
797 ),
798
799 TP_printk("comm=%s pid=%d tgid=%d ngid=%d mem_nodes_allowed=%*pbl",
800 __entry->comm,
801 __entry->pid,
802 __entry->tgid,
803 __entry->ngid,
804 MAX_NUMNODES, __entry->mem_allowed)
805 );
806 #endif /* CONFIG_NUMA_BALANCING */
807
808 /*
809 * Tracepoint for waking a polling cpu without an IPI.
810 */
811 TRACE_EVENT(sched_wake_idle_without_ipi,
812
813 TP_PROTO(int cpu),
814
815 TP_ARGS(cpu),
816
817 TP_STRUCT__entry(
818 __field( int, cpu )
819 ),
820
821 TP_fast_assign(
822 __entry->cpu = cpu;
823 ),
824
825 TP_printk("cpu=%d", __entry->cpu)
826 );
827
828 /*
829 * Following tracepoints are not exported in tracefs and provide hooking
830 * mechanisms only for testing and debugging purposes.
831 */
832 DECLARE_TRACE(pelt_cfs,
833 TP_PROTO(struct cfs_rq *cfs_rq),
834 TP_ARGS(cfs_rq));
835
836 DECLARE_TRACE(pelt_rt,
837 TP_PROTO(struct rq *rq),
838 TP_ARGS(rq));
839
840 DECLARE_TRACE(pelt_dl,
841 TP_PROTO(struct rq *rq),
842 TP_ARGS(rq));
843
844 DECLARE_TRACE(pelt_hw,
845 TP_PROTO(struct rq *rq),
846 TP_ARGS(rq));
847
848 DECLARE_TRACE(pelt_irq,
849 TP_PROTO(struct rq *rq),
850 TP_ARGS(rq));
851
852 DECLARE_TRACE(pelt_se,
853 TP_PROTO(struct sched_entity *se),
854 TP_ARGS(se));
855
856 DECLARE_TRACE(sched_cpu_capacity,
857 TP_PROTO(struct rq *rq),
858 TP_ARGS(rq));
859
860 DECLARE_TRACE(sched_overutilized,
861 TP_PROTO(struct root_domain *rd, bool overutilized),
862 TP_ARGS(rd, overutilized));
863
864 DECLARE_TRACE(sched_util_est_cfs,
865 TP_PROTO(struct cfs_rq *cfs_rq),
866 TP_ARGS(cfs_rq));
867
868 DECLARE_TRACE(sched_util_est_se,
869 TP_PROTO(struct sched_entity *se),
870 TP_ARGS(se));
871
872 DECLARE_TRACE(sched_update_nr_running,
873 TP_PROTO(struct rq *rq, int change),
874 TP_ARGS(rq, change));
875
876 DECLARE_TRACE(sched_compute_energy,
877 TP_PROTO(struct task_struct *p, int dst_cpu, unsigned long energy,
878 unsigned long max_util, unsigned long busy_time),
879 TP_ARGS(p, dst_cpu, energy, max_util, busy_time));
880
881 DECLARE_TRACE(sched_entry,
882 TP_PROTO(bool preempt),
883 TP_ARGS(preempt));
884
885 DECLARE_TRACE(sched_exit,
886 TP_PROTO(bool is_switch),
887 TP_ARGS(is_switch));
888
889 DECLARE_TRACE_CONDITION(sched_set_state,
890 TP_PROTO(struct task_struct *tsk, int state),
891 TP_ARGS(tsk, state),
892 TP_CONDITION(!!(tsk->__state) != !!state));
893
894 DECLARE_TRACE(sched_set_need_resched,
895 TP_PROTO(struct task_struct *tsk, int cpu, int tif),
896 TP_ARGS(tsk, cpu, tif));
897
898 #endif /* _TRACE_SCHED_H */
899
900 /* This part must be outside protection */
> 901 #include <trace/define_trace.h>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-08-11 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 6:46 [PATCH v7 0/4] Add support for long task name Bhupesh
2025-08-11 6:46 ` [PATCH v7 1/4] exec: Remove obsolete comments Bhupesh
2025-08-11 6:46 ` [PATCH v7 2/4] include: Set tsk->comm length to 64 bytes Bhupesh
2025-08-11 15:10 ` Andy Shevchenko
2025-08-13 10:29 ` Bhupesh Sharma
2025-08-11 6:46 ` [PATCH v7 3/4] treewide: Replace 'get_task_comm()' with 'strscpy_pad()' Bhupesh
2025-08-11 11:25 ` kernel test robot
2025-08-11 14:49 ` Bhupesh Sharma
2025-08-11 14:58 ` Andy Shevchenko
2025-08-13 10:26 ` Bhupesh Sharma
2025-08-11 15:05 ` Andy Shevchenko
2025-08-13 10:27 ` Bhupesh Sharma
2025-08-12 3:47 ` kernel test robot
2025-08-11 6:46 ` [PATCH v7 4/4] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation Bhupesh
2025-08-11 15:08 ` Andy Shevchenko
2025-08-11 16:37 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508120011.j4Pmr6Rf-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=bhupesh@igalia.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-dev@igalia.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.