From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] misc: rtsx: usb card reader: add OCP support
Date: Tue, 12 Aug 2025 01:00:46 +0800 [thread overview]
Message-ID: <202508120033.mgYsS7v2-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250805032220.2355160-1-ricky_wu@realtek.com>
References: <20250805032220.2355160-1-ricky_wu@realtek.com>
TO: Ricky Wu <ricky_wu@realtek.com>
TO: linux-kernel@vger.kernel.org
TO: linux-mmc@vger.kernel.org
TO: arnd@arndb.de
TO: gregkh@linuxfoundation.org
TO: chenhuacai@kernel.org
TO: ricky_wu@realtek.com
TO: ulf.hansson@linaro.org
TO: maximlevitsky@gmail.com
Hi Ricky,
kernel test robot noticed the following build warnings:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.17-rc1 next-20250808]
[cannot apply to soc/for-next ulf-hansson-mmc-mirror/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ricky-Wu/misc-rtsx-usb-card-reader-add-OCP-support/20250806-101802
base: char-misc/char-misc-testing
patch link: https://lore.kernel.org/r/20250805032220.2355160-1-ricky_wu%40realtek.com
patch subject: [PATCH] misc: rtsx: usb card reader: add OCP support
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: i386-randconfig-141-20250811 (https://download.01.org/0day-ci/archive/20250812/202508120033.mgYsS7v2-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202508120033.mgYsS7v2-lkp@intel.com/
smatch warnings:
drivers/mmc/host/rtsx_usb_sdmmc.c:1056 sd_set_power_mode() error: uninitialized symbol 'err'.
vim +/err +1056 drivers/mmc/host/rtsx_usb_sdmmc.c
c7f6558d84afe6 Roger Tseng 2014-04-11 1034
55131d685ebee4 Ulf Hansson 2025-06-10 1035 static void sd_set_power_mode(struct rtsx_usb_sdmmc *host,
c7f6558d84afe6 Roger Tseng 2014-04-11 1036 unsigned char power_mode)
c7f6558d84afe6 Roger Tseng 2014-04-11 1037 {
c7f6558d84afe6 Roger Tseng 2014-04-11 1038 int err;
9939ac6ca0f5d5 Ricky Wu 2025-06-16 1039 struct rtsx_ucr *ucr = host->ucr;
c7f6558d84afe6 Roger Tseng 2014-04-11 1040
c7f6558d84afe6 Roger Tseng 2014-04-11 1041 if (power_mode == host->power_mode)
55131d685ebee4 Ulf Hansson 2025-06-10 1042 return;
c7f6558d84afe6 Roger Tseng 2014-04-11 1043
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1044 switch (power_mode) {
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1045 case MMC_POWER_OFF:
c7f6558d84afe6 Roger Tseng 2014-04-11 1046 err = sd_power_off(host);
f12b55b9782017 Ulf Hansson 2025-06-10 1047 if (err)
f12b55b9782017 Ulf Hansson 2025-06-10 1048 dev_dbg(sdmmc_dev(host), "power-off (err = %d)\n", err);
f275179f7bdcf0 Ulf Hansson 2018-05-31 1049 pm_runtime_put_noidle(sdmmc_dev(host));
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1050 break;
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1051
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1052 case MMC_POWER_UP:
f275179f7bdcf0 Ulf Hansson 2018-05-31 1053 pm_runtime_get_noresume(sdmmc_dev(host));
5bd9223f706cd9 Ricky Wu 2025-08-05 1054 if (!(host->ocp_stat & (MS_OCP_NOW | MS_OCP_EVER)))
c7f6558d84afe6 Roger Tseng 2014-04-11 1055 err = sd_power_on(host);
f12b55b9782017 Ulf Hansson 2025-06-10 @1056 if (err)
f12b55b9782017 Ulf Hansson 2025-06-10 1057 dev_dbg(sdmmc_dev(host), "power-on (err = %d)\n", err);
9939ac6ca0f5d5 Ricky Wu 2025-06-16 1058 /* issue the clock signals to card at least 74 clocks */
9939ac6ca0f5d5 Ricky Wu 2025-06-16 1059 rtsx_usb_write_register(ucr, SD_BUS_STAT, SD_CLK_TOGGLE_EN, SD_CLK_TOGGLE_EN);
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1060 break;
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1061
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1062 case MMC_POWER_ON:
9939ac6ca0f5d5 Ricky Wu 2025-06-16 1063 /* stop to send the clock signals */
9939ac6ca0f5d5 Ricky Wu 2025-06-16 1064 rtsx_usb_write_register(ucr, SD_BUS_STAT, SD_CLK_TOGGLE_EN, 0x00);
3ab659eb696f0a Nathan Chancellor 2025-06-20 1065 break;
3ab659eb696f0a Nathan Chancellor 2025-06-20 1066
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1067 case MMC_POWER_UNDEFINED:
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1068 break;
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1069
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1070 default:
f9a1a9448f5c12 Ulf Hansson 2025-06-10 1071 break;
c7f6558d84afe6 Roger Tseng 2014-04-11 1072 }
c7f6558d84afe6 Roger Tseng 2014-04-11 1073
c7f6558d84afe6 Roger Tseng 2014-04-11 1074 host->power_mode = power_mode;
c7f6558d84afe6 Roger Tseng 2014-04-11 1075 }
c7f6558d84afe6 Roger Tseng 2014-04-11 1076
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-08-11 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 17:00 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-08-05 3:22 [PATCH] misc: rtsx: usb card reader: add OCP support Ricky Wu
2025-08-06 10:24 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508120033.mgYsS7v2-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.