From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A432E7641 for ; Tue, 12 Aug 2025 09:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754989454; cv=none; b=JK6c8ixgD0HcwEcHp2WUTboj+oyYtr61O8bBAP9WlH06QMt9yUXTPkIKaRIF92KxOhvMdovodi0akVPxzb3mBCa1QRwSOOQotU7xjv3+me2xKDO74nOvjrr957X+guTcEJ2xUg5rRmxxh/tbYy1EnlKzrCpcfrj1f6PqURukEJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754989454; c=relaxed/simple; bh=jX+YEQB0b2jg/94uudyOzj3RkscIhZDeVVogCJzZ67M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UrLdkxRXWyZ3aR7vCIaJlEY9mpUMMXrmCBgoe3/sPPsV0cS/NKeJ9jhJm4vcJlV3vy1ISML6r3B3My7vnbgwypMVrmk1awJub7N5eXhMZ3eNIxwld+DmqKS2oDcw0bmAFzmXEn7yD4rcisLBHNFYUn6zOnsd/TGgotbNBV7ASs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=Jl5Y9VlQ; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="Jl5Y9VlQ" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-459ea4f40afso9381505e9.2 for ; Tue, 12 Aug 2025 02:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1754989451; x=1755594251; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DkDi9sQ4u1Zsf5AcaPzYnSO2sPwb0elGC7q2l8b77oI=; b=Jl5Y9VlQtRQgQ0wZapz6JmbwaoLFP6lFy1uOBPSW6zPTVaSiKkYXXB5/Yhgdk1f51I aGHyOg6b4cD8a3Kr7Ltqg58lvN+v4yVURDZMvVqtbPkIaw3tKOPS79iH014g3A5A0JkP Wxlpf89JlXrZlcWb8ktgo63426JPiVwEdADeP2uBM7vGnck3b1cZCsZme+0fdyfH0amo 4TJtqmOuYApTj/a32MhsDZ6q9cKshyt/wnYvQlLGX42XnybAOXYgbsRvjsQPwNYum9TN OsFDUVTpnM5jppqVIzV4necufmbZruyzAhpGOmYdU+A3roIz1SWpvAEgdYX+XbURfzjB HqCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754989451; x=1755594251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DkDi9sQ4u1Zsf5AcaPzYnSO2sPwb0elGC7q2l8b77oI=; b=Y3NaGcNBHc5VQ1DXTsZJARsdt0lXsCqzLImvIepa7LguFfpLN44egR7q2luFl79zAJ 9KKw4CANYtsF3STaqb9BulrA3HANCed656XShsOxxwDqNWf0DPw/lXKdnlz3b/fyJp5x WhnQNtxM4j3ASXR6NPUfaXWHxRzOAD0f3pdk7MX2YDx8ed6uidep3HkFWnoJER5awhiD QOHNDMxNFQM/HyCANyA4OS2THbLeLL2HhPsVBMoLd7BFG2t4wyDtN3cXIqKHHoMUr68A uYjlTYL5Y15wrYVeepz1A7ebBTO5fzl+H5PU2Z9Znu/1JjSE+NykpIZdIxGO4Ch8yIdQ ultg== X-Gm-Message-State: AOJu0YzX519lN+yCZGuoJFPuzZl6K92AOCTEUiLh55VwV/AJ8YLBXanH OQaTxMO2iHPLt9BKeoFIabduyE8UVvFW3v3DRqJtuj56QC2Tt/4liL7DL9eqtZx1ZpZSo0exdgn a17KM X-Gm-Gg: ASbGncsPRL8NWqMGyljIQ7fN5Ujt0BxZ6UQE5JSi92/yf8gIvf1fuecLK7r/U8bNHvp Ho1dBDKhij3346goRqYWEH1PSMr5CL+HBisZVJZpRA2P3zSyXTGcIhLwhIWCGOZIvPooOChmRHq EJLknvbxBq9NJc1RYNxxj8emFLFfYEwgQKIoeihIgtwDTEiiLx2jVXs/d6s4qD2sCuiLXvLT2MS oyEgBtorB1/dDZMtadeEmdXH+ANNP6bixM7yZiFruSRozsPY5DP/BSlEs7IWVDgatYe48/02QJY 8w1vME6cLBPCZgUsHJGUKYLobsWSyQNoGfqlRJJiloLWx7ZpWWEcDMew1Sq194Y03gxwdvG0mm5 PIp7n1EhA25K0JhnbKROutx95guvAtQ== X-Google-Smtp-Source: AGHT+IFBefRRbVz8mjWqcsAPH9QQgYekCVsZTS4QORs3XTzsM/mOl+JX5+dSUj2YaHIFPPZ1EW6gKQ== X-Received: by 2002:a05:600c:608c:b0:458:a753:f3a1 with SMTP id 5b1f17b1804b1-45a1404e5b0mr2724695e9.3.1754989450650; Tue, 12 Aug 2025 02:04:10 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:8113:2b11:8f42:672f]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45a053a9019sm104340625e9.21.2025.08.12.02.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 02:04:10 -0700 (PDT) From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= To: bpf@vger.kernel.org Cc: stable@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Pu Lehui , Puranjay Mohan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Kumar Kartikeya Dwivedi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] riscv, bpf: use lw when reading int cpu in bpf_get_smp_processor_id Date: Tue, 12 Aug 2025 11:02:56 +0200 Message-ID: <20250812090256.757273-4-rkrcmar@ventanamicro.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250812090256.757273-2-rkrcmar@ventanamicro.com> References: <20250812090256.757273-2-rkrcmar@ventanamicro.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit emit_ld is wrong, because thread_info.cpu is 32-bit, not xlen-bit wide. The struct currently has a hole after cpu, so little endian accesses seemed fine. Fixes: 2ddec2c80b44 ("riscv, bpf: inline bpf_get_smp_processor_id()") Cc: Signed-off-by: Radim Krčmář --- arch/riscv/net/bpf_jit_comp64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/net/bpf_jit_comp64.c b/arch/riscv/net/bpf_jit_comp64.c index 6e1554d89681..9883a55d61b5 100644 --- a/arch/riscv/net/bpf_jit_comp64.c +++ b/arch/riscv/net/bpf_jit_comp64.c @@ -1763,7 +1763,7 @@ int bpf_jit_emit_insn(const struct bpf_insn *insn, struct rv_jit_context *ctx, */ if (insn->src_reg == 0 && insn->imm == BPF_FUNC_get_smp_processor_id) { /* Load current CPU number in R0 */ - emit_ld(bpf_to_rv_reg(BPF_REG_0, ctx), offsetof(struct thread_info, cpu), + emit_lw(bpf_to_rv_reg(BPF_REG_0, ctx), offsetof(struct thread_info, cpu), RV_REG_TP, ctx); break; } -- 2.50.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A906CA0EC4 for ; Tue, 12 Aug 2025 12:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1VlHPW9iD9vcwAXIskB5W9KNMxbi24ztppd7agGWHnc=; b=bVGNRFrv/X/dCg y6un8DiUAxqMbrJotS8SBLNBC8n/gliyR3ljWVolJcEePo/jn+HEVdXg54xDRN9X9R06uWp9ed4n2 +XpCmcfnLPzxpHJ7AkNmNM/oPMqMYv8Tz6Kpixa4a/ekddgL7q+9Ybq6LLuEaLAvxCLs5Ny0xlteg 79GKtjxmC7g9M2S5rHIOQvG/y2c98AyE7iKqiGtx1XRVEOf7s0/vk0LkYo8wKB1Cwn736bfUJKAJN 7zTKrpfEBSYm1SEk/WM3qemzILHDcuEa46jdf0nHV5dZSmuD2dSTcBnPsH5ObJKlUwkiSC4YICokb UyXT6LvBzBa+roAOAOLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uloHz-0000000Am6A-1Iri; Tue, 12 Aug 2025 12:39:39 +0000 Received: from mail-wm1-f45.google.com ([209.85.128.45]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulkvU-0000000AKER-2Ffm for linux-riscv@lists.infradead.org; Tue, 12 Aug 2025 09:04:13 +0000 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-459ddb41887so6766615e9.0 for ; Tue, 12 Aug 2025 02:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1754989451; x=1755594251; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DkDi9sQ4u1Zsf5AcaPzYnSO2sPwb0elGC7q2l8b77oI=; b=XMJ4X71GIBB7gEJ9WvoblSzPo51mq2BjlFMRL/8Bsa9ka+n2xHa9C1ry4+y84Qw1Tn ZFQ3eUfx1M/M46Ti7fx7fmgeqvHCYOsxbiqAgf5139ou3cPj2R7/q/6iRzKS+RbQGN/J hGNlKYOaxvG4XT/1f0oju3/k4r9zGh30urrrccvVD59f6sIAVF7b0qpymde6xDhTFdlN ucP1BNDAuOAbx+/rSS12bSvZhbcYGPHDgap447P2MH1fgqtolnsOYvUMx6aD8Tsy9R9T PKA20sxhqQIWvyo4Mb2Sw0W0HSQhhvzlps9WU+rli6lN9Vlr/O6Zv41clOqc0u7ZnNLY /S4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754989451; x=1755594251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DkDi9sQ4u1Zsf5AcaPzYnSO2sPwb0elGC7q2l8b77oI=; b=uP3Tk4gOfOaB30EedHM0dDqwq0+LH7hJy+KIx8KLCiqKvZn7bNs3HLknlqYjBg9fFy 5wjLh597wbbbaCndaNg/Ei7CYVz65ZOGzYio5Dypg4AaiLfk8DEqukce8x9zKZq3CNH0 vEPo/EQunBZIqA4vetMbnGp9NW8tFsQEaAuU25uOBr4N73KkXLVqE8S55vvkupDelEIL QyibAum/w19hjB1Ouhco5dYXXKHJSaSubB2dBd90peFentj0t1EiLgvvmw4ZEvvhBxcU Hn3SqZdk4Cdkat0SLt0aLAhz7tG51aktb3nEBx4/jFTK/U+UjVKQELRxnaJbtVq35TAz pPzg== X-Forwarded-Encrypted: i=1; AJvYcCUlUOLerCyglNY/73X1Zi98Q62RDA3L2pRwttnsvYunnC6lzogrtRXVxG3cgSCSulf80UTdoIkoSW8uBg==@lists.infradead.org X-Gm-Message-State: AOJu0YypPYD1DdF0js0C2W/VT8TcOtTyodQZT0YGwu5mmUI7XwLOq2pq Ot5grb9nYpKWAib9SqCyCbZ+a3OyzZDbqMDU90b2oWnEhSyDIjtO0PwvsmAjSRDuEkw= X-Gm-Gg: ASbGnct6TUK6DzEVe7e3EUVFDNMa6eegvg+dkaHer3E+0B4RsZGrjgOuZjYujqFGnKY RNg4bZNL8BaMwG1RbAdLD4Ggb3FskYDBd3loubwn6VWsczELQJqZcuAXSdx3Kyh2SaICKSmJAjM z5DUNw5kBD7hoGzZNxlfYVelJFauuQYeUYN7MKk7Ex+x0sOgHxxJOLQTIUzURAGjXsr/QaWK5Jg dkDYIifYxmNfizkxswu/E2QaG4EdAofRGdlEJ+ZI9QzxMrfurMcGrBwI1994p3Q/03UFxbevmSK fJS78aiAIP2qSe4Ay2W4c5wGaM4UwpCd/86vra5Ltg5qPnAClrQQ20vo8k85+jz37jDYYXsOti5 +hAQRcFWsSWO+Bf6wXv1Dty/HCFhAFw== X-Google-Smtp-Source: AGHT+IFBefRRbVz8mjWqcsAPH9QQgYekCVsZTS4QORs3XTzsM/mOl+JX5+dSUj2YaHIFPPZ1EW6gKQ== X-Received: by 2002:a05:600c:608c:b0:458:a753:f3a1 with SMTP id 5b1f17b1804b1-45a1404e5b0mr2724695e9.3.1754989450650; Tue, 12 Aug 2025 02:04:10 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:8113:2b11:8f42:672f]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45a053a9019sm104340625e9.21.2025.08.12.02.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 02:04:10 -0700 (PDT) From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= To: bpf@vger.kernel.org Cc: stable@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Pu Lehui , Puranjay Mohan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Kumar Kartikeya Dwivedi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] riscv, bpf: use lw when reading int cpu in bpf_get_smp_processor_id Date: Tue, 12 Aug 2025 11:02:56 +0200 Message-ID: <20250812090256.757273-4-rkrcmar@ventanamicro.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250812090256.757273-2-rkrcmar@ventanamicro.com> References: <20250812090256.757273-2-rkrcmar@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250812_020412_778706_A3ED8A58 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org ZW1pdF9sZCBpcyB3cm9uZywgYmVjYXVzZSB0aHJlYWRfaW5mby5jcHUgaXMgMzItYml0LCBub3Qg eGxlbi1iaXQgd2lkZS4KVGhlIHN0cnVjdCBjdXJyZW50bHkgaGFzIGEgaG9sZSBhZnRlciBjcHUs IHNvIGxpdHRsZSBlbmRpYW4gYWNjZXNzZXMKc2VlbWVkIGZpbmUuCgpGaXhlczogMmRkZWMyYzgw YjQ0ICgicmlzY3YsIGJwZjogaW5saW5lIGJwZl9nZXRfc21wX3Byb2Nlc3Nvcl9pZCgpIikKQ2M6 IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgpTaWduZWQtb2ZmLWJ5OiBSYWRpbSBLcsSNbcOhxZkg PHJrcmNtYXJAdmVudGFuYW1pY3JvLmNvbT4KLS0tCiBhcmNoL3Jpc2N2L25ldC9icGZfaml0X2Nv bXA2NC5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u KC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC9yaXNjdi9uZXQvYnBmX2ppdF9jb21wNjQuYyBiL2FyY2gv cmlzY3YvbmV0L2JwZl9qaXRfY29tcDY0LmMKaW5kZXggNmUxNTU0ZDg5NjgxLi45ODgzYTU1ZDYx YjUgMTAwNjQ0Ci0tLSBhL2FyY2gvcmlzY3YvbmV0L2JwZl9qaXRfY29tcDY0LmMKKysrIGIvYXJj aC9yaXNjdi9uZXQvYnBmX2ppdF9jb21wNjQuYwpAQCAtMTc2Myw3ICsxNzYzLDcgQEAgaW50IGJw Zl9qaXRfZW1pdF9pbnNuKGNvbnN0IHN0cnVjdCBicGZfaW5zbiAqaW5zbiwgc3RydWN0IHJ2X2pp dF9jb250ZXh0ICpjdHgsCiAJCSAqLwogCQlpZiAoaW5zbi0+c3JjX3JlZyA9PSAwICYmIGluc24t PmltbSA9PSBCUEZfRlVOQ19nZXRfc21wX3Byb2Nlc3Nvcl9pZCkgewogCQkJLyogTG9hZCBjdXJy ZW50IENQVSBudW1iZXIgaW4gUjAgKi8KLQkJCWVtaXRfbGQoYnBmX3RvX3J2X3JlZyhCUEZfUkVH XzAsIGN0eCksIG9mZnNldG9mKHN0cnVjdCB0aHJlYWRfaW5mbywgY3B1KSwKKwkJCWVtaXRfbHco YnBmX3RvX3J2X3JlZyhCUEZfUkVHXzAsIGN0eCksIG9mZnNldG9mKHN0cnVjdCB0aHJlYWRfaW5m bywgY3B1KSwKIAkJCQlSVl9SRUdfVFAsIGN0eCk7CiAJCQlicmVhazsKIAkJfQotLSAKMi41MC4w CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt cmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=