Re: [PATCH v5 1/5] cxl: Move hpa_to_spa callback to a new root decoder ops structure

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Mon,  4 Aug 2025 01:00:09 -0700
alison.schofield@intel.com wrote:

> From: Dave Jiang <dave.jiang@intel.com>
> 
> The root decoder's HPA to SPA translation logic was implemented using
> a single function pointer. In preparation for additional per-decoder
> callbacks, convert this into a struct cxl_rd_ops and move the
> hpa_to_spa pointer into it.
> 
> To avoid maintaining a static ops instance populated with mostly NULL
> pointers, allocate the ops structure dynamically only when a platform
> requires overrides (e.g. XOR interleave decoding).
> 
> The setup can be extended as additional callbacks are added.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Co-developed-by: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
One trivial thing inline.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

> ---
> 
> Changes in v5: Remove stray blank line in cxl_root_decoder_alloc() (DaveJ)
> 
> 
>  drivers/cxl/acpi.c        | 10 +++++++---
>  drivers/cxl/core/port.c   |  1 +
>  drivers/cxl/core/region.c | 11 ++++++++---
>  drivers/cxl/cxl.h         | 12 +++++++++---
>  4 files changed, 25 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index 712624cba2b6..b8d69460a368 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -20,7 +20,6 @@ static const guid_t acpi_cxl_qtg_id_guid =
>  	GUID_INIT(0xF365F9A6, 0xA7DE, 0x4071,
>  		  0xA6, 0x6A, 0xB4, 0x0C, 0x0B, 0x4F, 0x8E, 0x52);
>  
> -

Valid but unrelated change.

>  static u64 cxl_xor_hpa_to_spa(struct cxl_root_decoder *cxlrd, u64 hpa)