From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03D672FDC22; Tue, 12 Aug 2025 17:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020309; cv=none; b=DtW6G6ntTU5HllEnoDgWDQFA9rf1O9++ZeURLNvfi961UZpH34fM+udHlIC1gLe4u+rYfJqSOpocjNZr4i7XTt2z1RqmDL2Lo0yQVScoVOvfzLnOi0mmL2r5akDS2p+1xrMJ0bIw/iiuJa3uzX0XLgPUHE5ChcznJ+l9VuLYA08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020309; c=relaxed/simple; bh=0AkjYOqqMAUYVIOz2FARR+YdNwzBZtKrbk8mYb/EHrM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C0x20cRnhdkSj4rzfvJxn7Izm9A97m3ZQ4v78MTs6VIVs66HkXCqseuMoJNn9mvV+/9sqTd6nAcn7fq7g7RMrZrVVmEZ1fRW+HDxEGEELcn1Fra6hQuX0SDA6J2Cq1t+aCuIudL9cnPX+htHycl8bBwdcqPA4wSm0pg3ugtqSwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xBLkU/7e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xBLkU/7e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DFD9C4CEF0; Tue, 12 Aug 2025 17:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755020308; bh=0AkjYOqqMAUYVIOz2FARR+YdNwzBZtKrbk8mYb/EHrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xBLkU/7e1ionCTZkdJlsPyJt/zO92dRehnPKuBlrMnV/dfCL4xZ7qIJztConkKy3s EL7ReSytmp+wIvMVnbXGoH5eyB5WJd6Tnq9s/Ckd52TvArMKTjN7ZIvT7ICtn5EPLC g6NmHqZjOBmyJj5Jivyjwrj+Os67uqHFuo7QD0EI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Harry Yoo , David Hildenbrand , Sergey Senozhatsky , Minchan Kim , Andrew Morton Subject: [PATCH 6.1 042/253] mm/zsmalloc: do not pass __GFP_MOVABLE if CONFIG_COMPACTION=n Date: Tue, 12 Aug 2025 19:27:10 +0200 Message-ID: <20250812172950.529778195@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812172948.675299901@linuxfoundation.org> References: <20250812172948.675299901@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Harry Yoo commit 694d6b99923eb05a8fd188be44e26077d19f0e21 upstream. Commit 48b4800a1c6a ("zsmalloc: page migration support") added support for migrating zsmalloc pages using the movable_operations migration framework. However, the commit did not take into account that zsmalloc supports migration only when CONFIG_COMPACTION is enabled. Tracing shows that zsmalloc was still passing the __GFP_MOVABLE flag even when compaction is not supported. This can result in unmovable pages being allocated from movable page blocks (even without stealing page blocks), ZONE_MOVABLE and CMA area. Possible user visible effects: - Some ZONE_MOVABLE memory can be not actually movable - CMA allocation can fail because of this - Increased memory fragmentation due to ignoring the page mobility grouping feature I'm not really sure who uses kernels without compaction support, though :( To fix this, clear the __GFP_MOVABLE flag when !IS_ENABLED(CONFIG_COMPACTION). Link: https://lkml.kernel.org/r/20250704103053.6913-1-harry.yoo@oracle.com Fixes: 48b4800a1c6a ("zsmalloc: page migration support") Signed-off-by: Harry Yoo Acked-by: David Hildenbrand Reviewed-by: Sergey Senozhatsky Cc: Minchan Kim Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- mm/zsmalloc.c | 3 +++ 1 file changed, 3 insertions(+) --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1049,6 +1049,9 @@ static struct zspage *alloc_zspage(struc if (!zspage) return NULL; + if (!IS_ENABLED(CONFIG_COMPACTION)) + gfp &= ~__GFP_MOVABLE; + zspage->magic = ZSPAGE_MAGIC; migrate_lock_init(zspage);