From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Andrew Lunn <andrew+netdev@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: fixed: remove usage of a faux device
Date: Tue, 12 Aug 2025 17:38:10 -0700 [thread overview]
Message-ID: <20250812173810.5603a48a@kernel.org> (raw)
In-Reply-To: <fad5776c-2af2-4511-90c0-6d7c6e955526@gmail.com>
On Mon, 11 Aug 2025 21:45:49 +0200 Heiner Kallweit wrote:
> ret = mdiobus_register(fmb->mii_bus);
> if (ret)
> - goto err_mdiobus_alloc;
> + mdiobus_free(fmb->mii_bus);
>
> - return 0;
> -
> -err_mdiobus_alloc:
> - mdiobus_free(fmb->mii_bus);
> -err_mdiobus_reg:
> - faux_device_destroy(fdev);
> return ret;
> }
nit: would you mind leaving the mdiobus_free() where it is?
Feels a little more idiomatic.
prev parent reply other threads:[~2025-08-13 0:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 19:45 [PATCH net-next] net: phy: fixed: remove usage of a faux device Heiner Kallweit
2025-08-13 0:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812173810.5603a48a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.