All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: trini@konsulko.com
Cc: joe.hershberger@ni.com, otavio@ossystems.com.br,
	u-boot@lists.denx.de, Fabio Estevam <festevam@gmail.com>
Subject: [PATCH 3/3] env: fat: Standardize the interface type check
Date: Tue, 12 Aug 2025 14:46:12 -0300	[thread overview]
Message-ID: <20250812174612.1159634-3-festevam@gmail.com> (raw)
In-Reply-To: <20250812174612.1159634-1-festevam@gmail.com>

Make the interface type check consistent among the other interface types
by checking it agains the ifname string.

The ifname string contains the string returned by env_fat_get_intf(), which
returns the CONFIG_ENV_FAT_INTERFACE value.

No functional change.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 env/fat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/env/fat.c b/env/fat.c
index 412d95dc3057..58c279ff7690 100644
--- a/env/fat.c
+++ b/env/fat.c
@@ -131,7 +131,7 @@ static int env_fat_load(void)
 #endif
 #ifndef CONFIG_XPL_BUILD
 #if defined(CONFIG_AHCI) || defined(CONFIG_SCSI)
-	if (!strcmp(CONFIG_ENV_FAT_INTERFACE, "scsi"))
+	if (!strcmp(ifname, "scsi"))
 		scsi_scan(true);
 #endif
 #if defined(CONFIG_VIRTIO)
-- 
2.34.1


  parent reply	other threads:[~2025-08-12 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 17:46 [PATCH 1/3] env: fat: Add support for NVME Fabio Estevam
2025-08-12 17:46 ` [PATCH 2/3] env: ext4: " Fabio Estevam
2025-08-12 17:46 ` Fabio Estevam [this message]
2025-08-20 23:13 ` [PATCH 1/3] env: fat: " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250812174612.1159634-3-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=joe.hershberger@ni.com \
    --cc=otavio@ossystems.com.br \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.