From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH 7/7] docs: kdoc: remove redundant comment stripping
Date: Wed, 13 Aug 2025 01:19:41 +0200 [thread overview]
Message-ID: <20250813011941.4ca1ee00@foz.lan> (raw)
In-Reply-To: <20250812195748.124402-8-corbet@lwn.net>
On Tue, 12 Aug 2025 13:57:48 -0600
Jonathan Corbet <corbet@lwn.net> wrote:
> By the time stuff gets to create_parameter_list(), comments have long since
> been stripped out, so we do not need to do it again here.
>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> ---
> scripts/lib/kdoc/kdoc_parser.py | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/lib/kdoc/kdoc_parser.py b/scripts/lib/kdoc/kdoc_parser.py
> index ceb38b59fb4c..900c028687cc 100644
> --- a/scripts/lib/kdoc/kdoc_parser.py
> +++ b/scripts/lib/kdoc/kdoc_parser.py
> @@ -493,9 +493,6 @@ class KernelDoc:
> args = arg_expr.sub(r"\1#", args)
>
> for arg in args.split(splitter):
> - # Strip comments
> - arg = KernRe(r'/\*.*\*/').sub('', arg)
> -
> # Ignore argument attributes
> arg = KernRe(r'\sPOS0?\s').sub(' ', arg)
>
Didn't check, but yeah, there are some places already doing
it, so:
Acked-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thanks,
Mauro
prev parent reply other threads:[~2025-08-12 23:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 19:57 [PATCH 0/7] docs: kdoc: tidy up create_parameter_list() somewhat Jonathan Corbet
2025-08-12 19:57 ` [PATCH 1/7] docs: kdoc: remove dead code Jonathan Corbet
2025-08-12 22:43 ` Mauro Carvalho Chehab
2025-08-12 19:57 ` [PATCH 2/7] docs: kdoc: tidy up space removal in create_parameter_list() Jonathan Corbet
2025-08-12 22:44 ` Mauro Carvalho Chehab
2025-08-12 19:57 ` [PATCH 3/7] docs: kdoc: clean up the create_parameter_list() "first arg" logic Jonathan Corbet
2025-08-12 23:17 ` Mauro Carvalho Chehab
2025-08-13 15:46 ` Jonathan Corbet
2025-08-12 19:57 ` [PATCH 4/7] docs: kdoc: add a couple more comments in create_parameter_list() Jonathan Corbet
2025-08-12 22:47 ` Mauro Carvalho Chehab
2025-08-12 19:57 ` [PATCH 5/7] docs: kdoc: tighten up the array-of-pointers case Jonathan Corbet
2025-08-12 22:53 ` Mauro Carvalho Chehab
2025-08-13 15:16 ` Jonathan Corbet
2025-08-12 19:57 ` [PATCH 6/7] docs: kdoc: tighten up the pointer-to-function case Jonathan Corbet
2025-08-12 22:39 ` Mauro Carvalho Chehab
2025-08-12 23:22 ` Jonathan Corbet
2025-08-13 9:02 ` Mauro Carvalho Chehab
2025-08-12 19:57 ` [PATCH 7/7] docs: kdoc: remove redundant comment stripping Jonathan Corbet
2025-08-12 23:19 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813011941.4ca1ee00@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.