From: Jakub Kicinski <kuba@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, aleksander.lobakin@intel.com,
alexanderduyck@fb.com, andrew+netdev@lunn.ch, ast@kernel.org,
bpf@vger.kernel.org, corbet@lwn.net, daniel@iogearbox.net,
davem@davemloft.net, edumazet@google.com, hawk@kernel.org,
horms@kernel.org, john.fastabend@gmail.com, kernel-team@meta.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
pabeni@redhat.com, sdf@fomichev.me, vadim.fedorenko@linux.dev
Subject: Re: [PATCH net-next V3 8/9] eth: fbnic: Collect packet statistics for XDP
Date: Wed, 13 Aug 2025 07:31:17 -0700 [thread overview]
Message-ID: <20250813073117.1bca3a97@kernel.org> (raw)
In-Reply-To: <20250812222252.261779-1-mohsin.bashr@gmail.com>
On Tue, 12 Aug 2025 15:22:52 -0700 Mohsin Bashir wrote:
> + } else if (PTR_ERR(skb) == -FBNIC_XDP_LEN_ERR) {
> + length_errors++;
cocci is complaining about this:
...fbnic_txrx.c:1264:14-21: ERROR: PTR_ERR applied after initialization to constant on line 1250
I think applying PTR_ERR/ERR_PTR to the constant may clean this up.
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-13 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 22:01 [PATCH net-next V3 0/9] eth: fbnic: Add XDP support for fbnic Mohsin Bashir
2025-08-12 22:01 ` [PATCH net-next V3 1/9] eth: fbnic: Add support for HDS configuration Mohsin Bashir
2025-08-12 22:01 ` [PATCH net-next V3 2/9] eth: fbnic: Update Headroom Mohsin Bashir
2025-08-12 22:01 ` [PATCH net-next V3 3/9] eth: fbnic: Use shinfo to track frags state on Rx Mohsin Bashir
2025-08-12 22:01 ` [PATCH net-next V3 4/9] eth: fbnic: Prefetch packet headers " Mohsin Bashir
2025-08-12 22:01 ` [PATCH net-next V3 5/9] eth: fbnic: Add XDP pass, drop, abort support Mohsin Bashir
2025-08-12 22:01 ` [PATCH net-next V3 6/9] eth: fbnic: Add support for XDP queues Mohsin Bashir
2025-08-12 22:21 ` [PATCH net-next V3 7/9] eth: fbnic: Add support for XDP_TX action Mohsin Bashir
2025-08-12 22:22 ` [PATCH net-next V3 8/9] eth: fbnic: Collect packet statistics for XDP Mohsin Bashir
2025-08-13 14:31 ` Jakub Kicinski [this message]
2025-08-12 22:24 ` [PATCH net-next V3 9/9] eth: fbnic: Report XDP stats via ethtool Mohsin Bashir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813073117.1bca3a97@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.