From: Parav Pandit <parav@nvidia.com>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <horms@kernel.org>, <netdev@vger.kernel.org>,
<vadim.fedorenko@linux.dev>
Cc: <jiri@resnulli.us>, Parav Pandit <parav@nvidia.com>
Subject: [PATCH net-next v2 0/2] devlink port attr cleanup
Date: Wed, 13 Aug 2025 12:44:15 +0300 [thread overview]
Message-ID: <20250813094417.7269-1-parav@nvidia.com> (raw)
Hi,
This two small patches simplifies the devlink port attributes set
functions.
Summary:
patch-1 removes the return 0 check at several places and simplfies
patch-2 constifies the attributes and moves the checks early
caller
Please review.
changelog:
v1->v2:
- Addressed comments from Jakub and Vadim
- changed patch order
- replaced dl_port_attrs to attrs that matches implementation API
declaration
Parav Pandit (2):
devlink/port: Simplify return checks
devlink/port: Check attributes early and constify
include/net/devlink.h | 2 +-
net/devlink/port.c | 33 ++++++++-------------------------
2 files changed, 9 insertions(+), 26 deletions(-)
--
2.26.2
next reply other threads:[~2025-08-13 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 9:44 Parav Pandit [this message]
2025-08-13 9:44 ` [PATCH net-next v2 1/2] devlink/port: Simplify return checks Parav Pandit
2025-08-13 9:44 ` [PATCH net-next v2 2/2] devlink/port: Check attributes early and constify Parav Pandit
2025-08-15 0:50 ` [PATCH net-next v2 0/2] devlink port attr cleanup patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813094417.7269-1-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.