From: Jakub Kicinski <kuba@kernel.org>
To: Pengtao He <hept.hept.hept@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Mina Almasry <almasrymina@google.com>,
Jason Xing <kerneljasonxing@gmail.com>,
Michal Luczaj <mhal@rbox.co>, Eric Biggers <ebiggers@google.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH net-next v3] net/core: fix wrong return value in __splice_segment
Date: Wed, 13 Aug 2025 16:27:09 -0700 [thread overview]
Message-ID: <20250813162709.6d876ba4@kernel.org> (raw)
In-Reply-To: <20250811232801.28489-1-hept.hept.hept@gmail.com>
On Tue, 12 Aug 2025 07:28:01 +0800 Pengtao He wrote:
> Return true immediately when the last segment is processed,
> avoid to walking once more in the frags loop.
Please explain this change more clearly in the commit message.
Took me a minute to realize you're concerned about the caller
behavior not __splice_segment() itself.
--
pw-bot: cr
prev parent reply other threads:[~2025-08-13 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 23:28 [RESEND PATCH net-next v3] net/core: fix wrong return value in __splice_segment Pengtao He
2025-08-13 23:27 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813162709.6d876ba4@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=hept.hept.hept@gmail.com \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.