From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>
Cc: <netdev@vger.kernel.org>, <bridge@lists.linux-foundation.org>,
<davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<razor@blackwall.org>, <petrm@nvidia.com>, <horms@kernel.org>
Subject: Re: [PATCH net-next 1/2] bridge: Redirect to backup port when port is administratively down
Date: Wed, 13 Aug 2025 17:20:17 -0700 [thread overview]
Message-ID: <20250813172017.767ad396@kernel.org> (raw)
In-Reply-To: <20250812080213.325298-2-idosch@nvidia.com>
On Tue, 12 Aug 2025 11:02:12 +0300 Ido Schimmel wrote:
> /* redirect to backup link if the destination port is down */
> - if (rcu_access_pointer(to->backup_port) && !netif_carrier_ok(to->dev)) {
> + if (rcu_access_pointer(to->backup_port) &&
> + (!netif_carrier_ok(to->dev) || !netif_running(to->dev))) {
Not really blocking this patch, but I always wondered why we allow
devices with carrier on in admin down state. Is his just something we
have because updating 200 drivers which don't manage carrier today
would be a PITA? Or there's a stronger reason to allow this?
Hopefully I'm not misreading the patch..
next prev parent reply other threads:[~2025-08-14 0:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 8:02 [PATCH net-next 0/2] bridge: Redirect to backup port when port is administratively down Ido Schimmel
2025-08-12 8:02 ` [PATCH net-next 1/2] " Ido Schimmel
2025-08-12 8:27 ` Nikolay Aleksandrov
2025-08-14 0:20 ` Jakub Kicinski [this message]
2025-08-14 8:28 ` Ido Schimmel
2025-08-15 0:48 ` Jakub Kicinski
2025-08-12 8:02 ` [PATCH net-next 2/2] selftests: net: Test bridge " Ido Schimmel
2025-08-12 8:28 ` Nikolay Aleksandrov
2025-08-15 0:50 ` [PATCH net-next 0/2] bridge: Redirect to " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813172017.767ad396@kernel.org \
--to=kuba@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.