Re: [PATCH v2 0/2] media: nxp: imx8-isi: fix streaming cleanup on release

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Wed, Aug 13, 2025 at 11:46:03PM +0200, Richard Leitner wrote:
> Hi Laurent,
> 
> On Thu, Aug 14, 2025 at 12:24:49AM +0300, Laurent Pinchart wrote:
> > Hello,
> > 
> > This patch series fixes an issue initially reported by Richard in [1],
> > with a proposed fix. I've recommended an alternative approach, and gave
> > it a try.
> 
> Thanks for reviewing that patch of mine [1].
> And thank you for providing this alternative approach. It looks way
> cleaner now :-) I previously tought of a similar approach as yours,
> but then opted for the "less invasive" one. So again what learned for
> me. Thanks!
> 
> As I've never had such a situation and wasn't able to find something in
> the docs [2] about it: Do you need/want a Reviewed or Tested-By tag on
> patch 1/2 of this series? (Altough there's also a SoB from me before
> your Co-Developed tag)

Both tags are useful. Even if you're listes as the patch author, I've
made modifications, so your review and tests are valuable.

> [2] https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> 
> regards;rl
> 
> > 
> > Patch 1/2 fixes streaming cleanup on release. Patch 2/2 then cleans up
> > the driver a bit by dropping an unneeded structure field.
> > 
> > The changes have been tested by opening and closing the video device
> > while streaming in another process. I have also tested suspend/resume
> > during streaming.
> > 
> > [1] https://lore.kernel.org/linux-media/20250709-imx8-isi-release-fix-v1-1-c47c659ce1a6@linux.dev/
> > 
> > Laurent Pinchart (1):
> >   media: nxp: imx8-isi: Drop mxc_isi_video.is_streaming field
> > 
> > Richard Leitner (1):
> >   media: nxp: imx8-isi: Fix streaming cleanup on release
> > 
> >  .../platform/nxp/imx8-isi/imx8-isi-core.h     |   3 +-
> >  .../platform/nxp/imx8-isi/imx8-isi-video.c    | 156 +++++++-----------
> >  2 files changed, 57 insertions(+), 102 deletions(-)
> > 
> > 
> > base-commit: 078f1a7eb48eef9b3cb78bcd2254356f3a332358

-- 
Regards,

Laurent Pinchart