From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D052CA0EE0 for ; Thu, 14 Aug 2025 01:38:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1umMuE-00055V-De; Wed, 13 Aug 2025 21:37:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umMu9-00050h-8X for grub-devel@gnu.org; Wed, 13 Aug 2025 21:37:22 -0400 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1umMtz-0007Bg-Dj for grub-devel@gnu.org; Wed, 13 Aug 2025 21:37:20 -0400 Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-3e5700188c5so163965ab.2 for ; Wed, 13 Aug 2025 18:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755135426; x=1755740226; darn=gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QSq1DluxhGuJdHCz8UHBJovQfitqDO0ftgOR0z6jXHw=; b=VrdzpDOs2EKTF0SzAsOuqy783uuO36ooW4apOgYLf2hLvWeuXi9TL3hnz1zisfM2ie i3eI3ELOFXCTuHNC14fQoCP3cyQd3UycxKSb8SkGmB7dJh4eRifK45lUOumbTgLuljz1 O7cFpqK0u/e17l7RInTMksFAxguSj+B0i7LmQrpEm9fL/UV6QJGIA4T22TZKMeK8q6/D ufCrTd5YTzjHRZo3c+nClW3MgrTr46XGUb0Q8ef67o51ztUmYV2xNsQHCJ4qZQ1F+Sxb BGPMpI/tEQB8mLfTdzkq7Z61xAJWkMY0aF8v+/pggfMnjWmQQ/r9mWj73GBvXdTfa7LR 2scw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755135426; x=1755740226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QSq1DluxhGuJdHCz8UHBJovQfitqDO0ftgOR0z6jXHw=; b=viTDN9Cmq/ZKWLlgvMTRFdU8d57cppBdum0UKGNwbRxpM/KgiYSSBUuxFK/wsuDLSj DGMQeXMLKgX71f0ZBEMT3zr0TWPyc9ELOszQiSCYmu0grmKJSoG5ysTukEo0oOC+BPnl e77urlx/3aQhyWrUdVHFdAILsXQPRhT+/T6qGr3joHxvEmePt9x44OHeRGOXAXCsOQSm 6Ebulw5xzcrG0kaauQotbzxG5vIl0iP9y0Svs2RCnjYEuWsjS05opR+0GEhyQQudfxyR mepJi5CC7i2UmC0QGdhPrOp3RLKmCFY6ozjGyBvwUf6mShLJMsKrwKSENRfDWn3wwco2 yyyg== X-Gm-Message-State: AOJu0YwOkrNVRs+AUglKjmCf51AcI1qOOiEIXGK5ykzh611u5CpYzhI6 93k1YLXI1pUxzUwBiLq8TgINOPY3xKN1QBcltF+4HMMm0q/FT4yb8wuMXsUnsoE5 X-Gm-Gg: ASbGncu6jqLlq6FeFGuuZiX947dALDvVplo5SRAROLbYP8O74KD8XVAhGA0Z+GYmlsT IamB7lGoPL7IhBATHN06I81yGT9EueXk3heMSrN3H1U4ay2onamSP/3WUe/zHl+sNx58OLs3ypI SQBvC/g2MuSWXmau8uka0DBmR9aU7j+v4LluiFJ01Wmcm/ct0c9fin5zLNv9e+JldXDAHfWt/8/ qY4MqeXXIRowMcu7VXTKEa1ZUvsVXp60VTNn2D5JEDikVR0cAXYfxKlZsaFFXUMv/JMzAkilZDJ 5a86BtTr+iK4JFtK2XeYuqZw5TnxHGTFa+vOV2jTRLkOdjdtSZctjuRW5NukGMP2v7yCZh8Tktn +3KaxjghG6m6Khxpti5Teow== X-Google-Smtp-Source: AGHT+IFXjpZLwIfry/EvzV7zQJCVKPxqe3UBzCy2m+yVfvZMxryZK8LOfJBC9UMmreq4Du/PO0zpew== X-Received: by 2002:a05:6602:2dc9:b0:85d:9793:e0d8 with SMTP id ca18e2360f4ac-884334e045emr80901939f.0.1755135426238; Wed, 13 Aug 2025 18:37:06 -0700 (PDT) Received: from kf-m2g5.. ([2607:fb91:1183:972:ee53:76c5:e875:9619]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-883f198db02sm467297239f.16.2025.08.13.18.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 18:37:05 -0700 (PDT) From: arraybolt3@gmail.com To: grub-devel@gnu.org, xen-devel@lists.xenproject.org Cc: Aaron Rainbolt Subject: [PATCH v5 2/3] include/xen: Add warning comment for cmd_line Date: Wed, 13 Aug 2025 20:36:44 -0500 Message-ID: <20250814013645.2488043-3-arraybolt3@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250814013645.2488043-1-arraybolt3@gmail.com> References: <20250814013645.2488043-1-arraybolt3@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::131; envelope-from=arraybolt3@gmail.com; helo=mail-il1-x131.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org RnJvbTogQWFyb24gUmFpbmJvbHQgPGFycmF5Ym9sdDNAZ21haWwuY29tPgoKVGhlIGNtZF9saW5l IGZpZWxkIG9mIHRoZSBzdGFydF9pbmZvIHN0cnVjdCBpcyBub3QgZ3VhcmFudGVlZCB0byBiZQpO VUwtdGVybWluYXRlZCwgZXZlbiB0aG91Z2ggaXQgaXMgaW50ZW5kZWQgdG8gY29udGFpbiBhIE5V TC10ZXJtaW5hdGVkCnN0cmluZy4gQWRkIGEgd2FybmluZyBhYm91dCB0aGlzIGluIGEgY29tbWVu dCBzbyBmdXR1cmUgY29uc3VtZXJzIG9mCnRoaXMgZmllbGQga25vdyB0byBjaGVjayBpdCBmb3Ig YSBOVUwgdGVybWluYXRvciBiZWZvcmUgdXNpbmcgaXQuCgpTaWduZWQtb2ZmLWJ5OiBBYXJvbiBS YWluYm9sdCA8YXJyYXlib2x0M0BnbWFpbC5jb20+Ci0tLQogaW5jbHVkZS94ZW4veGVuLmggfCA1 ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvaW5j bHVkZS94ZW4veGVuLmggYi9pbmNsdWRlL3hlbi94ZW4uaAppbmRleCBmZGYwZmM0Li4xNmYzZmQ3 IDEwMDY0NAotLS0gYS9pbmNsdWRlL3hlbi94ZW4uaAorKysgYi9pbmNsdWRlL3hlbi94ZW4uaApA QCAtODIzLDYgKzgyMywxMSBAQCBzdHJ1Y3Qgc3RhcnRfaW5mbyB7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIC8qIChQRk4gb2YgcHJlLWxvYWRlZCBtb2R1bGUgaWYgICAgICAgICAg ICovCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8qICBTSUZfTU9EX1NUQVJUX1BG TiBzZXQgaW4gZmxhZ3MpLiAgICAgICovCiAgICAgdW5zaWduZWQgbG9uZyBtb2RfbGVuOyAgICAg IC8qIFNpemUgKGJ5dGVzKSBvZiBwcmUtbG9hZGVkIG1vZHVsZS4gICAgICovCisgICAgLyogCisg ICAgICogY21kX2xpbmUgd2lsbCBjb250YWluIGEgTlVMLXRlcm1pYW50ZWQgc3RyaW5nIGlmIGl0 IGNvbnRhaW5zIHZhbGlkCisgICAgICogZGF0YSwgYnV0IGl0IE1BWSBiZSBpbnZhbGlkIGFuZCBu b3QgY29udGFpbiBhIE5VTCBieXRlIGF0IGFsbC4gQ29kZQorICAgICAqIHRoYXQgYWNjZXNzZXMg Y21kX2xpbmUgTVVTVCBOT1QgYXNzdW1lIGl0IGlzIE5VTC10ZXJtaW5hdGVkLgorICAgICAqLwog I2RlZmluZSBHUlVCX1hFTl9NQVhfR1VFU1RfQ01ETElORSAxMDI0CiAgICAgaW50OF90IGNtZF9s aW5lW0dSVUJfWEVOX01BWF9HVUVTVF9DTURMSU5FXTsKICAgICAvKiBUaGUgcGZuIHJhbmdlIGhl cmUgY292ZXJzIGJvdGggcGFnZSB0YWJsZSBhbmQgcC0+bSB0YWJsZSBmcmFtZXMuICAgKi8KLS0g CjIuNTAuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkdydWItZGV2ZWwgbWFpbGluZyBsaXN0CkdydWItZGV2ZWxAZ251Lm9yZwpodHRwczovL2xpc3Rz LmdudS5vcmcvbWFpbG1hbi9saXN0aW5mby9ncnViLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CABEBCA0EE0 for ; Thu, 14 Aug 2025 01:37:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1080523.1440899 (Exim 4.92) (envelope-from ) id 1umMtx-0007Nf-DC; Thu, 14 Aug 2025 01:37:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1080523.1440899; Thu, 14 Aug 2025 01:37:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1umMtx-0007NY-AV; Thu, 14 Aug 2025 01:37:09 +0000 Received: by outflank-mailman (input) for mailman id 1080523; Thu, 14 Aug 2025 01:37:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1umMtw-0006vN-52 for xen-devel@lists.xenproject.org; Thu, 14 Aug 2025 01:37:08 +0000 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [2607:f8b0:4864:20::129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3002a262-78af-11f0-a328-13f23c93f187; Thu, 14 Aug 2025 03:37:07 +0200 (CEST) Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-3e56ff95838so346165ab.1 for ; Wed, 13 Aug 2025 18:37:07 -0700 (PDT) Received: from kf-m2g5.. ([2607:fb91:1183:972:ee53:76c5:e875:9619]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-883f198db02sm467297239f.16.2025.08.13.18.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 18:37:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3002a262-78af-11f0-a328-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755135426; x=1755740226; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QSq1DluxhGuJdHCz8UHBJovQfitqDO0ftgOR0z6jXHw=; b=ZacKDZ314n1sjjPayVIst8TYgZmSjwpf0P+4ur05pin4+DN3zUgvxQ2KwfRNe232T3 yUs2xcv7xcQmQojkQBkCsqEuyGAwLWpqd3eQaHwNI+Np12skSt4jbtP9uXggSkzR2/CT RCnbrNPWRVZihfI/CWJaxT9w+PhWLgTaO9b062Xn2VAyLTXY1zaEv4IX4xqmGkjT9FnN 5mG3AXdv3+cITqV3UasWJDAJnQDs1U02dU2TcDI6Uni03YA+kh0tTFheK8auZcqIbwnb hb9dGZgbYsZ01CEkDIHu9DAgj2Jniye9FtAWIhw6z58wA+n1OQVFVUGMC8ZG4j2YpJye XHhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755135426; x=1755740226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QSq1DluxhGuJdHCz8UHBJovQfitqDO0ftgOR0z6jXHw=; b=sW5ytnuC+t7uFwKk+AM2UDnCNe2grEl5rqqswZE3qUuJi4G39yb+DV5Pahev8Wg0Jq xvQbsp5WHceQKNFMQIRil09Ojq+izrWf+t6NMWccemJOsMlSpx42exgASCZINuidUfD4 msPQnrI3MDfcyOgIpMRP83zOb3AOhkQoNdEQ+cmsinOTd6g3dwXaBXeBpa8ETNB3V1Hc NCZuSeNVqOwNf5GL8Pxui3EIrlDVeFnCV3AmXGDTYJAkQSj1dWpew71AM3SKwOQqy3ay Dr2YJlc3BU8skGmhbz83ex6JtghKjGASYUEdF1cY9YwrlsY+syg4pVjfPaBdVONFGM5g uG2A== X-Forwarded-Encrypted: i=1; AJvYcCV/o0OpL9t/PecLiuT2l8gpJtwTTFDS57RF+frksVlCc8xt5EnjNv37dhEFeGfrJf8PwatMBxAsZZA=@lists.xenproject.org X-Gm-Message-State: AOJu0YwOkpHZhpMFlE9XLHqOE5JfAXOu1It2KUG9H9cDrVPUkCFHbspN 3GQCcw2BC+Ce4hAq87s5YXznKPa85iM7xl7Np/9L74c7BzQK9GA8mEJ9 X-Gm-Gg: ASbGncujX46dNYes+AsSfFstaiPkG1mYNyVUI60Rl43mUgeO9syNsBjhV1I1GhTVUZL 4/JMuti+1bmuHvWwTLS/Lyrwvw6zFgxsFGzy8nC5p79i7mPrWLcujAMZ63wIBD1e+ntw3Qxm1Bi r2CsVPDowSKopwWsGHttiE6cjHRSNbPrN2hhCrxrHbXqWyHM6NbCxyMBacCeLOjFQwsyE3N7bjz VTQeus9jfjFz9XdgKbf/YdFLOdSnRaqoc86dCqlTyyHI2umI6Pu/Vvo6tKgiv6CiQR/FKzg7Cri fO/hXs6GhhpSeVXQPZJjy4jK9gT2kW8+50eD1bTouG4Tan8HVHGkFQi9TRk/ZQLeaoBzI0w+7/S ncwWzmW3kD2g7oabbO2BTSw== X-Google-Smtp-Source: AGHT+IFXjpZLwIfry/EvzV7zQJCVKPxqe3UBzCy2m+yVfvZMxryZK8LOfJBC9UMmreq4Du/PO0zpew== X-Received: by 2002:a05:6602:2dc9:b0:85d:9793:e0d8 with SMTP id ca18e2360f4ac-884334e045emr80901939f.0.1755135426238; Wed, 13 Aug 2025 18:37:06 -0700 (PDT) From: arraybolt3@gmail.com To: grub-devel@gnu.org, xen-devel@lists.xenproject.org Cc: Aaron Rainbolt Subject: [PATCH v5 2/3] include/xen: Add warning comment for cmd_line Date: Wed, 13 Aug 2025 20:36:44 -0500 Message-ID: <20250814013645.2488043-3-arraybolt3@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250814013645.2488043-1-arraybolt3@gmail.com> References: <20250814013645.2488043-1-arraybolt3@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Aaron Rainbolt The cmd_line field of the start_info struct is not guaranteed to be NUL-terminated, even though it is intended to contain a NUL-terminated string. Add a warning about this in a comment so future consumers of this field know to check it for a NUL terminator before using it. Signed-off-by: Aaron Rainbolt --- include/xen/xen.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/xen/xen.h b/include/xen/xen.h index fdf0fc4..16f3fd7 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -823,6 +823,11 @@ struct start_info { /* (PFN of pre-loaded module if */ /* SIF_MOD_START_PFN set in flags). */ unsigned long mod_len; /* Size (bytes) of pre-loaded module. */ + /* + * cmd_line will contain a NUL-termianted string if it contains valid + * data, but it MAY be invalid and not contain a NUL byte at all. Code + * that accesses cmd_line MUST NOT assume it is NUL-terminated. + */ #define GRUB_XEN_MAX_GUEST_CMDLINE 1024 int8_t cmd_line[GRUB_XEN_MAX_GUEST_CMDLINE]; /* The pfn range here covers both page table and p->m table frames. */ -- 2.50.1