From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Lukas Wunner <lukas@wunner.de>,
Mika Westerberg <westeri@kernel.org>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
linux-usb@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Use is_pciehp instead of is_hotplug_bridge
Date: Thu, 14 Aug 2025 06:37:52 +0200 [thread overview]
Message-ID: <20250814043752.GB476609@black.igk.intel.com> (raw)
In-Reply-To: <20250813172552.GA279834@bhelgaas>
On Wed, Aug 13, 2025 at 12:25:52PM -0500, Bjorn Helgaas wrote:
> On Tue, Aug 12, 2025 at 03:42:29PM +0200, Lukas Wunner wrote:
> > The thunderbolt driver sets up device link dependencies from hotplug ports
> > to the Host Router (aka Native Host Interface, NHI). When resuming from
> > system sleep, this allows the Host Router to re-establish tunnels to
> > attached Thunderbolt devices before the hotplug ports resume.
> >
> > To identify the hotplug ports, the driver utilizes the is_hotplug_bridge
> > flag which also encompasses ACPI slots handled by the ACPI hotplug driver.
> >
> > Thunderbolt hotplug ports are always Hot-Plug Capable PCIe ports, so it is
> > more apt to identify them with the is_pciehp flag.
> >
> > Similarly, hotplug ports on older Thunderbolt controllers have broken MSI
> > support and are quirked to use legacy INTx interrupts instead. The quirk
> > identifies them with is_hotplug_bridge, even though all affected ports are
> > also matched by is_pciehp. So use is_pciehp here as well.
> >
> > Signed-off-by: Lukas Wunner <lukas@wunner.de>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Applied to thunderbolt.git/next, thanks!
prev parent reply other threads:[~2025-08-14 4:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 13:42 [PATCH] thunderbolt: Use is_pciehp instead of is_hotplug_bridge Lukas Wunner
2025-08-13 7:42 ` Mika Westerberg
2025-08-13 17:25 ` Bjorn Helgaas
2025-08-14 4:37 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814043752.GB476609@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.