From: Jisheng Zhang <jszhang@kernel.org>
To: "Ulf Hansson" <ulf.hansson@linaro.org>,
"Aubin Constans" <aubin.constans@microchip.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Manuel Lauss" <manuel.lauss@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Russell King" <linux@armlinux.org.uk>,
"Chaotian Jing" <chaotian.jing@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kamal Dasu" <kamal.dasu@broadcom.com>,
"Al Cooper" <alcooperx@gmail.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Michal Simek" <michal.simek@amd.com>,
"Eugen Hristev" <eugen.hristev@linaro.org>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Ben Dooks" <ben-linux@fluff.org>,
"Viresh Kumar" <vireshk@kernel.org>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Alexey Charkov" <alchark@gmail.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 13/38] mmc: omap_hsmmc: use modern PM macros
Date: Fri, 15 Aug 2025 09:33:48 +0800 [thread overview]
Message-ID: <20250815013413.28641-14-jszhang@kernel.org> (raw)
In-Reply-To: <20250815013413.28641-1-jszhang@kernel.org>
Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/mmc/host/omap_hsmmc.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index adc0d0b6ae37..09e4354d1f1d 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -620,8 +620,6 @@ static void omap_hsmmc_set_bus_mode(struct omap_hsmmc_host *host)
OMAP_HSMMC_WRITE(host->base, CON, con & ~OD);
}
-#ifdef CONFIG_PM
-
/*
* Restore the MMC host context, if it was lost as result of a
* power state change.
@@ -689,6 +687,7 @@ static int omap_hsmmc_context_restore(struct omap_hsmmc_host *host)
return 0;
}
+#ifdef CONFIG_PM
/*
* Save the MMC host context (store the number of power state changes so far).
*/
@@ -1990,7 +1989,6 @@ static void omap_hsmmc_remove(struct platform_device *pdev)
clk_disable_unprepare(host->dbclk);
}
-#ifdef CONFIG_PM_SLEEP
static int omap_hsmmc_suspend(struct device *dev)
{
struct omap_hsmmc_host *host = dev_get_drvdata(dev);
@@ -2032,9 +2030,7 @@ static int omap_hsmmc_resume(struct device *dev)
pm_runtime_put_autosuspend(host->dev);
return 0;
}
-#endif
-#ifdef CONFIG_PM
static int omap_hsmmc_runtime_suspend(struct device *dev)
{
struct omap_hsmmc_host *host;
@@ -2102,11 +2098,10 @@ static int omap_hsmmc_runtime_resume(struct device *dev)
spin_unlock_irqrestore(&host->irq_lock, flags);
return 0;
}
-#endif
static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
- SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
- SET_RUNTIME_PM_OPS(omap_hsmmc_runtime_suspend, omap_hsmmc_runtime_resume, NULL)
+ SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
+ RUNTIME_PM_OPS(omap_hsmmc_runtime_suspend, omap_hsmmc_runtime_resume, NULL)
};
static struct platform_driver omap_hsmmc_driver = {
@@ -2115,7 +2110,7 @@ static struct platform_driver omap_hsmmc_driver = {
.driver = {
.name = DRIVER_NAME,
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
- .pm = &omap_hsmmc_dev_pm_ops,
+ .pm = pm_ptr(&omap_hsmmc_dev_pm_ops),
.of_match_table = of_match_ptr(omap_mmc_of_match),
},
};
--
2.50.0
next prev parent reply other threads:[~2025-08-15 1:53 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 1:33 [PATCH 00/38] mmc: host: use modern PM macros Jisheng Zhang
2025-08-15 1:33 ` [PATCH 01/38] sdhci: add some simple inline functions for !CONFIG_PM Jisheng Zhang
2025-08-18 11:29 ` Adrian Hunter
2025-08-15 1:33 ` [PATCH 02/38] mmc: sdhci-of-dwcmshc: use modern PM macros Jisheng Zhang
2025-08-18 18:30 ` Drew Fustini
2025-08-15 1:33 ` [PATCH 03/38] mmc: sdhci-xenon: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 04/38] mmc: sdhci-pxav3: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 05/38] mmc: sunxi: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 06/38] mmc: alcor: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 07/38] mmc: atmel: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 08/38] mmc: au1xmmc: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 09/38] mmc: cb710-mmc: " Jisheng Zhang
2025-08-20 19:21 ` Michał Mirosław
2025-08-15 1:33 ` [PATCH 10/38] mmc: davinci_mmc: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 11/38] mmc: mmci: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 12/38] mmc: mxs-mmc: " Jisheng Zhang
2025-08-15 1:33 ` Jisheng Zhang [this message]
2025-08-15 1:33 ` [PATCH 14/38] mmc: rtsx_usb_sdmmc: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 15/38] mmc: sdhci-acpi: " Jisheng Zhang
2025-08-18 10:40 ` Adrian Hunter
2025-08-15 1:33 ` [PATCH 16/38] mmc: sdhci_am654: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 17/38] mmc: sdhci-brcmstb: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 18/38] mmc: sdhci-esdhc-imx: " Jisheng Zhang
2025-08-15 3:23 ` Bough Chen
2025-08-16 6:03 ` Jisheng Zhang
2025-08-18 12:15 ` Jisheng Zhang
2025-08-19 3:48 ` Bough Chen
2025-08-19 11:59 ` Jisheng Zhang
2025-08-20 2:15 ` Bough Chen
2025-08-15 1:33 ` [PATCH 19/38] mmc: sdhci-of-arasan: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 20/38] mmc: sdhci-of-at91: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 21/38] mmc: sdhci-of-esdhc: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 22/38] mmc: sdhci-omap: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 23/38] mmc: sdhci-cadence: " Jisheng Zhang
2025-08-15 1:33 ` [PATCH 24/38] mmc: sdhci-s3c: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 25/38] mmc: sdhci-spear: " Jisheng Zhang
2025-08-18 6:38 ` Viresh Kumar
2025-08-15 1:34 ` [PATCH 26/38] mmc: sdhci-sprd: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 27/38] mmc: sdhci-st: " Jisheng Zhang
2025-08-18 8:49 ` Patrice CHOTARD
2025-08-15 1:34 ` [PATCH 28/38] mmc: sdhci-tegra: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 29/38] mmc: sh_mmicf: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 30/38] mmc: toshsd: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 31/38] mmc: wmt-sdmmc: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 32/38] mmc: mtk-sd: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 33/38] mmc: sdhci-msm: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 34/38] mmc: via-sdmmc: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 35/38] mmc: dw_mmc: exynos: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 36/38] mmc: dw_mmc-k3: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 37/38] mmc: dw_mmc-pci: " Jisheng Zhang
2025-08-15 1:34 ` [PATCH 38/38] mmc: dw_mmc-rockchip: " Jisheng Zhang
2025-08-22 10:15 ` [PATCH 00/38] mmc: host: " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815013413.28641-14-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alchark@gmail.com \
--cc=alcooperx@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aubin.constans@microchip.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ben-linux@fluff.org \
--cc=chaotian.jing@mediatek.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=eugen.hristev@linaro.org \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=haibo.chen@nxp.com \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=jonathanh@nvidia.com \
--cc=kamal.dasu@broadcom.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=manuel.lauss@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nicolas.ferre@microchip.com \
--cc=orsonzhai@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=vireshk@kernel.org \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.