Re: [PATCH 1/1] USB: Check no positive return values from pm_runtime_resume_and_get()

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Aug 15, 2025 at 10:06:13AM +0000, Sakari Ailus wrote:
> On Fri, Aug 15, 2025 at 11:38:28AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Aug 15, 2025 at 09:34:00AM +0000, Sakari Ailus wrote:
> > > Hi Greg,
> > > 
> > > On Wed, Aug 13, 2025 at 04:43:05PM +0200, Greg Kroah-Hartman wrote:
> > > > On Mon, Aug 11, 2025 at 09:24:03AM +0300, Sakari Ailus wrote:
> > > > > pm_runtime_resume_and_get() always returns a negative error code or zero;
> > > > > there's no need to check for positive values such as returned by
> > > > > pm_runtime_get_sync(). Simply drop the check.
> > > > > 
> > > > > Fixes: 7626c52b6b46 ("usb: usb_autopm_get_interface use modern helper")
> > > > > Cc: stable@vger.kernel.org
> > > > 
> > > > If there is no need for this check, why does this need to be backported
> > > > to stable kernels?
> > > 
> > > It's not necessary IMO.
> > > 
> > > The practice lately has been to add Cc: stable if the Fixes: tag is there.
> > 
> > If it actually fixes a bug.
> > 
> > > But there was no actual bug in this case, just that this change ideally
> > > would have been part of the original patch.
> > 
> > Then it's not really a "fix" so that tag does not need to be there
> > either :)
> 
> I agree, both should be removed. Can you drop them or should I send v2?

Please send a v2.

thanks,

greg k-h