From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch,
pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com,
sdf@fomichev.me
Subject: Re: [PATCH net] bnxt_en: Fix lockdep warning during rmmod
Date: Fri, 15 Aug 2025 10:12:58 -0700 [thread overview]
Message-ID: <20250815101258.37cb17b1@kernel.org> (raw)
In-Reply-To: <20250815170823.4062508-1-michael.chan@broadcom.com>
On Fri, 15 Aug 2025 10:08:23 -0700 Michael Chan wrote:
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 2800a90fba1f..a208c2a73cd6 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -5332,7 +5332,8 @@ static void bnxt_free_ntp_fltrs(struct bnxt *bp, bool all)
> {
> int i;
>
> - netdev_assert_locked(bp->dev);
> + if (bp->dev->reg_state == NETREG_REGISTERED)
> + netdev_assert_locked(bp->dev);
>
> /* Under netdev instance lock and all our NAPIs have been disabled.
> * It's safe to delete the hash table.
netdev_assert_locked_or_invisible()
--
pw-bot: cr
prev parent reply other threads:[~2025-08-15 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 17:08 [PATCH net] bnxt_en: Fix lockdep warning during rmmod Michael Chan
2025-08-15 17:12 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815101258.37cb17b1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.