From: Jakub Kicinski <kuba@kernel.org>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: <almasrymina@google.com>, <asml.silence@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
<cratiu@nvidia.com>, <tariqt@nvidia.com>, <parav@nvidia.com>,
Christoph Hellwig <hch@infradead.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next v3 6/7] net: devmem: pre-read requested rx queues during bind
Date: Fri, 15 Aug 2025 10:20:25 -0700 [thread overview]
Message-ID: <20250815102025.202c42d3@kernel.org> (raw)
In-Reply-To: <20250815110401.2254214-8-dtatulea@nvidia.com>
On Fri, 15 Aug 2025 14:03:47 +0300 Dragos Tatulea wrote:
> Instead of reading the requested rx queues after binding the buffer,
> read the rx queues in advance in a bitmap and iterate over them when
> needed.
>
> This is a preparation for fetching the DMA device for each queue.
>
> This patch has no functional changes.
Nice!
> + rxq_bitmap = bitmap_alloc(netdev->num_rx_queues, GFP_KERNEL);
FWIW I think you can use num_real_rx_queues since we're holding
the instance lock which prevents it from changing?
But it's just bits so doesn't matter all that much.
next prev parent reply other threads:[~2025-08-15 17:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 11:03 [RFC net-next v3 0/7] devmem/io_uring: allow more flexibility for ZC DMA devices Dragos Tatulea
2025-08-15 11:03 ` [RFC net-next v3 1/7] queue_api: add support for fetching per queue DMA dev Dragos Tatulea
2025-08-15 17:16 ` Jakub Kicinski
2025-08-19 14:41 ` Dragos Tatulea
2025-08-19 15:30 ` Jakub Kicinski
2025-08-15 18:11 ` Mina Almasry
2025-08-16 8:55 ` Dragos Tatulea
2025-08-19 15:56 ` Pavel Begunkov
2025-08-15 11:03 ` [RFC net-next v3 2/7] io_uring/zcrx: add support for custom DMA devices Dragos Tatulea
2025-08-18 18:16 ` Mina Almasry
2025-08-19 16:04 ` Pavel Begunkov
2025-08-15 11:03 ` [RFC net-next v3 3/7] net: devmem: get netdev DMA device via new API Dragos Tatulea
2025-08-15 17:30 ` Mina Almasry
2025-08-15 11:03 ` [RFC net-next v3 4/7] net/mlx5e: add op for getting netdev DMA device Dragos Tatulea
2025-08-15 17:37 ` Mina Almasry
2025-08-18 17:40 ` Dragos Tatulea
2025-08-18 18:18 ` Mina Almasry
2025-08-15 11:03 ` [RFC net-next v3 5/7] net: devmem: pull out dma_dev out of net_devmem_bind_dmabuf Dragos Tatulea
2025-08-18 18:22 ` Mina Almasry
2025-08-15 11:03 ` [RFC net-next v3 6/7] net: devmem: pre-read requested rx queues during bind Dragos Tatulea
2025-08-15 17:20 ` Jakub Kicinski [this message]
2025-08-15 18:05 ` Mina Almasry
2025-08-16 8:59 ` Dragos Tatulea
2025-08-18 18:24 ` Mina Almasry
2025-10-02 16:38 ` ChaosEsque Team
2025-08-15 11:03 ` [RFC net-next v3 7/7] net: devmem: allow binding on rx queues with same MA devices Dragos Tatulea
2025-08-15 17:24 ` Jakub Kicinski
2025-08-16 9:05 ` Dragos Tatulea
2025-08-15 15:31 ` [RFC net-next v3 0/7] devmem/io_uring: allow more flexibility for ZC DMA devices Stanislav Fomichev
2025-08-15 15:48 ` Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815102025.202c42d3@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=hch@infradead.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.