From: Jakub Kicinski <kuba@kernel.org>
To: Chris Babroski <cbabroski@nvidia.com>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<davthompson@nvidia.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v1] mlxbf_gige: report unknown speed and duplex when link is down
Date: Fri, 15 Aug 2025 12:11:02 -0700 [thread overview]
Message-ID: <20250815121102.0653f13f@kernel.org> (raw)
In-Reply-To: <20250813163346.302186-1-cbabroski@nvidia.com>
On Wed, 13 Aug 2025 12:33:46 -0400 Chris Babroski wrote:
> The "Speed" and "Duplex" fields displayed by ethtool should report
> "Unknown" when the link is down. Currently, the driver always reports
> the initially configured link speed and duplex, regardless of the actual
> link state.
>
> Implement a get_link_ksettings() callback to update the values reported
> to ethtool based on the link state. When the link is down, the driver
> now reports unknown speed and duplex as expected.
If that's the correct thing to do why is
phy_ethtool_get_link_ksettings() not doing it?
Please explain what makes mlxbf special, and make sure to CC PHY
maintainers on v2.
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-15 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 16:33 [PATCH net-next v1] mlxbf_gige: report unknown speed and duplex when link is down Chris Babroski
2025-08-15 19:11 ` Jakub Kicinski [this message]
2025-08-26 18:45 ` Chris Babroski
2025-10-13 15:17 ` Chris Babroski
2025-10-13 17:59 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815121102.0653f13f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cbabroski@nvidia.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.