From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90D8FCA0ED1 for ; Fri, 15 Aug 2025 19:23:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 40E4F8223E; Fri, 15 Aug 2025 19:23:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id GsXJXcdKXw00; Fri, 15 Aug 2025 19:23:42 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AEFBC82240 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1755285822; bh=QJnIVxwqsmyXZiZ4k0FK/SBSbvmm32uQPQa7PwJSyB8=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HlQFCpuDlYcFwtGfqfYxmQOV4vUUMKVZ24HzUYSoIwUPLz5xCgELW7ug2BYjE0+A3 wXudw88wlUBRADrh6D+nRmbv/Jlux9WH/KpipBTfzEbyL4w46PIouk9NQDJkGHiCeo +jP3Oh/JjX/trurbOqhxfhPU3UIQgnJlKPPAHnHqk2E4E0XB7sA6fki+7s5ng/dHJs OIQKO/pM8XwwokO/pHv3gDkiUieuuydlmXoo/wh9+W2itg5/Qwlu4WpRXgprM5GoDb oXk0QsRXERazoFJ2Dva6NG/+J46UL6g5Ygmry6y3yyo8cNXUcx+mKfHTS60OvCxk7c zRa3B0IyTsF6Q== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id AEFBC82240; Fri, 15 Aug 2025 19:23:42 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id B6287223 for ; Fri, 15 Aug 2025 19:23:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B2F9782240 for ; Fri, 15 Aug 2025 19:23:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JBow6cgPuy3X for ; Fri, 15 Aug 2025 19:23:41 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 26AC48223E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 26AC48223E Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 26AC48223E for ; Fri, 15 Aug 2025 19:23:41 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E298E5C68F1; Fri, 15 Aug 2025 19:23:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79A54C4CEEB; Fri, 15 Aug 2025 19:23:38 +0000 (UTC) Date: Fri, 15 Aug 2025 12:23:37 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: Jiri Pirko , Jiri Pirko , Eric Dumazet , Paolo Abeni , Andrew Lunn , "David S. Miller" , Donald Hunter , Jonathan Corbet , Brett Creeley , Michael Chan , Pavan Chebbi , "Cai Huoqing" , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , , , , , , "Gal Pressman" , Dragos Tatulea , "Shahar Shitrit" Message-ID: <20250815122337.4aa50105@kernel.org> In-Reply-To: <1755111349-416632-4-git-send-email-tariqt@nvidia.com> References: <1755111349-416632-1-git-send-email-tariqt@nvidia.com> <1755111349-416632-4-git-send-email-tariqt@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755285819; bh=JtacZUTLhICvO5yuLBzEN+3vCLB7bp1fK7RdD5/lksY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aSDhjSm+hjhcyqFW5Zn3ElR2eNNM57vXdtPe4U9uZ9swYyEoVgIDsMcD9aic3XUuO EEUqvo2T55OYe0w2a3QPWiZ05emD7U6s/w2WlRx/ipXbj7XDD1wTpCBmq3ldbLHv3z ZtnCNvXdYX4QA2n2N69ma08fi+/WHPOX/UdM/bJhRFVNZfMycVQTQ9rm1g8ZEWTc/G ZI8pYAFimYwzuFvi8MJi3SVYHQb8c1+2sad2ea3KkROM0AvExgNxTtaGNZZaYUctWH 7B4lSeBVmUW3pNt3hHO5SbAPqj8If/L5yPPhlgTjz7+A+9TiTviteU+Qnh1X5Clpup +xXtsvKhm85hg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=aSDhjSm+ Subject: Re: [Intel-wired-lan] [PATCH net-next V3 3/5] devlink: Introduce error burst period for health reporter X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 13 Aug 2025 21:55:47 +0300 Tariq Toukan wrote: > + * @default_error_burst_period: default time (in msec) for > + * error recoveries before > + * starting the grace period FWIW you don't have to indent the continuation lines this much, one tab is enough to make it clear that it's a continuation. > +static bool > +devlink_health_reporter_burst_period_active(struct devlink_health_reporter *reporter) Not sure what it means for a period to be active. devlink_health_reporter_in_burst() From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EFD722F75C; Fri, 15 Aug 2025 19:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755285820; cv=none; b=tQApcCING/JF0fqKCZ3GUW6VBeCaq6i4FvUkuaV60j5ijfY+jaien3UMoSFKwcI9Tph0QNBydwAW37k2fLaR92cQmGQKv03vtGk1rWB7AdVtCMDnEe7YgPZj7sdrKDQytCuyoj2sHqQzHuv2vAAXQGBg26KiCv6ClquzElvWqs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755285820; c=relaxed/simple; bh=JtacZUTLhICvO5yuLBzEN+3vCLB7bp1fK7RdD5/lksY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u2O8IOgJtxCjMfTdp9RM+kFD3NUfRPOpL6XDhg773ETCWJHbiL9buKPI7fynH7cRBafhOmBgxwDgJ8JbFzigGPbrrUONFkceKs39/GaJFNLCpT/84KLvlArvewDEB7+VKl0VE3qLjd7vH/n4We8R+WkR72meNYtwItbTe7bWuTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aSDhjSm+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aSDhjSm+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79A54C4CEEB; Fri, 15 Aug 2025 19:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755285819; bh=JtacZUTLhICvO5yuLBzEN+3vCLB7bp1fK7RdD5/lksY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aSDhjSm+hjhcyqFW5Zn3ElR2eNNM57vXdtPe4U9uZ9swYyEoVgIDsMcD9aic3XUuO EEUqvo2T55OYe0w2a3QPWiZ05emD7U6s/w2WlRx/ipXbj7XDD1wTpCBmq3ldbLHv3z ZtnCNvXdYX4QA2n2N69ma08fi+/WHPOX/UdM/bJhRFVNZfMycVQTQ9rm1g8ZEWTc/G ZI8pYAFimYwzuFvi8MJi3SVYHQb8c1+2sad2ea3KkROM0AvExgNxTtaGNZZaYUctWH 7B4lSeBVmUW3pNt3hHO5SbAPqj8If/L5yPPhlgTjz7+A+9TiTviteU+Qnh1X5Clpup +xXtsvKhm85hg== Date: Fri, 15 Aug 2025 12:23:37 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: Jiri Pirko , Jiri Pirko , Eric Dumazet , Paolo Abeni , Andrew Lunn , "David S. Miller" , Donald Hunter , Jonathan Corbet , Brett Creeley , Michael Chan , Pavan Chebbi , "Cai Huoqing" , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , , , , , , "Gal Pressman" , Dragos Tatulea , "Shahar Shitrit" Subject: Re: [PATCH net-next V3 3/5] devlink: Introduce error burst period for health reporter Message-ID: <20250815122337.4aa50105@kernel.org> In-Reply-To: <1755111349-416632-4-git-send-email-tariqt@nvidia.com> References: <1755111349-416632-1-git-send-email-tariqt@nvidia.com> <1755111349-416632-4-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 13 Aug 2025 21:55:47 +0300 Tariq Toukan wrote: > + * @default_error_burst_period: default time (in msec) for > + * error recoveries before > + * starting the grace period FWIW you don't have to indent the continuation lines this much, one tab is enough to make it clear that it's a continuation. > +static bool > +devlink_health_reporter_burst_period_active(struct devlink_health_reporter *reporter) Not sure what it means for a period to be active. devlink_health_reporter_in_burst()