From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FDAFCA0EE4 for ; Fri, 15 Aug 2025 19:26:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6380C40924; Fri, 15 Aug 2025 19:26:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id unHQg4NZxYct; Fri, 15 Aug 2025 19:26:32 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B8E464092D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1755285992; bh=jZSYI0BkoXuNhL8kExnHMzB3D2C3PD4TSB5c7r9JtHs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YUY+wAcO47LJf8LXh88UaFESWDlMbCGMqmlyEaShoVP8UjlEeuNKQCjj1n8tvMVLQ Lzi/EkoYlDkJ/uQkrKb4FTnChcDWZV1V7YKBjg8cgHOEATFyab+GALw+GPB3RzvTQ3 mKUQvRCUVWca7IcvtmgsYE4ifomTvNbCvI6WHANEiAb8QzeRcP/BYkr3I1q7Vm6Kne 0H0Mp73UoInetDag1vhIfH0OvK0cTvz01fmVquT2TVVICeOri8nANmhqpvcRmdzi5R n7ICqThUGL2nERa5a8LsCv2JSFipSh2UgU1ULtTwH4Vl1jOAlkKoXKfWRgWXUP6dMk GmViQScoUM++Q== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id B8E464092D; Fri, 15 Aug 2025 19:26:32 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 23531223 for ; Fri, 15 Aug 2025 19:26:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 14C7C4092D for ; Fri, 15 Aug 2025 19:26:31 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Usk5vKEvkWC9 for ; Fri, 15 Aug 2025 19:26:30 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 6668C40924 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6668C40924 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 6668C40924 for ; Fri, 15 Aug 2025 19:26:30 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 725595C68AC; Fri, 15 Aug 2025 19:26:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 234DAC4CEEB; Fri, 15 Aug 2025 19:26:28 +0000 (UTC) Date: Fri, 15 Aug 2025 12:26:27 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: Jiri Pirko , Jiri Pirko , Eric Dumazet , Paolo Abeni , Andrew Lunn , "David S. Miller" , Donald Hunter , Jonathan Corbet , Brett Creeley , Michael Chan , Pavan Chebbi , "Cai Huoqing" , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , , , , , , "Gal Pressman" , Dragos Tatulea , "Shahar Shitrit" Message-ID: <20250815122627.77877d21@kernel.org> In-Reply-To: <1755111349-416632-5-git-send-email-tariqt@nvidia.com> References: <1755111349-416632-1-git-send-email-tariqt@nvidia.com> <1755111349-416632-5-git-send-email-tariqt@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755285989; bh=XThlV1U6bmBUoCCBTZhniQaFumiomKJglFZyqJ8EKMo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RPzsPUfJBr5q5p+iF9vGtPAIahYFabs9abdt4JCY7KxS1BzGSCe6yRc539IhK5VBn BHJH/IQp4gyfnkPd1YC/dKSq0GM/dU83SnnwkOxSYvQ4TUUPUuV0CoMUlKZANeCulU IXM7O4rn6DuC98dxd83wIL7+Z2YA1qUbe6SKpFDZ796B1oaIbDtehNXYrQJ3NyjTB8 ThvxZ/TZ1RZHfqz1s2dV1biJs0NzcmsQg3rroH2ODMZvpYx7eLoaDNpgmShfEcB0P1 15fyszyNz+4TOiZQtxl4cn/2BGzPyxDkB2ruCyy84Yo8ioH+1EZGfD3XjmVyTDdNMw 8Qx3qtsNsZypw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=RPzsPUfJ Subject: Re: [Intel-wired-lan] [PATCH net-next V3 4/5] devlink: Make health reporter error burst period configurable X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 13 Aug 2025 21:55:48 +0300 Tariq Toukan wrote: > diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml > index bb87111d5e16..0e81640dd3b2 100644 > --- a/Documentation/netlink/specs/devlink.yaml > +++ b/Documentation/netlink/specs/devlink.yaml > @@ -853,6 +853,9 @@ attribute-sets: > type: nest > multi-attr: true > nested-attributes: dl-rate-tc-bws > + - > + name: health-reporter-error-burst-period the "graceful-period" does not have the word "error" in it. Why is it necessary to include it in this parameter? What else would be bursting in an error reporter if not errors? > + type: u64 could you add a doc: here? > - > name: dl-dev-stats > subset-of: devlink > + DEVLINK_ATTR_HEALTH_REPORTER_ERR_BURST_PERIOD, /* u64 */ The _ERR here won't work if you used _ERROR in YAML. The naming in the YAML spec must match the C naming exactly. -- pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88CC6221D87; Fri, 15 Aug 2025 19:26:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755285989; cv=none; b=hGbM4+PPRwOz8sVIKrXuE/KYZ81TRm+5CW8EnSJC7EeRjWZZk8xZQJaMJwiwuSrs0ohhsWiky0mnCB645sLn9kGWneTIfNDFAtByp6eL0s7lcuxggdwhjaLOST8pZEMWPr6ya6Rg7ogmIP7pIXvUBx07kp6HKgxmcfTe3MXNIRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755285989; c=relaxed/simple; bh=XThlV1U6bmBUoCCBTZhniQaFumiomKJglFZyqJ8EKMo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GpoPwVUwJJTKcbEsjf/hxdVvCA+qshOxZRkrXUc+Zcv0oe4GVvMquLBpR0YPX3zuAvHLjrhgqaGmjk/W/hQHD5UwWsm5GIisZfbH4qh1qSDuzQv0QYY6Sg97MsMdmvLKfQvl9iqL20txCriXriPmcVNQJmTJZ57GQ5rCERmRanw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RPzsPUfJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RPzsPUfJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 234DAC4CEEB; Fri, 15 Aug 2025 19:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755285989; bh=XThlV1U6bmBUoCCBTZhniQaFumiomKJglFZyqJ8EKMo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RPzsPUfJBr5q5p+iF9vGtPAIahYFabs9abdt4JCY7KxS1BzGSCe6yRc539IhK5VBn BHJH/IQp4gyfnkPd1YC/dKSq0GM/dU83SnnwkOxSYvQ4TUUPUuV0CoMUlKZANeCulU IXM7O4rn6DuC98dxd83wIL7+Z2YA1qUbe6SKpFDZ796B1oaIbDtehNXYrQJ3NyjTB8 ThvxZ/TZ1RZHfqz1s2dV1biJs0NzcmsQg3rroH2ODMZvpYx7eLoaDNpgmShfEcB0P1 15fyszyNz+4TOiZQtxl4cn/2BGzPyxDkB2ruCyy84Yo8ioH+1EZGfD3XjmVyTDdNMw 8Qx3qtsNsZypw== Date: Fri, 15 Aug 2025 12:26:27 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: Jiri Pirko , Jiri Pirko , Eric Dumazet , Paolo Abeni , Andrew Lunn , "David S. Miller" , Donald Hunter , Jonathan Corbet , Brett Creeley , Michael Chan , Pavan Chebbi , "Cai Huoqing" , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , , , , , , "Gal Pressman" , Dragos Tatulea , "Shahar Shitrit" Subject: Re: [PATCH net-next V3 4/5] devlink: Make health reporter error burst period configurable Message-ID: <20250815122627.77877d21@kernel.org> In-Reply-To: <1755111349-416632-5-git-send-email-tariqt@nvidia.com> References: <1755111349-416632-1-git-send-email-tariqt@nvidia.com> <1755111349-416632-5-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 13 Aug 2025 21:55:48 +0300 Tariq Toukan wrote: > diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml > index bb87111d5e16..0e81640dd3b2 100644 > --- a/Documentation/netlink/specs/devlink.yaml > +++ b/Documentation/netlink/specs/devlink.yaml > @@ -853,6 +853,9 @@ attribute-sets: > type: nest > multi-attr: true > nested-attributes: dl-rate-tc-bws > + - > + name: health-reporter-error-burst-period the "graceful-period" does not have the word "error" in it. Why is it necessary to include it in this parameter? What else would be bursting in an error reporter if not errors? > + type: u64 could you add a doc: here? > - > name: dl-dev-stats > subset-of: devlink > + DEVLINK_ATTR_HEALTH_REPORTER_ERR_BURST_PERIOD, /* u64 */ The _ERR here won't work if you used _ERROR in YAML. The naming in the YAML spec must match the C naming exactly. -- pw-bot: cr