Re: [PATCH v3 1/3] rust: i2c: add basic I2C device and driver abstractions

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Aug 15, 2025 at 06:03:32PM +0200, Danilo Krummrich wrote:
> On 8/15/25 5:40 PM, Igor Korotin wrote:
> > Hello Guys
> > 
> > Preparing v4, I keep thinking if for I2C I should rename `i2c::Device`
> > to `i2c::I2cClient` or `i2c::Client`. The reason why I made it `Device`
> > for the first iterations is so it would be the same code as for
> > PCI/Platform code for example.
> > But the original I2C C code has other terminology. Do you think it worth
> > keeping it in the Rust code?
> 
> I think the reason I2C names this i2c_client and i2c_adapter is that technically
> both are I2C devices, hence just i2c_device would have been ambiguous.

Yes, when I did that code 20+ years ago, it was hard to pick out good
names.  Also we were converting over from the existing non-driver-model
i2c code, which had those names at the time, so we kept them as much as
possible.

> What about i2c::ClientDevice and i2c::AdapterDevice?

I would try to keep them matching the same as the C side, as
i2c_client_device and i2c_adapter_device wouldn't make much sense there
either.

thanks,

greg k-h