Re: [PATCH] mm/damon/core: fix damos_commit_filter not changing allow

[SeongJae Park <sj@kernel.org>]

On Fri, 15 Aug 2025 18:40:59 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:

> Current damos_commit_filter() not persist allow value of filter. As a
> result, changing allow value of filter and commit doesn't change
> allow value.
> 
> Add the missing allow value update, so commit filter now persist changing
> allow value well.

Thank you for finding and fixing this!

> 
> Fixes: 9cb3d0b9dfce ("mm/damon/core: implement DAMON context commit function")

At the time of the commit, damos_filter->allow didn't exist.  I think below is
more correct.

Fixes: fe6d7fdd6249 ("mm/damon/core: add damos_filter->allow field")

Also,

Cc: stablee@vger.kernel.org # 6.14.x

> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
> While fixing kselftest, I found another bug and succeeded in
> reproducing. I think this patch is similar with previeous patch [1].
> Also instead of sending patch with test, should we check which is better:
> a seperate patch or patchset?

Separate patches are better for me.

I'm not sure how you will make the test, but I'd usggest making the test as a
kunit test.

Please refer to mm/damon/tets/core-kunit.h file.


Thanks,
SJ

[...]