From: David Sterba <dsterba@suse.cz>
To: Leo Martins <loemra.dev@gmail.com>
Cc: David Sterba <dsterba@suse.cz>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v4 1/3] btrfs: implement ref_tracker for delayed_nodes
Date: Sat, 16 Aug 2025 00:57:33 +0200 [thread overview]
Message-ID: <20250815225733.GF22430@twin.jikos.cz> (raw)
In-Reply-To: <20250813174146.1159027-1-loemra.dev@gmail.com>
On Wed, Aug 13, 2025 at 10:41:15AM -0700, Leo Martins wrote:
> On Wed, 13 Aug 2025 14:50:52 +0200 David Sterba <dsterba@suse.cz> wrote:
> > On Tue, Aug 12, 2025 at 04:04:39PM -0700, Leo Martins wrote:
> > > config BTRFS_DEBUG
> > > bool "Btrfs debugging support"
> > > - depends on BTRFS_FS
> > > + depends on BTRFS_FS && STACKTRACE_SUPPORT
> >
> > How does this work? If STACKTRACE_SUPPORT is not enabled then we can't
> > enable BTRFS_DEBUG?
>
> That's correct, my understanding is that STACKTRACE_SUPPORT is something
> configured by different architectures based on whether or not they
> support stacktraces. Maybe it would be better to do something like
>
> select REF_TRACKER if STACKTRACE_SUPPORT
>
> so we can still use DEBUG on architectures that don't support stacktraces,
> though I can't imagine they would be very relevant.
I think we should not tie debug config option to some arch-specific
option, so the conditional seems right.
next prev parent reply other threads:[~2025-08-15 22:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 23:04 [PATCH v4 0/3] btrfs: ref_tracker for delayed_nodes Leo Martins
2025-08-12 23:04 ` [PATCH v4 1/3] btrfs: implement " Leo Martins
2025-08-12 23:30 ` Leo Martins
2025-08-13 12:50 ` David Sterba
2025-08-13 17:41 ` Leo Martins
2025-08-15 22:57 ` David Sterba [this message]
2025-08-15 23:27 ` David Sterba
2025-08-12 23:04 ` [PATCH v4 2/3] btrfs: print leaked references in kill_all_delayed_nodes Leo Martins
2025-08-12 23:04 ` [PATCH v4 3/3] btrfs: add mount option for ref_tracker Leo Martins
2025-08-15 23:01 ` [PATCH v4 0/3] btrfs: ref_tracker for delayed_nodes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815225733.GF22430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=loemra.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.