diff for duplicates of <202508160958.ounSAlER-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 1c3de9e..087637f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,27 +1,51 @@ +BCC: lkp@intel.com +CC: oe-kbuild-all@lists.linux.dev +In-Reply-To: <20250814124832.76266-3-biju.das.jz@bp.renesas.com> +References: <20250814124832.76266-3-biju.das.jz@bp.renesas.com> +TO: Biju <biju.das.au@gmail.com> +TO: Geert Uytterhoeven <geert+renesas@glider.be> +TO: Michael Turquette <mturquette@baylibre.com> +TO: Stephen Boyd <sboyd@kernel.org> +CC: Biju Das <biju.das.jz@bp.renesas.com> +CC: linux-renesas-soc@vger.kernel.org +CC: linux-clk@vger.kernel.org +CC: linux-kernel@vger.kernel.org +CC: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> + Hi Biju, kernel test robot noticed the following build warnings: +[auto build test WARNING on geert-renesas-drivers/renesas-clk] +[also build test WARNING on clk/clk-next robh/for-next linus/master v6.17-rc1 next-20250815] +[If your patch is applied to the wrong git tree, kindly drop us a note. +And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Biju/clk-renesas-rzv2h-Refactor-rzv2h_cpg_fixed_mod_status_clk_register/20250814-205111 base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-clk patch link: https://lore.kernel.org/r/20250814124832.76266-3-biju.das.jz%40bp.renesas.com patch subject: [PATCH 2/4] clk: renesas: rzv2h: Add support for parent mod clocks +:::::: branch date: 2 days ago +:::::: commit date: 2 days ago config: hexagon-randconfig-r072-20250815 (https://download.01.org/0day-ci/archive/20250816/202508160958.ounSAlER-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 93d24b6b7b148c47a2fa228a4ef31524fa1d9f3f) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> +| Reported-by: Dan Carpenter <error27@gmail.com> | Closes: https://lore.kernel.org/r/202508160958.ounSAlER-lkp@intel.com/ New smatch warnings: drivers/clk/renesas/rzv2h-cpg.c:875 rzv2h_cpg_register_mod_clk() warn: passing zero to 'PTR_ERR' +Old smatch warnings: +drivers/clk/renesas/rzv2h-cpg.c:621 rzv2h_cpg_register_core_clk() warn: passing zero to 'PTR_ERR' + vim +/PTR_ERR +875 drivers/clk/renesas/rzv2h-cpg.c +dd22e56217495e Lad Prabhakar 2024-07-29 769 dd22e56217495e Lad Prabhakar 2024-07-29 770 static void __init dd22e56217495e Lad Prabhakar 2024-07-29 771 rzv2h_cpg_register_mod_clk(const struct rzv2h_mod_clk *mod, dd22e56217495e Lad Prabhakar 2024-07-29 772 struct rzv2h_cpg_priv *priv) @@ -87,16 +111,6 @@ dd22e56217495e Lad Prabhakar 2024-07-29 825 priv->clks[id] = clock->hw.clk; 18610e6bf54faa Biju Das 2025-08-14 832 mod->mon_bit)); 18610e6bf54faa Biju Das 2025-08-14 833 if (IS_ERR_OR_NULL(clk)) 18610e6bf54faa Biju Das 2025-08-14 834 goto fail; - -This isn't how IS_ERR_OR_NULL() is supposed to work... :( The NULL should -be treated like success, it shouldn't print an error message, unless it's -something like: - - WARN_ON_ONCE(!clk); // rzv2h_cpg_mod_status_clk_register() is buggy - -I have written a blog about how how IS_ERR_OR_NULL() is supposed to work: -https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/ - 18610e6bf54faa Biju Das 2025-08-14 835 priv->clks[mod->child] = clk; 18610e6bf54faa Biju Das 2025-08-14 836 } dd22e56217495e Lad Prabhakar 2024-07-29 837 @@ -140,6 +154,7 @@ dd22e56217495e Lad Prabhakar 2024-07-29 874 fail: dd22e56217495e Lad Prabhakar 2024-07-29 @875 dev_err(dev, "Failed to register module clock %s: %ld\n", dd22e56217495e Lad Prabhakar 2024-07-29 876 mod->name, PTR_ERR(clk)); dd22e56217495e Lad Prabhakar 2024-07-29 877 } +dd22e56217495e Lad Prabhakar 2024-07-29 878 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index a5d772c..c3bf591 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,45 +1,59 @@ - "ref\020250814124832.76266-3-biju.das.jz@bp.renesas.com\0" - "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH 2/4] clk: renesas: rzv2h: Add support for parent mod clocks\0" - "Date\0Sat, 16 Aug 2025 13:28:27 +0300\0" - "To\0oe-kbuild@lists.linux.dev" - Biju <biju.das.au@gmail.com> - Geert Uytterhoeven <geert+renesas@glider.be> - Michael Turquette <mturquette@baylibre.com> - " Stephen Boyd <sboyd@kernel.org>\0" + "Date\0Sat, 16 Aug 2025 09:29:14 +0800\0" + "To\0oe-kbuild@lists.linux.dev\0" "Cc\0lkp@intel.com" - oe-kbuild-all@lists.linux.dev - Biju Das <biju.das.jz@bp.renesas.com> - linux-renesas-soc@vger.kernel.org - linux-clk@vger.kernel.org - linux-kernel@vger.kernel.org - " Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>\0" + " Dan Carpenter <error27@gmail.com>\0" "\00:1\0" "b\0" + "BCC: lkp@intel.com\n" + "CC: oe-kbuild-all@lists.linux.dev\n" + "In-Reply-To: <20250814124832.76266-3-biju.das.jz@bp.renesas.com>\n" + "References: <20250814124832.76266-3-biju.das.jz@bp.renesas.com>\n" + "TO: Biju <biju.das.au@gmail.com>\n" + "TO: Geert Uytterhoeven <geert+renesas@glider.be>\n" + "TO: Michael Turquette <mturquette@baylibre.com>\n" + "TO: Stephen Boyd <sboyd@kernel.org>\n" + "CC: Biju Das <biju.das.jz@bp.renesas.com>\n" + "CC: linux-renesas-soc@vger.kernel.org\n" + "CC: linux-clk@vger.kernel.org\n" + "CC: linux-kernel@vger.kernel.org\n" + "CC: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>\n" + "\n" "Hi Biju,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" + "[auto build test WARNING on geert-renesas-drivers/renesas-clk]\n" + "[also build test WARNING on clk/clk-next robh/for-next linus/master v6.17-rc1 next-20250815]\n" + "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" + "And when submitting patch, we suggest to use '--base' as documented in\n" "https://git-scm.com/docs/git-format-patch#_base_tree_information]\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Biju/clk-renesas-rzv2h-Refactor-rzv2h_cpg_fixed_mod_status_clk_register/20250814-205111\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-clk\n" "patch link: https://lore.kernel.org/r/20250814124832.76266-3-biju.das.jz%40bp.renesas.com\n" "patch subject: [PATCH 2/4] clk: renesas: rzv2h: Add support for parent mod clocks\n" + ":::::: branch date: 2 days ago\n" + ":::::: commit date: 2 days ago\n" "config: hexagon-randconfig-r072-20250815 (https://download.01.org/0day-ci/archive/20250816/202508160958.ounSAlER-lkp@intel.com/config)\n" "compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 93d24b6b7b148c47a2fa228a4ef31524fa1d9f3f)\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" + "| Reported-by: Dan Carpenter <error27@gmail.com>\n" "| Closes: https://lore.kernel.org/r/202508160958.ounSAlER-lkp@intel.com/\n" "\n" "New smatch warnings:\n" "drivers/clk/renesas/rzv2h-cpg.c:875 rzv2h_cpg_register_mod_clk() warn: passing zero to 'PTR_ERR'\n" "\n" + "Old smatch warnings:\n" + "drivers/clk/renesas/rzv2h-cpg.c:621 rzv2h_cpg_register_core_clk() warn: passing zero to 'PTR_ERR'\n" + "\n" "vim +/PTR_ERR +875 drivers/clk/renesas/rzv2h-cpg.c\n" "\n" + "dd22e56217495e Lad Prabhakar 2024-07-29 769 \n" "dd22e56217495e Lad Prabhakar 2024-07-29 770 static void __init\n" "dd22e56217495e Lad Prabhakar 2024-07-29 771 rzv2h_cpg_register_mod_clk(const struct rzv2h_mod_clk *mod,\n" "dd22e56217495e Lad Prabhakar 2024-07-29 772 \t\t\t struct rzv2h_cpg_priv *priv)\n" @@ -105,16 +119,6 @@ "18610e6bf54faa Biju Das 2025-08-14 832 \t\t\t\t\t\t\t\t\t mod->mon_bit));\n" "18610e6bf54faa Biju Das 2025-08-14 833 \t\tif (IS_ERR_OR_NULL(clk))\n" "18610e6bf54faa Biju Das 2025-08-14 834 \t\t\tgoto fail;\n" - "\n" - "This isn't how IS_ERR_OR_NULL() is supposed to work... :( The NULL should\n" - "be treated like success, it shouldn't print an error message, unless it's\n" - "something like:\n" - "\n" - "\tWARN_ON_ONCE(!clk); // rzv2h_cpg_mod_status_clk_register() is buggy\n" - "\n" - "I have written a blog about how how IS_ERR_OR_NULL() is supposed to work:\n" - "https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/\n" - "\n" "18610e6bf54faa Biju Das 2025-08-14 835 \t\tpriv->clks[mod->child] = clk;\n" "18610e6bf54faa Biju Das 2025-08-14 836 \t}\n" "dd22e56217495e Lad Prabhakar 2024-07-29 837 \n" @@ -158,9 +162,10 @@ "dd22e56217495e Lad Prabhakar 2024-07-29 @875 \tdev_err(dev, \"Failed to register module clock %s: %ld\\n\",\n" "dd22e56217495e Lad Prabhakar 2024-07-29 876 \t\tmod->name, PTR_ERR(clk));\n" "dd22e56217495e Lad Prabhakar 2024-07-29 877 }\n" + "dd22e56217495e Lad Prabhakar 2024-07-29 878 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -cb3f9c3b8bc12792d5be4b1223b0306f48205e41c024d1227b96848df4f67167 +d9777bcc096f19d6327ccc4b7c542eb42227e009978f95ce7c91972d78cb7d24
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.