All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Thorsten Blum <thorsten.blum@linux.dev>
Cc: linux-hardening@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 6/8] MIPS: octeon: Replace memset(0) + deprecated strcpy() with strscpy_pad()
Date: Sun, 17 Aug 2025 20:37:16 +0200	[thread overview]
Message-ID: <20250817183728.612012-6-thorsten.blum@linux.dev> (raw)
In-Reply-To: <20250817183728.612012-1-thorsten.blum@linux.dev>

Replace memset(0) followed by the deprecated strcpy() with strscpy_pad()
to improve octeon_fdt_set_phy(). This avoids zeroing the memory before
copying the string and ensures the destination buffer is only written to
once, simplifying the code and improving efficiency.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/mips/cavium-octeon/octeon-platform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
index 5e1dd4e6e82f..47677b5d7ed0 100644
--- a/arch/mips/cavium-octeon/octeon-platform.c
+++ b/arch/mips/cavium-octeon/octeon-platform.c
@@ -13,6 +13,7 @@
 #include <linux/of_fdt.h>
 #include <linux/platform_device.h>
 #include <linux/libfdt.h>
+#include <linux/string.h>
 
 #include <asm/octeon/octeon.h>
 #include <asm/octeon/cvmx-helper-board.h>
@@ -538,8 +539,7 @@ static void __init octeon_fdt_set_phy(int eth, int phy_addr)
 
 	if (octeon_has_88e1145()) {
 		fdt_nop_property(initial_boot_params, phy, "marvell,reg-init");
-		memset(new_name, 0, sizeof(new_name));
-		strcpy(new_name, "marvell,88e1145");
+		strscpy_pad(new_name, "marvell,88e1145");
 		p = fdt_getprop(initial_boot_params, phy, "compatible",
 				&current_len);
 		if (p && current_len >= strlen(new_name))
-- 
2.50.1


  parent reply	other threads:[~2025-08-17 18:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-17 18:37 [PATCH 1/8] MIPS: sgi-ip22: Replace deprecated strcpy() in plat_mem_setup() Thorsten Blum
2025-08-17 18:37 ` [PATCH 2/8] MIPS: sgi-ip32: " Thorsten Blum
2025-08-18 23:40   ` Justin Stitt
2025-08-19  0:33     ` Thorsten Blum
2025-08-29 10:25   ` Thomas Bogendoerfer
2025-08-17 18:37 ` [PATCH 3/8] MIPS: sni: Replace deprecated strcpy() in sni_console_setup() Thorsten Blum
2025-08-18 23:45   ` Justin Stitt
2025-08-29 10:25   ` Thomas Bogendoerfer
2025-08-17 18:37 ` [PATCH 4/8] MIPS: txx9: Replace deprecated strcpy() with strscpy() Thorsten Blum
2025-08-18  6:30   ` Geert Uytterhoeven
2025-08-29 10:25   ` Thomas Bogendoerfer
2025-08-17 18:37 ` [PATCH 5/8] MIPS: arc: Replace deprecated strcpy() with memcpy() Thorsten Blum
2025-08-18 23:58   ` Justin Stitt
2025-08-19 10:00     ` Thorsten Blum
2025-08-29 10:26   ` Thomas Bogendoerfer
2025-08-17 18:37 ` Thorsten Blum [this message]
2025-08-19  0:02   ` [PATCH 6/8] MIPS: octeon: Replace memset(0) + deprecated strcpy() with strscpy_pad() Justin Stitt
2025-08-29 10:26   ` Thomas Bogendoerfer
2025-08-17 18:37 ` [PATCH 7/8] MIPS: octeon: Replace deprecated strcpy() in octeon_model_get_string_buffer() Thorsten Blum
2025-08-29 10:26   ` Thomas Bogendoerfer
2025-08-17 18:37 ` [PATCH 8/8] MIPS: generic: Replace deprecated strcpy() in ocelot_detect() Thorsten Blum
2025-08-29 10:27   ` Thomas Bogendoerfer
2025-08-18 23:24 ` [PATCH 1/8] MIPS: sgi-ip22: Replace deprecated strcpy() in plat_mem_setup() Justin Stitt
2025-08-29 10:25 ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250817183728.612012-6-thorsten.blum@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.