All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "André Apitzsch via B4 Relay"
	<devnull+git.apitzsch.eu@kernel.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Daniel Scally" <djrscally@gmail.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	linux-media@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Val Packett" <val@packett.cool>,
	"André Apitzsch" <git@apitzsch.eu>
Subject: Re: [PATCH 3/7] media: i2c: dw9719: Add driver_data matching
Date: Mon, 18 Aug 2025 04:28:51 +0800	[thread overview]
Message-ID: <202508180429.GKdrjNK9-lkp@intel.com> (raw)
In-Reply-To: <20250817-dw9719-v1-3-426f46c69a5a@apitzsch.eu>

Hi André,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 1357b2649c026b51353c84ddd32bc963e8999603]

url:    https://github.com/intel-lab-lkp/linux/commits/Andr-Apitzsch-via-B4-Relay/dt-bindings-media-i2c-Add-DW9718S-DW9719-and-DW9761-VCM/20250818-011316
base:   1357b2649c026b51353c84ddd32bc963e8999603
patch link:    https://lore.kernel.org/r/20250817-dw9719-v1-3-426f46c69a5a%40apitzsch.eu
patch subject: [PATCH 3/7] media: i2c: dw9719: Add driver_data matching
config: riscv-randconfig-002-20250818 (https://download.01.org/0day-ci/archive/20250818/202508180429.GKdrjNK9-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 93d24b6b7b148c47a2fa228a4ef31524fa1d9f3f)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250818/202508180429.GKdrjNK9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508180429.GKdrjNK9-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/i2c/dw9719.c:285:18: warning: cast to smaller integer type 'enum dw9719_model' from 'const void *' [-Wvoid-pointer-to-enum-cast]
     285 |         dw9719->model = (enum dw9719_model)i2c_get_match_data(client);
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +285 drivers/media/i2c/dw9719.c

   275	
   276	static int dw9719_probe(struct i2c_client *client)
   277	{
   278		struct dw9719_device *dw9719;
   279		int ret;
   280	
   281		dw9719 = devm_kzalloc(&client->dev, sizeof(*dw9719), GFP_KERNEL);
   282		if (!dw9719)
   283			return -ENOMEM;
   284	
 > 285		dw9719->model = (enum dw9719_model)i2c_get_match_data(client);
   286	
   287		dw9719->regmap = devm_cci_regmap_init_i2c(client, 8);
   288		if (IS_ERR(dw9719->regmap))
   289			return PTR_ERR(dw9719->regmap);
   290	
   291		dw9719->dev = &client->dev;
   292	
   293		dw9719->regulator = devm_regulator_get(&client->dev, "vdd");
   294		if (IS_ERR(dw9719->regulator))
   295			return dev_err_probe(&client->dev, PTR_ERR(dw9719->regulator),
   296					     "getting regulator\n");
   297	
   298		v4l2_i2c_subdev_init(&dw9719->sd, client, &dw9719_ops);
   299		dw9719->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
   300		dw9719->sd.internal_ops = &dw9719_internal_ops;
   301	
   302		ret = dw9719_init_controls(dw9719);
   303		if (ret)
   304			return ret;
   305	
   306		ret = media_entity_pads_init(&dw9719->sd.entity, 0, NULL);
   307		if (ret < 0)
   308			goto err_free_ctrl_handler;
   309	
   310		dw9719->sd.entity.function = MEDIA_ENT_F_LENS;
   311	
   312		/*
   313		 * We need the driver to work in the event that pm runtime is disable in
   314		 * the kernel, so power up and verify the chip now. In the event that
   315		 * runtime pm is disabled this will leave the chip on, so that the lens
   316		 * will work.
   317		 */
   318	
   319		ret = dw9719_power_up(dw9719, true);
   320		if (ret)
   321			goto err_cleanup_media;
   322	
   323		pm_runtime_set_active(&client->dev);
   324		pm_runtime_get_noresume(&client->dev);
   325		pm_runtime_enable(&client->dev);
   326	
   327		ret = v4l2_async_register_subdev(&dw9719->sd);
   328		if (ret < 0)
   329			goto err_pm_runtime;
   330	
   331		pm_runtime_set_autosuspend_delay(&client->dev, 1000);
   332		pm_runtime_use_autosuspend(&client->dev);
   333		pm_runtime_put_autosuspend(&client->dev);
   334	
   335		return ret;
   336	
   337	err_pm_runtime:
   338		pm_runtime_disable(&client->dev);
   339		pm_runtime_put_noidle(&client->dev);
   340		dw9719_power_down(dw9719);
   341	err_cleanup_media:
   342		media_entity_cleanup(&dw9719->sd.entity);
   343	err_free_ctrl_handler:
   344		v4l2_ctrl_handler_free(&dw9719->ctrls.handler);
   345	
   346		return ret;
   347	}
   348	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-08-17 20:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-17 17:09 [PATCH 0/7] media: i2c: dw9719: add DT compatible and DW9718S support André Apitzsch
2025-08-17 17:09 ` André Apitzsch via B4 Relay
2025-08-17 17:09 ` [PATCH 1/7] dt-bindings: media: i2c: Add DW9718S, DW9719 and DW9761 VCM André Apitzsch
2025-08-17 17:09   ` André Apitzsch via B4 Relay
2025-08-20 21:56   ` Rob Herring
2025-08-26 11:57     ` André Apitzsch
2025-08-17 17:09 ` [PATCH 2/7] media: i2c: dw9719: Deprecate dongwoon,vcm-freq André Apitzsch
2025-08-17 17:09   ` André Apitzsch via B4 Relay
2025-08-17 17:09 ` [PATCH 3/7] media: i2c: dw9719: Add driver_data matching André Apitzsch
2025-08-17 17:09   ` André Apitzsch via B4 Relay
2025-08-17 20:28   ` kernel test robot [this message]
2025-08-18  7:38   ` Sakari Ailus
2025-08-17 17:09 ` [PATCH 4/7] media: i2c: dw9719: Add DW9718S support André Apitzsch
2025-08-17 17:09   ` André Apitzsch via B4 Relay
2025-08-17 17:09 ` [PATCH 5/7] media: i2c: dw9719: Update PM last busy time upon close André Apitzsch
2025-08-17 17:09   ` André Apitzsch via B4 Relay
2025-08-18  7:37   ` Sakari Ailus
2025-08-17 17:09 ` [PATCH 6/7] media: i2c: dw9719: Add an of_match_table André Apitzsch
2025-08-17 17:09   ` André Apitzsch via B4 Relay
2025-08-17 17:09 ` [PATCH 7/7] media: i2c: dw9719: Fix power on/off sequence André Apitzsch
2025-08-17 17:09   ` André Apitzsch via B4 Relay
2025-08-18  7:44   ` Sakari Ailus
2025-09-15 20:48     ` André Apitzsch
2025-09-16 20:08       ` Val Packett
2025-09-17 10:10         ` Sakari Ailus
2025-09-18 21:31           ` André Apitzsch
2025-09-19  6:18             ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202508180429.GKdrjNK9-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+git.apitzsch.eu@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=git@apitzsch.eu \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=val@packett.cool \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.