All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: stable@vger.kernel.org, sashal@kernel.org, qat-linux@intel.com,
	Damian Muszynski <damian.muszynski@intel.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Ahsan Atta <ahsan.atta@intel.com>
Subject: Re: [PATCH 6.1 v2] crypto: qat - fix ring to service map for QAT GEN4
Date: Mon, 18 Aug 2025 13:41:13 +0200	[thread overview]
Message-ID: <2025081806-hasty-nectar-4d65@gregkh> (raw)
In-Reply-To: <aKMOiXg0KvyxWb6F@gcabiddu-mobl.ger.corp.intel.com>

On Mon, Aug 18, 2025 at 12:29:13PM +0100, Giovanni Cabiddu wrote:
> Hi Greg and Sasha,
> 
> On Tue, Jul 22, 2025 at 04:07:09PM +0100, Giovanni Cabiddu wrote:
> > [ Upstream commit a238487f7965d102794ed9f8aff0b667cd2ae886 ]
> > 
> > The 4xxx drivers hardcode the ring to service mapping. However, when
> > additional configurations where added to the driver, the mappings were
> > not updated. This implies that an incorrect mapping might be reported
> > through pfvf for certain configurations.
> > 
> > This is a backport of the upstream commit with modifications, as the
> > original patch does not apply cleanly to kernel v6.1.x. The logic has
> > been simplified to reflect the limited configurations of the QAT driver
> > in this version: crypto-only and compression.
> > 
> > Instead of dynamically computing the ring to service mappings, these are
> > now hardcoded to simplify the backport.
> > 
> > Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> > Reviewed-by: Damian Muszynski <damian.muszynski@intel.com>
> > Reviewed-by: Tero Kristo <tero.kristo@linux.intel.com>
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> > (cherry-picked from commit a238487f7965d102794ed9f8aff0b667cd2ae886)
> > [Giovanni: backport to 6.1.y, conflict resolved simplifying the logic
> > in the function get_ring_to_svc_map() as the QAT driver in v6.1 supports
> > only limited configurations (crypto only and compression).  Differs from
> > upstream as the ring to service mapping is hardcoded rather than being
> > dynamically computed.]
> > Reviewed-by: Ahsan Atta <ahsan.atta@intel.com>
> > Tested-by: Ahsan Atta <ahsan.atta@intel.com>
> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> > ---
> > V1 -> V2: changed signed-off-by area:
> >   * added (cherry-picked from ...) after last tag from upstream commit
> >   * added a note explaining how this backport differs from the original patch
> >   * added a new Signed-off-by tag for the backport author.
> 
> Just following up on this patch as I haven't seen any activity on it yet.
> 
> Was it possibly missed, or is there anything I should do to move it
> forward?

It's in a pending queue of hundreds of stable backports I have yet to
get to.  That's what I get for trying to take a vacation... :)

Don't worry, it's not lost, just that we have to process patches for the
newer stable kernels first, as that's where we have the most users.
This, and many others, will be gotten to in a week or so.

thanks,

greg k-h

      reply	other threads:[~2025-08-18 11:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 15:07 [PATCH 6.1 v2] crypto: qat - fix ring to service map for QAT GEN4 Giovanni Cabiddu
2025-07-23  4:33 ` Sasha Levin
2025-07-24 13:44   ` Giovanni Cabiddu
2025-08-18 11:29 ` Giovanni Cabiddu
2025-08-18 11:41   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025081806-hasty-nectar-4d65@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ahsan.atta@intel.com \
    --cc=damian.muszynski@intel.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=qat-linux@intel.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.