From: Jakub Kicinski <kuba@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] eth: mlx4: Fix IS_ERR() vs NULL check bug in mlx4_en_create_rx_ring
Date: Mon, 18 Aug 2025 08:31:50 -0700 [thread overview]
Message-ID: <20250818083150.6a1c05f5@kernel.org> (raw)
In-Reply-To: <20250817163830.10819-1-linmq006@gmail.com>
On Mon, 18 Aug 2025 00:38:30 +0800 Miaoqian Lin wrote:
> Replace NULL check with IS_ERR() check after calling page_pool_create()
> since this function returns error pointers (ERR_PTR).
> Using NULL check could lead to invalid pointer dereference.
The v2 patch is white-space corrupted. The v1 was fine, so maybe try to
send it the way you send the v1?
Please do *not* try to send the new version of the patch in reply to
the thread of v1. The link to v1 you put in the changelog is enough.
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-18 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 2:50 [PATCH] eth: mlx4: Fix IS_ERR() vs NULL check bug in mlx4_en_create_rx_ring Miaoqian Lin
2025-08-05 19:21 ` Simon Horman
2025-08-05 23:09 ` Jakub Kicinski
2025-08-06 8:00 ` Tariq Toukan
2025-08-17 16:38 ` [PATCH v2] " Miaoqian Lin
2025-08-18 15:31 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-08-28 6:50 Miaoqian Lin
2025-08-28 11:51 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818083150.6a1c05f5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.