From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Zahka <daniel.zahka@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, willemb@google.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: tso: increase the retransmit threshold
Date: Mon, 18 Aug 2025 08:52:46 -0700 [thread overview]
Message-ID: <20250818085246.754ea32d@kernel.org> (raw)
In-Reply-To: <f30a1b37-fa50-4b23-a9d1-841b91bf9806@gmail.com>
On Fri, 15 Aug 2025 21:41:37 -0400 Daniel Zahka wrote:
> On 8/15/25 6:41 PM, Jakub Kicinski wrote:
> > We see quite a few flakes during the TSO test against virtualized
> > devices in NIPA. There's often 10-30 retransmissions during the
> > test. Sometimes as many as 100. Set the retransmission threshold
> > at 1/4th of the wire frame target.
>
> Did this issue preexist these commits:
> b25b44cd178c ("selftests: drv-net: tso: fix non-tunneled tso6 test case
> name")
> 2cfbcc5d8af9 ("selftests: drv-net: tso: fix vxlan tunnel flags to get
> correct gso_type")
> 266b835e5e84 ("selftests: drv-net: tso: enable test cases based on
> hw_features")
>
> or is this a possible regression?
I think it existed before, but it was much harder to spot flakes prior
to those fixes because the whole test was failing. Here's an example of
110 retransmits 3 weeks before those fixes:
https://netdev-3.bots.linux.dev/vmksft-fbnic-qemu/results/192642/4-tso-py/stdout
next prev parent reply other threads:[~2025-08-18 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 22:41 [PATCH net-next] selftests: drv-net: tso: increase the retransmit threshold Jakub Kicinski
2025-08-16 1:41 ` Daniel Zahka
2025-08-18 15:52 ` Jakub Kicinski [this message]
2025-08-20 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818085246.754ea32d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.